You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "jiangzho (via GitHub)" <gi...@apache.org> on 2026/09/29 20:29:09 UTC
[PR] [SPARK-59879] Close PrintWriter with try-with-resources in ConfOptionDocGenerator [spark-kubernetes-operator]
jiangzho opened a new pull request, #912:
URL: https://github.com/apache/spark-kubernetes-operator/pull/912
### What changes were proposed in this pull request?
Wrap the `PrintWriter` used in `ConfOptionDocGenerator.generate()` in a try-with-resources statement instead of a manual `close()` call.
### Why are the changes needed?
The writer was not guaranteed to be closed if an exception occurred while writing the docs table, risking a resource leak.
### How was this patch tested?
Existing unit tests for `ConfOptionDocGenerator` cover doc generation; no behavior change, only resource-safety.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (claude-sonnet-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59879] Close PrintWriter with try-with-resources in ConfOptionDocGenerator [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #912:
URL: https://github.com/apache/spark-kubernetes-operator/pull/912#issuecomment-5934734009
Merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59879] Close PrintWriter with try-with-resources in ConfOptionDocGenerator [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #912: [SPARK-59879] Close PrintWriter with try-with-resources in ConfOptionDocGenerator
URL: https://github.com/apache/spark-kubernetes-operator/pull/912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59879] Close PrintWriter with try-with-resources in ConfOptionDocGenerator [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #912:
URL: https://github.com/apache/spark-kubernetes-operator/pull/912#issuecomment-5934738525
Thank you, @jiangzho !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org