You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Zack Shoylev <no...@github.com> on 2015/12/04 05:13:06 UTC
[jclouds] Starts work on alias and name fallback for extensions
(#889)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/889
-- Commit Summary --
* Starts work on alias and name fallback for extensions
-- File Changes --
M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/config/KeystoneHttpApiModule.java (6)
R apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/config/NamespaceAliases.java (2)
M apis/openstack-keystone/src/main/java/org/jclouds/openstack/v2_0/functions/PresentWhenExtensionAnnotationNamespaceEqualsAnyNamespaceInExtensionsSet.java (20)
M apis/openstack-keystone/src/main/java/org/jclouds/openstack/v2_0/predicates/ExtensionPredicates.java (33)
M apis/openstack-keystone/src/main/java/org/jclouds/openstack/v2_0/services/Extension.java (37)
M apis/openstack-keystone/src/test/java/org/jclouds/openstack/v2_0/functions/PresentWhenExtensionAnnotationNamespaceEqualsAnyNamespaceInExtensionsSetTest.java (36)
M apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/config/NovaHttpApiModule.java (4)
M providers/rackspace-cloudservers-uk/src/main/java/org/jclouds/rackspace/cloudservers/uk/config/CloudServersUKHttpApiModule.java (4)
M providers/rackspace-cloudservers-us/src/main/java/org/jclouds/rackspace/cloudservers/us/config/CloudServersUSHttpApiModule.java (4)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/889.patch
https://github.com/jclouds/jclouds/pull/889.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/889
Re: [jclouds] Allows extensions to fall back on using an optional
name in keystone (#889)
Posted by Ignasi Barrera <no...@github.com>.
OH, is there any name that should be added by default to the existing apis?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/889#issuecomment-162250010
Re: [jclouds] Allows extensions to fall back on using an optional
name in keystone (#889)
Posted by Ignasi Barrera <no...@github.com>.
+1 thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/889#issuecomment-164465396
Re: [jclouds] Allows extensions to fall back on using an optional
name in keystone (#889)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -125,6 +138,23 @@ public void testPresentWhenAliasForExtensionMapsToNamespace() throws SecurityExc
>
> }
>
> + /**
> + * In devstack and going forward, namespaces are being deprecated. When namespace is missing (or replaced with a
> + * "fake" /fake namespace), allow matching by name and alias.
> + *
> + */
> + public void testPresentWhenNameSpaceIsMissingAndMatchByNameOrAlias() throws SecurityException, NoSuchMethodException {
> +// fail("its a no go");
Remove this comment?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/889/files#r46763402
Re: [jclouds] Allows extensions to fall back on using an optional
name in keystone (#889)
Posted by Zack Shoylev <no...@github.com>.
Closed #889.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/889#event-491207053
Re: [jclouds] Allows extensions to fall back on using an optional
name in keystone (#889)
Posted by Ignasi Barrera <no...@github.com>.
Thanks @zack-shoylev! LGTM!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/889#issuecomment-162249970
Re: [jclouds] Allows extensions to fall back on using an optional
name in keystone (#889)
Posted by Zack Shoylev <no...@github.com>.
Needed for https://issues.apache.org/jira/browse/JCLOUDS-1013?filter=-1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/889#issuecomment-162066528
Re: [jclouds] Allows extensions to fall back on using an optional
name in keystone (#889)
Posted by Zack Shoylev <no...@github.com>.
merged
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/889#issuecomment-164494202
Re: [jclouds] Allows extensions to fall back on using an optional
name in keystone (#889)
Posted by Zack Shoylev <no...@github.com>.
@nacx We need at least FloatingIPApi because there is a jira for it, but there might be a few other extensions that we might want. I am thinking of adding names for the nova extensions and probably some of the neutron ones, but wanted to do it in a separate pr.
I will clean this up and merge, then double check which names are needed for the next PR.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/889#issuecomment-164433268
Re: [jclouds] Allows extensions to fall back on using an optional
name in keystone (#889)
Posted by Ignasi Barrera <no...@github.com>.
> @@ -125,6 +138,23 @@ public void testPresentWhenAliasForExtensionMapsToNamespace() throws SecurityExc
>
> }
>
> + /**
> + * In devstack and going forward, namespaces are being deprecated. When namespace is missing (or replaced with a
> + * "fake" /fake namespace), allow matching by name and alias.
> + *
> + */
> + public void testPresentWhenNameSpaceIsMissingAndMatchByNameOrAlias() throws SecurityException, NoSuchMethodException {
> +// fail("its a no go");
> + Extension floatingIpsWithFakeNamespace = floatingIps.toBuilder()
> + .namespace(URI.create("http://docs.openstack.org/ext/fake"))
> + /*.name("Floating_ips")*/.build();
Remove this one too?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/889/files#r46763404
Re: [jclouds] Allows extensions to fall back on using an optional
name in keystone (#889)
Posted by Zack Shoylev <no...@github.com>.
https://github.com/jclouds/jclouds/pull/892
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/889#issuecomment-164861012