You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@maven.apache.org by "Martin W. Kirst" <x....@gmail.com> on 2015/11/01 00:41:37 UTC

[call for review] MNG-3525 Settings.xml allowing mirror definitions inside profiles

Hi there,

I've added a patch to https://issues.apache.org/jira/browse/MNG-3525
and I would like to ask you, if one might have a look on ... doing a
review, please.

While extending the class Settings and implementing I stumbled upon
to similar classes: DefaultMavenExecutionRequestPopulator and
SettingsXmlConfigurationProcessor.

There is a lot of code duplication, there.
What are their responsibilities?
Or, did I walked into the middle of a refactoring?

Any feedback is welcome.

Thanks in advance.

Regards
Martin W. Kirst
Twitter, Github, Skype: @nitram509

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org