You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/06/26 21:59:27 UTC

Review Request 23087: Fix build break in code generator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23087/
-----------------------------------------------------------

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
-------

Fixes these compile errors:
:compileGeneratedJava
/Users/bill/code/aurora/dist/generated-src/gen-java/org/apache/aurora/scheduler/storage/entities/ITaskQuery.java:35: error: cannot find symbol
  private final ImmutableSet<IScheduleStatus> statuses;
                             ^
  symbol:   class IScheduleStatus
  location: class ITaskQuery
/Users/bill/code/aurora/dist/generated-src/gen-java/org/apache/aurora/scheduler/storage/entities/ITaskQuery.java:144: error: cannot find symbol
  public ImmutableSet<IScheduleStatus> getStatuses() {
                      ^
  symbol:   class IScheduleStatus
  location: class ITaskQuery
/Users/bill/code/aurora/dist/generated-src/gen-java/org/apache/aurora/scheduler/storage/entities/ITaskQuery.java:49: error: cannot find symbol
        ? ImmutableSet.<IScheduleStatus>of()
                        ^
  symbol:   class IScheduleStatus
  location: class ITaskQuery
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
3 errors


Diffs
-----

  src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d16cfddc7163aaedbdc2406bb5f3091b3c65ccbd 

Diff: https://reviews.apache.org/r/23087/diff/


Testing
-------

$ git clean -fdx
$ ./gradlew clean build -Pq


Thanks,

Bill Farner


Re: Review Request 23087: Fix build break in code generator.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23087/#review46795
-----------------------------------------------------------

Ship it!


Ship It!

- Maxim Khutornenko


On June 26, 2014, 7:59 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23087/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 7:59 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixes these compile errors:
> :compileGeneratedJava
> /Users/bill/code/aurora/dist/generated-src/gen-java/org/apache/aurora/scheduler/storage/entities/ITaskQuery.java:35: error: cannot find symbol
>   private final ImmutableSet<IScheduleStatus> statuses;
>                              ^
>   symbol:   class IScheduleStatus
>   location: class ITaskQuery
> /Users/bill/code/aurora/dist/generated-src/gen-java/org/apache/aurora/scheduler/storage/entities/ITaskQuery.java:144: error: cannot find symbol
>   public ImmutableSet<IScheduleStatus> getStatuses() {
>                       ^
>   symbol:   class IScheduleStatus
>   location: class ITaskQuery
> /Users/bill/code/aurora/dist/generated-src/gen-java/org/apache/aurora/scheduler/storage/entities/ITaskQuery.java:49: error: cannot find symbol
>         ? ImmutableSet.<IScheduleStatus>of()
>                         ^
>   symbol:   class IScheduleStatus
>   location: class ITaskQuery
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> 3 errors
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py d16cfddc7163aaedbdc2406bb5f3091b3c65ccbd 
> 
> Diff: https://reviews.apache.org/r/23087/diff/
> 
> 
> Testing
> -------
> 
> $ git clean -fdx
> $ ./gradlew clean build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>