You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2021/01/04 18:40:06 UTC

[Impala-ASF-CR] IMPALA-6101: call DataStreamMgr::Cancel() once per query

Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16901 )

Change subject: IMPALA-6101: call DataStreamMgr::Cancel() once per query
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16901/1/be/src/runtime/krpc-data-stream-mgr.h
File be/src/runtime/krpc-data-stream-mgr.h:

http://gerrit.cloudera.org:8080/#/c/16901/1/be/src/runtime/krpc-data-stream-mgr.h@372
PS1, Line 372: /// An ordered set of receiver IDs so that we can easily find all receiver IDs belonging
             :   /// to a fragment instance (by calling std::set::lower_bound(finst_id, 0) to find the
             :   /// first entry and iterating until the entry's finst_id doesn't match).
This comment is a bit stale now.



-- 
To view, visit http://gerrit.cloudera.org:8080/16901
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7677d21f0aaddc3d4b56f72c0470ea850e34611e
Gerrit-Change-Number: 16901
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Jan 2021 18:40:06 +0000
Gerrit-HasComments: Yes