You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/11/16 06:35:32 UTC

[GitHub] [ratis] SzyWilliam commented on pull request #784: RATIS-1743. Memory leak in SegmentedRaftLogWorker due to metrics.

SzyWilliam commented on PR #784:
URL: https://github.com/apache/ratis/pull/784#issuecomment-1316449934

   @szetszwo Bravo! I've been following this issue, 
   `metricRegistry` holds reference to `SegmentedRaftLogWorker` after close() due to lambda closure. `SegmentedRaftLogWorker` also holds the reference to the memorized supplier of shared buffer. Thus, the shared buffer cannot be automatically collected, we have to manually set it to null in `close()` hook, just as this PR did. Am I getting it right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org