You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/09/01 02:57:57 UTC
[GitHub] [arrow] kou opened a new pull request, #37508: GH-37507: [GLib] Don't use implicit include directories
kou opened a new pull request, #37508:
URL: https://github.com/apache/arrow/pull/37508
### Rationale for this change
Our source code should not have "#include"s that depend on source/binary directories exists in include path.
This also fixes that CUDA's cuda.h isn't included problem.
### What changes are included in this PR?
Don't use implicit include directories.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #37508: GH-37507: [GLib] Don't use implicit include directories
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37508:
URL: https://github.com/apache/arrow/pull/37508#issuecomment-1704952668
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 715cc98de3d1dc03090b2693d36a22c796cf94d2.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/16470534502) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #37508: GH-37507: [GLib] Don't use implicit include directories
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #37508:
URL: https://github.com/apache/arrow/pull/37508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #37508: GH-37507: [GLib] Don't use implicit include directories
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #37508:
URL: https://github.com/apache/arrow/pull/37508#issuecomment-1702072229
@github-actions crossbow submit test-ubuntu-22.04-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #37508: GH-37507: [GLib] Don't use implicit include directories
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #37508:
URL: https://github.com/apache/arrow/pull/37508#issuecomment-1702165463
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37508: GH-37507: [GLib] Don't use implicit include directories
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37508:
URL: https://github.com/apache/arrow/pull/37508#issuecomment-1702077532
Revision: 76cabd05eacb2e415861da04d9a67c97e08378fa
Submitted crossbow builds: [ursacomputing/crossbow @ actions-31589345ea](https://github.com/ursacomputing/crossbow/branches/all?query=actions-31589345ea)
|Task|Status|
|----|------|
|test-ubuntu-22.04-docs|[](https://github.com/ursacomputing/crossbow/actions/runs/6044887885/job/16404127704)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37508: GH-37507: [GLib] Don't use implicit include directories
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37508:
URL: https://github.com/apache/arrow/pull/37508#issuecomment-1702072664
:warning: GitHub issue #37507 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org