You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "BiteTheDDDDt (via GitHub)" <gi...@apache.org> on 2026/04/24 08:48:35 UTC

[PR] branch-4.1: [fix](be) Fix RuntimeFilter selectivity sampling_frequency lost during VExprContext recreation #62355 [doris]

BiteTheDDDDt opened a new pull request, #62810:
URL: https://github.com/apache/doris/pull/62810

   Cherry-pick of #62355 to branch-4.1.
   
   ## Conflict resolution
   
   `be/src/exec/runtime_filter/runtime_filter_consumer.cpp` — branch-4.1 already replaced `if (null_aware) return Status::InternalError(...)` with `DCHECK(null_aware == false) << "..."` for the bitmap-predicate branch. Kept 4.1's `DCHECK` style and applied the new `sampling_frequency` argument in `VRuntimeFilterWrapper::create_shared(...)`. The other two min/max branches in the same file already used `DCHECK` on both branches and merged automatically.
   
   No code logic from #62355 was changed.
   
   ## Original PR
   
   #62355


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.1: [fix](be) Fix RuntimeFilter selectivity sampling_frequency lost during VExprContext recreation #62355 [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62810:
URL: https://github.com/apache/doris/pull/62810#issuecomment-4311858226

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.1: [fix](be) Fix RuntimeFilter selectivity sampling_frequency lost during VExprContext recreation #62355 [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #62810:
URL: https://github.com/apache/doris/pull/62810#issuecomment-4317503783

   skip buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.1: [fix](be) Fix RuntimeFilter selectivity sampling_frequency lost during VExprContext recreation #62355 [doris]

Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #62810:
URL: https://github.com/apache/doris/pull/62810#issuecomment-4311872950

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.1: [fix](be) Fix RuntimeFilter selectivity sampling_frequency lost during VExprContext recreation #62355 [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62810:
URL: https://github.com/apache/doris/pull/62810#issuecomment-4316858078

   # BE Regression && UT Coverage Report
   Increment line coverage `100.00% (13/13)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/62810_b19090140d855e63c066df6950801de40e029b89_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/62810_b19090140d855e63c066df6950801de40e029b89_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 70.79% (26043/36788) |
   | Line Coverage     | 52.94% (271023/511972) |
   | Region Coverage   | 46.34% (207817/448506) |
   | Branch Coverage   | 49.77% (94500/189873) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.1: [fix](be) Fix RuntimeFilter selectivity sampling_frequency lost during VExprContext recreation #62355 [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #62810:
URL: https://github.com/apache/doris/pull/62810#issuecomment-4316084493

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.1: [fix](be) Fix RuntimeFilter selectivity sampling_frequency lost during VExprContext recreation #62355 [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62810:
URL: https://github.com/apache/doris/pull/62810#issuecomment-4316642146

   # BE UT Coverage Report
   Increment line coverage `84.62% (11/13)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/b19090140d855e63c066df6950801de40e029b89_b19090140d855e63c066df6950801de40e029b89/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/b19090140d855e63c066df6950801de40e029b89_b19090140d855e63c066df6950801de40e029b89/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 53.25% (20004/37568) |
   | Line Coverage     | 36.69% (188516/513789) |
   | Region Coverage   | 33.05% (146560/443494) |
   | Branch Coverage   | 34.13% (64129/187889) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.1: [fix](be) Fix RuntimeFilter selectivity sampling_frequency lost during VExprContext recreation #62355 [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62810:
URL: https://github.com/apache/doris/pull/62810#issuecomment-4312835990

   # BE UT Coverage Report
   Increment line coverage `84.62% (11/13)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/e08250ec0b226800e48428abb9e59d788c5e1524_e08250ec0b226800e48428abb9e59d788c5e1524/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/e08250ec0b226800e48428abb9e59d788c5e1524_e08250ec0b226800e48428abb9e59d788c5e1524/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 53.28% (20013/37563) |
   | Line Coverage     | 36.70% (188533/513670) |
   | Region Coverage   | 33.05% (146551/443368) |
   | Branch Coverage   | 34.13% (64113/187841) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.1: [fix](be) Fix RuntimeFilter selectivity sampling_frequency lost during VExprContext recreation #62355 [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62810:
URL: https://github.com/apache/doris/pull/62810#issuecomment-4312942567

   # BE Regression && UT Coverage Report
   Increment line coverage `15.38% (2/13)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/62810_e08250ec0b226800e48428abb9e59d788c5e1524_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/62810_e08250ec0b226800e48428abb9e59d788c5e1524_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 54.43% (20020/36783) |
   | Line Coverage     | 35.45% (181424/511845) |
   | Region Coverage   | 29.62% (132815/448344) |
   | Branch Coverage   | 31.21% (59250/189819) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] branch-4.1: [fix](be) Fix RuntimeFilter selectivity sampling_frequency lost during VExprContext recreation #62355 [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #62810:
URL: https://github.com/apache/doris/pull/62810


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org