You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by ta...@apache.org on 2021/03/23 09:45:54 UTC
[hadoop] branch branch-3.2 updated: HDFS-15906. Close FSImage and
FSNamesystem after formatting is complete (#2800)
This is an automated email from the ASF dual-hosted git repository.
tasanuma pushed a commit to branch branch-3.2
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/branch-3.2 by this push:
new d05d156 HDFS-15906. Close FSImage and FSNamesystem after formatting is complete (#2800)
d05d156 is described below
commit d05d15620e320d28bfbeeee2a4f5224e69062528
Author: litao <to...@gmail.com>
AuthorDate: Tue Mar 23 17:45:24 2021 +0800
HDFS-15906. Close FSImage and FSNamesystem after formatting is complete (#2800)
---
.../java/org/apache/hadoop/hdfs/server/namenode/NameNode.java | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
index 30bf4f85..7f62d2c 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
@@ -1204,8 +1204,9 @@ public class NameNode extends ReconfigurableBase implements
System.out.println("Formatting using clusterid: " + clusterId);
FSImage fsImage = new FSImage(conf, nameDirsToFormat, editDirsToFormat);
+ FSNamesystem fsn = null;
try {
- FSNamesystem fsn = new FSNamesystem(conf, fsImage);
+ fsn = new FSNamesystem(conf, fsImage);
fsImage.getEditLog().initJournalsForWrite();
// Abort NameNode format if reformat is disabled and if
@@ -1230,8 +1231,14 @@ public class NameNode extends ReconfigurableBase implements
fsImage.format(fsn, clusterId, force);
} catch (IOException ioe) {
LOG.warn("Encountered exception during format: ", ioe);
- fsImage.close();
throw ioe;
+ } finally {
+ if (fsImage != null) {
+ fsImage.close();
+ }
+ if (fsn != null) {
+ fsn.close();
+ }
}
return false;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org