You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "ZhangYao (Code Review)" <ge...@cloudera.org> on 2019/12/22 14:15:15 UTC
[kudu-CR] KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
ZhangYao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14945
Change subject: KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
......................................................................
KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Not only those key columns which can convert to range but also
those non-nullable columns which can optimize with IS NOT NULL
predicates.
Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
---
M src/kudu/common/scan_spec-test.cc
M src/kudu/common/scan_spec.cc
M src/kudu/common/scan_spec.h
M src/kudu/tserver/tablet_service.cc
4 files changed, 84 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/14945/1
--
To view, visit http://gerrit.cloudera.org:8080/14945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
Gerrit-Change-Number: 14945
Gerrit-PatchSet: 1
Gerrit-Owner: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14945
to look at the new patch set (#2).
Change subject: KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
......................................................................
KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Not only those key columns which can convert to range but also
those non-nullable columns which can optimize with IS NOT NULL
predicates.
Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
---
M src/kudu/common/scan_spec-test.cc
M src/kudu/common/scan_spec.cc
M src/kudu/common/scan_spec.h
M src/kudu/tserver/tablet_service.cc
4 files changed, 85 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/14945/2
--
To view, visit http://gerrit.cloudera.org:8080/14945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
Gerrit-Change-Number: 14945
Gerrit-PatchSet: 2
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14945
to look at the new patch set (#4).
Change subject: KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
......................................................................
KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Not only those key columns which can convert to range but also
those non-nullable columns which can optimize with IS NOT NULL
predicates.
Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
---
M src/kudu/common/scan_spec-test.cc
M src/kudu/common/scan_spec.cc
M src/kudu/common/scan_spec.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
5 files changed, 135 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/14945/4
--
To view, visit http://gerrit.cloudera.org:8080/14945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
Gerrit-Change-Number: 14945
Gerrit-PatchSet: 4
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14945
to look at the new patch set (#6).
Change subject: KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
......................................................................
KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Not only those key columns which can convert to range but also
those non-nullable columns which can optimize with IS NOT NULL
predicates.
Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
---
M src/kudu/common/scan_spec-test.cc
M src/kudu/common/scan_spec.cc
M src/kudu/common/scan_spec.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
5 files changed, 146 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/14945/6
--
To view, visit http://gerrit.cloudera.org:8080/14945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
Gerrit-Change-Number: 14945
Gerrit-PatchSet: 6
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14945 )
Change subject: KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
......................................................................
Patch Set 1:
Also check the log of 'ClientTest, TestScanPredicateKeyColNotProjected' for example.
Before the patch:
Scan Projection: (
int_val INT32 NOT NULL,
key INT32 NOT NULL,
PRIMARY KEY ()
)
After this patch:
I2019-12-22 21:00:03.584184 82430 tablet_service.cc:2377] Scan Projection: (
int_val INT32 NOT NULL,
PRIMARY KEY ()
)
--
To view, visit http://gerrit.cloudera.org:8080/14945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
Gerrit-Change-Number: 14945
Gerrit-PatchSet: 1
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Sun, 22 Dec 2019 14:17:58 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14945 )
Change subject: KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
......................................................................
Patch Set 2:
(4 comments)
> (4 comments)
>
> Could you add an end-to-end test that exercises the scan path in
> tablet_service.cc too?
Added :)
http://gerrit.cloudera.org:8080/#/c/14945/2/src/kudu/common/scan_spec.h
File src/kudu/common/scan_spec.h:
http://gerrit.cloudera.org:8080/#/c/14945/2/src/kudu/common/scan_spec.h@73
PS2, Line 73: // Build missing column from subtraction between predicates and projection.
> Nit: how about "Get columns that are present in the predicates but not in t
Done
http://gerrit.cloudera.org:8080/#/c/14945/2/src/kudu/common/scan_spec.h@74
PS2, Line 74: std::vector<ColumnSchema> BuildMissingColumn(const Schema& projection);
> Nit: rename to GetMissingColumns
Done
http://gerrit.cloudera.org:8080/#/c/14945/2/src/kudu/common/scan_spec.cc
File src/kudu/common/scan_spec.cc:
http://gerrit.cloudera.org:8080/#/c/14945/2/src/kudu/common/scan_spec.cc@165
PS2, Line 165: std::unordered_set<string> missing_col_names;
> Add a using for this.
Done
http://gerrit.cloudera.org:8080/#/c/14945/2/src/kudu/common/scan_spec.cc@168
PS2, Line 168: predicate.column().name()
> This is repeated three times; could you store it in a local cref?
Done
--
To view, visit http://gerrit.cloudera.org:8080/14945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
Gerrit-Change-Number: 14945
Gerrit-PatchSet: 2
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Sat, 04 Jan 2020 04:59:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14945 )
Change subject: KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14945/5/src/kudu/tserver/tablet_server-test.cc
File src/kudu/tserver/tablet_server-test.cc:
http://gerrit.cloudera.org:8080/#/c/14945/5/src/kudu/tserver/tablet_server-test.cc@2712
PS5, Line 2712: // only few schema
: SchemaBuilder sb(schema_);
: // Remove key column and next column from the projection.
> Nit: maybe replace these two comments with "Set up a projection without the
Done
http://gerrit.cloudera.org:8080/#/c/14945/5/src/kudu/tserver/tablet_server-test.cc@2743
PS5, Line 2743: // Drain all the rows from the scanner.
> If you can call ScannerManager::ListScans, you can test that the iterator s
Thanks for your advice :)
--
To view, visit http://gerrit.cloudera.org:8080/14945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
Gerrit-Change-Number: 14945
Gerrit-PatchSet: 5
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Sun, 05 Jan 2020 08:59:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14945 )
Change subject: KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/14945/5/src/kudu/tserver/tablet_server-test.cc
File src/kudu/tserver/tablet_server-test.cc:
http://gerrit.cloudera.org:8080/#/c/14945/5/src/kudu/tserver/tablet_server-test.cc@2712
PS5, Line 2712: // only few schema
: SchemaBuilder sb(schema_);
: // Remove key column and next column from the projection.
Nit: maybe replace these two comments with "Set up a projection without the key columns or the column after the last key column."
http://gerrit.cloudera.org:8080/#/c/14945/5/src/kudu/tserver/tablet_server-test.cc@2743
PS5, Line 2743: // Drain all the rows from the scanner.
If you can call ScannerManager::ListScans, you can test that the iterator stats include the correct columns.
--
To view, visit http://gerrit.cloudera.org:8080/14945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
Gerrit-Change-Number: 14945
Gerrit-PatchSet: 5
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Sat, 04 Jan 2020 22:30:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14945 )
Change subject: KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
......................................................................
Patch Set 5:
The final projection of test in tablet_server-test is showing below.
tablet_service.cc:2378 Scan projection: (
string_val STRING NULLABLE,
PRIMARY KEY ()
)
It's expected.
--
To view, visit http://gerrit.cloudera.org:8080/14945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
Gerrit-Change-Number: 14945
Gerrit-PatchSet: 5
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Sat, 04 Jan 2020 15:07:11 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14945
to look at the new patch set (#3).
Change subject: KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
......................................................................
KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Not only those key columns which can convert to range but also
those non-nullable columns which can optimize with IS NOT NULL
predicates.
Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
---
M src/kudu/common/scan_spec-test.cc
M src/kudu/common/scan_spec.cc
M src/kudu/common/scan_spec.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
5 files changed, 134 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/14945/3
--
To view, visit http://gerrit.cloudera.org:8080/14945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
Gerrit-Change-Number: 14945
Gerrit-PatchSet: 3
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14945
to look at the new patch set (#5).
Change subject: KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
......................................................................
KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Not only those key columns which can convert to range but also
those non-nullable columns which can optimize with IS NOT NULL
predicates.
Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
---
M src/kudu/common/scan_spec-test.cc
M src/kudu/common/scan_spec.cc
M src/kudu/common/scan_spec.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
5 files changed, 136 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/14945/5
--
To view, visit http://gerrit.cloudera.org:8080/14945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
Gerrit-Change-Number: 14945
Gerrit-PatchSet: 5
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14945 )
Change subject: KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
......................................................................
KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Not only those key columns which can convert to range but also
those non-nullable columns which can optimize with IS NOT NULL
predicates.
Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
Reviewed-on: http://gerrit.cloudera.org:8080/14945
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/common/scan_spec-test.cc
M src/kudu/common/scan_spec.cc
M src/kudu/common/scan_spec.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
5 files changed, 145 insertions(+), 23 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
Gerrit-Change-Number: 14945
Gerrit-PatchSet: 7
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14945 )
Change subject: KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
......................................................................
Patch Set 2:
(4 comments)
Could you add an end-to-end test that exercises the scan path in tablet_service.cc too?
http://gerrit.cloudera.org:8080/#/c/14945/2/src/kudu/common/scan_spec.h
File src/kudu/common/scan_spec.h:
http://gerrit.cloudera.org:8080/#/c/14945/2/src/kudu/common/scan_spec.h@73
PS2, Line 73: // Build missing column from subtraction between predicates and projection.
Nit: how about "Get columns that are present in the predicates but not in the projection?"
http://gerrit.cloudera.org:8080/#/c/14945/2/src/kudu/common/scan_spec.h@74
PS2, Line 74: std::vector<ColumnSchema> BuildMissingColumn(const Schema& projection);
Nit: rename to GetMissingColumns
http://gerrit.cloudera.org:8080/#/c/14945/2/src/kudu/common/scan_spec.cc
File src/kudu/common/scan_spec.cc:
http://gerrit.cloudera.org:8080/#/c/14945/2/src/kudu/common/scan_spec.cc@165
PS2, Line 165: std::unordered_set<string> missing_col_names;
Add a using for this.
http://gerrit.cloudera.org:8080/#/c/14945/2/src/kudu/common/scan_spec.cc@168
PS2, Line 168: predicate.column().name()
This is repeated three times; could you store it in a local cref?
--
To view, visit http://gerrit.cloudera.org:8080/14945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
Gerrit-Change-Number: 14945
Gerrit-PatchSet: 2
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Sun, 29 Dec 2019 18:57:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14945 )
Change subject: KUDU-3032 Prevent selecting unnecessarily columns after scan optimization
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14945
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82c30c5272b6fc114b710df9d6c31d5d1e319e31
Gerrit-Change-Number: 14945
Gerrit-PatchSet: 6
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Mon, 06 Jan 2020 05:19:08 +0000
Gerrit-HasComments: No