You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2021/09/14 00:18:05 UTC
[GitHub] [tinkerpop] xiazcy opened a new pull request #1473: TINKERPOP-2569: Reconnect if java driver fails to initialize
xiazcy opened a new pull request #1473:
URL: https://github.com/apache/tinkerpop/pull/1473
https://issues.apache.org/jira/browse/TINKERPOP-2569
Made minor changes to the initialization of the Java driver Cluster and Client, such that hosts are marked as available only after successfully initializing connection pools, to fix reconnection failures when client was initialized on a dead host that restarts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1473: TINKERPOP-2569: Reconnect if java driver fails to initialize
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1473:
URL: https://github.com/apache/tinkerpop/pull/1473#issuecomment-921085856
> Travis is still not triggered though.
It's probably not necessary but I'm curious if re-issuing the PR would fix it. Please go ahead and close this one and re-open and let's see what happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy edited a comment on pull request #1473: TINKERPOP-2569: Reconnect if java driver fails to initialize
Posted by GitBox <gi...@apache.org>.
xiazcy edited a comment on pull request #1473:
URL: https://github.com/apache/tinkerpop/pull/1473#issuecomment-920380780
Yes, sorry, just fixed it! I will keep that in mind for the future.
Also, the tests are now passing for me locally after the backported changes, Travis is still not triggered though. Should I try closing this PR and reopening another one to see?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1473: TINKERPOP-2569: Reconnect if java driver fails to initialize
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1473:
URL: https://github.com/apache/tinkerpop/pull/1473#issuecomment-920357058
perhaps you were already going to fix this, but please prefer to `git rebase` rather than `git merge` so that we keep the git history nice. you should only have your single commit in this PR with just your changes (currently you can see my changes in this diff with my commit as well).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #1473: TINKERPOP-2569: Reconnect if java driver fails to initialize
Posted by GitBox <gi...@apache.org>.
xiazcy commented on pull request #1473:
URL: https://github.com/apache/tinkerpop/pull/1473#issuecomment-920274244
I'm not sure why CI wasn't automatically triggered and I don't see a way to manually trigger it, but I've ran both `GremlinDriverIntegrateTest` and `GremlinServerIntegrateTest` locally and tests that passed before making the changes also passed after the proposed changes.
There were 3 tests inside `GremlinDriverIntegrateTest` that failed persistently for me locally, I'm not sure if I should be concerned about them? They could be due to the fact that I'm running the build on a macOS.
- shouldFailWithScriptExecutionException
```
java.lang.AssertionError:
Expected: a string starting with "java.lang.ArithmeticException: Division by zero\n\tat java.math.BigDecimal.divide(BigDecimal.java"
but: was "java.lang.ArithmeticException: Division by zero
```
- shouldWorkWithGraphSONExtendedV2Serialization
```
java.lang.AssertionError:
Expected :2021-09-15T18:07:09.294325Z
Actual :2021-09-15T18:07:09.294Z
```
- shouldWorkWithGraphSONExtendedV3Serialization
```
java.lang.AssertionError:
Expected :2021-09-15T18:13:39.049275Z
Actual :2021-09-15T18:13:39.049Z
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1473: TINKERPOP-2569: Reconnect if java driver fails to initialize
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1473:
URL: https://github.com/apache/tinkerpop/pull/1473#issuecomment-920299337
I backported several changes from 3.5-dev related to these tests which I think will allow them to pass better for you. I'm not sure that it's macos specifically, but i think possibly related to various JVM types/versions...not wholly sure. In any case, please rebase your PR on on 3.4-dev and let's see if that fixes anything (and if it actually triggers travis). Please let me know if that change helped?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy closed pull request #1473: TINKERPOP-2569: Reconnect if java driver fails to initialize
Posted by GitBox <gi...@apache.org>.
xiazcy closed pull request #1473:
URL: https://github.com/apache/tinkerpop/pull/1473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #1473: TINKERPOP-2569: Reconnect if java driver fails to initialize
Posted by GitBox <gi...@apache.org>.
xiazcy commented on pull request #1473:
URL: https://github.com/apache/tinkerpop/pull/1473#issuecomment-920380780
Yes, sorry, just fixed it! I will keep that in mind for the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org