You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2022/05/20 11:21:55 UTC
[lucene] branch branch_9x updated: LUCENE-10579: fix smoketester backwards-check to not parse stdout (#903)
This is an automated email from the ASF dual-hosted git repository.
rmuir pushed a commit to branch branch_9x
in repository https://gitbox.apache.org/repos/asf/lucene.git
The following commit(s) were added to refs/heads/branch_9x by this push:
new 5a5c8bca4e6 LUCENE-10579: fix smoketester backwards-check to not parse stdout (#903)
5a5c8bca4e6 is described below
commit 5a5c8bca4e691d91801d04d881aa25560413835c
Author: Robert Muir <rm...@apache.org>
AuthorDate: Fri May 20 07:20:57 2022 -0400
LUCENE-10579: fix smoketester backwards-check to not parse stdout (#903)
This is very noisy, can contain gradle status updates, various other tests.verbose prints from other threads, you name it.
It causes the check to be flaky, and randomly "miss" seeing a test that executed.
Instead, let's look at the zip files. We can still preserve the essence of what the test wants to do, but without any flakiness.
---
dev-tools/scripts/smokeTestRelease.py | 32 +++++++++-----------------------
1 file changed, 9 insertions(+), 23 deletions(-)
diff --git a/dev-tools/scripts/smokeTestRelease.py b/dev-tools/scripts/smokeTestRelease.py
index 03976f1de7d..06895c9ad7e 100755
--- a/dev-tools/scripts/smokeTestRelease.py
+++ b/dev-tools/scripts/smokeTestRelease.py
@@ -19,6 +19,7 @@ import argparse
import codecs
import datetime
import filecmp
+import glob
import hashlib
import http.client
import os
@@ -1028,29 +1029,14 @@ def confirmAllReleasesAreTestedForBackCompat(smokeVersion, unpackPath):
#for tup in allReleases:
# print(' %s' % '.'.join(str(x) for x in tup))
+ testedIndicesPaths = glob.glob('%s/lucene/backward-codecs/src/test/org/apache/lucene/backward_index/*-cfs.zip' % unpackPath)
testedIndices = set()
- os.chdir(unpackPath)
-
- print(' run TestBackwardsCompatibility..')
- command = './gradlew --no-daemon test -p lucene/backward-codecs --tests TestBackwardsCompatibility --max-workers=1 ' \
- '-Dtests.verbose=true '
- p = subprocess.Popen(command, shell=True, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
- stdout, stderr = p.communicate()
- if p.returncode != 0:
- # Not good: the test failed!
- raise RuntimeError('%s failed:\n%s' % (command, stdout))
- stdout = stdout.decode('utf-8',errors='replace').replace('\r\n','\n')
-
- if stderr is not None:
- # Should not happen since we redirected stderr to stdout:
- raise RuntimeError('stderr non-empty')
-
- reIndexName = re.compile(r'TEST: index[\s*=\s*](.*?)(-cfs|-nocfs)$', re.MULTILINE)
- for name, cfsPart in reIndexName.findall(stdout):
- # Fragile: decode the inconsistent naming schemes we've used in TestBWC's indices:
- #print('parse name %s' % name)
- tup = tuple(name.split('.'))
+ reIndexName = re.compile(r'^[^.]*.(.*?)-cfs.zip')
+ for name in testedIndicesPaths:
+ basename = os.path.basename(name)
+ version = reIndexName.fullmatch(basename).group(1)
+ tup = tuple(version.split('.'))
if len(tup) == 3:
# ok
tup = tuple(int(x) for x in tup)
@@ -1060,11 +1046,11 @@ def confirmAllReleasesAreTestedForBackCompat(smokeVersion, unpackPath):
elif tup == ('4', '0', '0', '2'):
# CONFUSING: this is the 4.0.0-beta index??
tup = 4, 0, 0, 1
- elif name == '5x-with-4x-segments':
+ elif basename == 'unsupported.5x-with-4x-segments-cfs.zip':
# Mixed version test case; ignore it for our purposes because we only
# tally up the "tests single Lucene version" indices
continue
- elif name == '5.0.0.singlesegment':
+ elif basename == 'unsupported.5.0.0.singlesegment-cfs.zip':
tup = 5, 0, 0
else:
raise RuntimeError('could not parse version %s' % name)