You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/07/26 22:24:31 UTC

[GitHub] [tvm] ya0guang opened a new pull request #8563: [Bugfux] wasm32-standalone app repaired

ya0guang opened a new pull request #8563:
URL: https://github.com/apache/tvm/pull/8563


   This commit fix the `wasm32-standalone` app and it works now!
   
   - Upgrade `wasmtime` APIs in this example to the latest version
   - Switch to a secure memory copying method to WASM sandbox
   - Upgrade build script APIs
   - Check target arch when building `tvm-sys`: since there is no `libtvm` built in `wasm32`, then it should not try to link `libtvm` when building `wasm32` target
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] leonwanghui commented on a change in pull request #8563: [Bugfux] wasm32-standalone app repaired

Posted by GitBox <gi...@apache.org>.
leonwanghui commented on a change in pull request #8563:
URL: https://github.com/apache/tvm/pull/8563#discussion_r678911511



##########
File path: apps/wasm-standalone/wasm-runtime/Cargo.toml
##########
@@ -26,8 +26,8 @@ license = "Apache-2.0"
 keywords = ["wasm", "machine learning", "wasmtime"]
 
 [dependencies]
-wasmtime = "0.16.0"
-wasmtime-wasi = "0.16.0"
+wasmtime = "0.28.0"

Review comment:
       Can u check it if this version of `wasmtime` supports loading wasm graph with `-mattr=+simd128` flag? Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen merged pull request #8563: [Bugfux] wasm32-standalone app repaired

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #8563:
URL: https://github.com/apache/tvm/pull/8563


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] ya0guang commented on a change in pull request #8563: [Bugfux] wasm32-standalone app repaired

Posted by GitBox <gi...@apache.org>.
ya0guang commented on a change in pull request #8563:
URL: https://github.com/apache/tvm/pull/8563#discussion_r679618506



##########
File path: apps/wasm-standalone/wasm-runtime/Cargo.toml
##########
@@ -26,8 +26,8 @@ license = "Apache-2.0"
 keywords = ["wasm", "machine learning", "wasmtime"]
 
 [dependencies]
-wasmtime = "0.16.0"
-wasmtime-wasi = "0.16.0"
+wasmtime = "0.28.0"

Review comment:
       > Can u check it if this version of `wasmtime` supports loading wasm graph with `-mattr=+simd128` flag? Thanks!
   
   Yes. I've already tested it. `wasmtime` 0.28 supports it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen commented on pull request #8563: [Bugfux] wasm32-standalone app repaired

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #8563:
URL: https://github.com/apache/tvm/pull/8563#issuecomment-887104142


   cc @leonwanghui @jroesch 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org