Looking for patches to apply

[Jukka Zitting <ju...@gmail.com>]

Hi,

Does anyone have patches against River trunk that they'd like to see applied?

I'd like to spend some time in the next few weeks to push things
forward here, but I'll need input from you. If you have an idea on how
River could be improved, please submit a patch in Jira or point me to
an existing issue with a patch waiting to be applied.

BR,

Jukka Zitting

Re: Looking for patches to apply

[Dennis Reedy <de...@gmail.com>]

>
>
> Personally, I'd rather see River move forward and get a release out  
> soon.

+1

Re: Looking for patches to apply

[Patrick Wright <pd...@gmail.com>]

>> Javadoc available online and in download
>> https://issues.apache.org/jira/browse/RIVER-268
>>
> Web-site-specific.  Has nothing to do with a release, IMO.

I believe the docs should normally be updated/rebuilt and uploaded to
the website, packaged for download, as part of the standard release
process. Doesn't need to be now, but that's SOP for many open source
projects. It just takes a bit of effort to set it all up, but it can
be automated without problem. But no, not a blocker.


Regards
Patrick

Re: Looking for patches to apply

[Greg Trasuk <tr...@stratuscom.com>]

On Sat, 2009-01-24 at 11:02, Patrick Wright wrote:
> Hi
> 
> Jini user here.
> 
> IMO, the only issue that seems like an easy fix (as part of the
> deploy) and would be beneficial would be:
> 
> Javadoc available online and in download
> https://issues.apache.org/jira/browse/RIVER-268
> 
Web-site-specific.  Has nothing to do with a release, IMO.

> The one major issue still open in that list
> (https://issues.apache.org/jira/browse/RIVER-265) doesn't appear to
> have any patches attached and at least at first glance, seems like a
> non-trivial fix. We are not affected by it, though, and not sure how
> others feel about it.
> 

The bug seems to be specific to the Cheiron Seven container.  As such,
although it's probably valid, I don't think it should be considered a
blocker for the next release.

Cheers,

Greg.

-- 
Greg Trasuk, President
StratusCom Manufacturing Systems Inc. - We use information technology to
solve business problems on your plant floor.
http://stratuscom.com

Re: Looking for patches to apply

[Patrick Wright <pd...@gmail.com>]

Hi

Jini user here.

IMO, the only issue that seems like an easy fix (as part of the
deploy) and would be beneficial would be:

Javadoc available online and in download
https://issues.apache.org/jira/browse/RIVER-268

The one major issue still open in that list
(https://issues.apache.org/jira/browse/RIVER-265) doesn't appear to
have any patches attached and at least at first glance, seems like a
non-trivial fix. We are not affected by it, though, and not sure how
others feel about it.

Personally, I'd rather see River move forward and get a release out soon.

BTW, Jukka, are you planning to release the distributables to the
central Maven repositories?

Regards
Patrick

Re: Looking for patches to apply

[Jukka Zitting <ju...@gmail.com>]

Hi,

On Sat, Jan 24, 2009 at 1:36 PM, Dennis Reedy <de...@gmail.com> wrote:
> I suggest that AR2 be released now.

Yes, we can do that.

Could someone review the open issues tagged for AR2 [1] to see if any
of them should really be fixed before the release?

[1] https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&&pid=12310600&fixfor=12312604&resolution=-1&sorter/field=priority&sorter/order=DESC

BR,

Jukka Zitting

Re: Looking for patches to apply

[Dennis Reedy <de...@gmail.com>]

>
>
>> Does your work on getting these patches applied imply that AR2  
>> might be
>> getting released soon?
>
> Kind of, yes. If doing AR2 would help activate the community, then I'd
> be willing to even cut the release myself.

I suggest that AR2 be released now. Why wait any longer?

Dennis

Re: Looking for patches to apply

[Jukka Zitting <ju...@gmail.com>]

Hi,

On Fri, Jan 23, 2009 at 11:46 AM, Tom Hobbs <to...@sucfin.com> wrote:
> I submitted a patch to fix RIVER-296.  I believe it works but haven't
> had any feedback on it yet.

OK, thanks. I'm no Jini/River expert, so I'm going to have to trust
the existing test cases and your (and anyone elses who reviews the
patch) judgement on the correctness of the patch. Since none of the
normal project committers seem to be active, I'll try to bootstrap a
normal patch-review-commit cycle using the commit access I have as a
project mentor.

BTW, as a general rule it would be really nice if a patch that fixes
an issue also contained a runnable test case that demonstrates the
issue and verifies that the fix does resolve it. Unfortunately I'm not
sure how easy (or even possible) this is with the current River
codebase.

> Does your work on getting these patches applied imply that AR2 might be
> getting released soon?

Kind of, yes. If doing AR2 would help activate the community, then I'd
be willing to even cut the release myself.

BR,

Jukka Zitting

RE: Looking for patches to apply

[Tom Hobbs <to...@sucfin.com>]

Hi Jukka,

I submitted a patch to fix RIVER-296.  I believe it works but haven't
had any feedback on it yet.

Does your work on getting these patches applied imply that AR2 might be
getting released soon?

Cheers,

Tom

-----Original Message-----
From: Jukka Zitting [mailto:jukka.zitting@gmail.com] 
Sent: 23 January 2009 09:43
To: river-dev@incubator.apache.org
Subject: Looking for patches to apply

Hi,

Does anyone have patches against River trunk that they'd like to see
applied?

I'd like to spend some time in the next few weeks to push things
forward here, but I'll need input from you. If you have an idea on how
River could be improved, please submit a patch in Jira or point me to
an existing issue with a patch waiting to be applied.

BR,

Jukka Zitting

www.sucden.co.uk
Sucden (UK) Limited, 5 London Bridge Street, London SE1 9SG
Telephone +44 20 7940 9400
 
Registered in England no. 1095841
VAT registration no. GB 446 9061 33
Authorised and Regulated by the Financial Services Authority (FSA) and entered in the FSA register under no. 114239

This email, including any files transmitted with it, is confidential and may be privileged. It may be read, copied and used only by the intended recipient. If you are not the intended recipient of this message, please notify postmaster@sucden.co.uk immediately and delete it from your computer system.

We believe, but do not warrant, that this email and its attachments are virus-free, but you should check. 

Sucden (UK) Ltd may monitor traffic data of both business and personal emails. By replying to this email, you consent to Sucden’s monitoring the content of any emails you send to or receive from Sucden. Sucden is not liable for any opinions expressed by the sender where this is a non-business email.
The contents of this e-mail do not constitute advice and should not be regarded as a recommendation to buy, sell or otherwise deal with any particular investment.
This message has been scanned for viruses by Mimecast.