You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Flavio Junqueira (JIRA)" <ji...@apache.org> on 2012/05/25 17:21:24 UTC
[jira] [Created] (BOOKKEEPER-270) Review documentation on bookie
cookie
Flavio Junqueira created BOOKKEEPER-270:
-------------------------------------------
Summary: Review documentation on bookie cookie
Key: BOOKKEEPER-270
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
Project: Bookkeeper
Issue Type: Sub-task
Reporter: Flavio Junqueira
Assignee: Ivan Kelly
Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283565#comment-13283565 ]
Flavio Junqueira commented on BOOKKEEPER-270:
---------------------------------------------
Isn't the cookie related to management of bookies as well? If so, it should go to the admin guide page, no?
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Ivan Kelly
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283562#comment-13283562 ]
Ivan Kelly commented on BOOKKEEPER-270:
---------------------------------------
This is internal to the bookie implementation. It shouldn't be in the user doc. We can doc in the wiki when we do the stuff for adding/removing disks in 4.2
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Ivan Kelly
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sijie Guo updated BOOKKEEPER-270:
---------------------------------
Fix Version/s: 4.1.0
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284928#comment-13284928 ]
Flavio Junqueira commented on BOOKKEEPER-270:
---------------------------------------------
bq. I agreed Flavio that we should let admin guys be aware of why the bookie can't start and how they should do when encountering such cases. I would suggest moving the detail cookie format to bookkeeper internal documents, and add some trouble shooting guideline in administrator guide so admin guys know how to handle when encountering similar cases.
There are multiple reasons that could lead to a bookie to not start. Wiping out a directory by either replacing a disk or accidentally deleting it are two reasons. In such cases, I'm not entirely sure of what the troubleshooting procedure is right now. Is it to wipe out the whole bookie state and reconstruct its state from scratch by using the bookie recovery tool? If this is something that we will better handle in 4.2.0, we may want to point out that the current version does not provide a feature that handles nicely such situations and it will come in a future version.
In any case, it sounds like a good idea to me to have a section in the admin's guide called "Troubleshooting".
bq. do we have any guidelines that when to run bookie recover tool?
In the docs folder, we have bookieRecovery.textile. It seems to be missing the case in which we have the target bookie as part of the input.
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-270.patch, BOOKKEEPER-270.patch
>
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284848#comment-13284848 ]
Ivan Kelly commented on BOOKKEEPER-270:
---------------------------------------
I'd prefer not to talk about the cookies or their format, and just simply say that if you change the disk configuration of a bookie, it will not be able to start. Detailing the contents creates overhead for making modifications in the future, and we will certainly be making modifications in this area in 4.2.0.
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-270.patch, BOOKKEEPER-270.patch
>
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284952#comment-13284952 ]
Flavio Junqueira commented on BOOKKEEPER-270:
---------------------------------------------
+1, fair enough the point about troubleshooting. There is still a typo in the Bookie Recovery page, not introduced by you. The one committing it, please fix it.
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-270.diff, BOOKKEEPER-270.diff, BOOKKEEPER-270.patch, BOOKKEEPER-270.patch
>
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-270:
----------------------------------
Attachment: BOOKKEEPER-270.diff
Spelling fixed.
Regarding having a troubleshooting section, I think it would be better to wait until we have seen issues in the wild, and add them to the troubleshooting section as needed. I think trying to preemptively add troubleshooting without experience wouldn't be very useful.
In fact, I think for 4.2.0 we should go through the mailing list and create a FAQ.
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-270.diff, BOOKKEEPER-270.diff, BOOKKEEPER-270.patch, BOOKKEEPER-270.patch
>
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284680#comment-13284680 ]
Ivan Kelly commented on BOOKKEEPER-270:
---------------------------------------
It's an internal mechanism. The administrator should never touch cookies directly. Given that this is the case, if they want to mess with internals they should read the code directly.
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Junqueira updated BOOKKEEPER-270:
----------------------------------------
Attachment: BOOKKEEPER-270.patch
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-270.patch
>
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284882#comment-13284882 ]
Sijie Guo commented on BOOKKEEPER-270:
--------------------------------------
I agreed Flavio that we should let admin guys be aware of why the bookie can't start and how they should do when encountering such cases. I would suggest moving the detail cookie format to bookkeeper internal documents, and add some trouble shooting guideline in administrator guide so admin guys know how to handle when encountering similar cases.
Besides that, do we have any guidelines that when to run bookie recover tool?
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-270.patch, BOOKKEEPER-270.patch
>
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Junqueira reassigned BOOKKEEPER-270:
-------------------------------------------
Assignee: Flavio Junqueira (was: Ivan Kelly)
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 4.1.0
>
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284864#comment-13284864 ]
Flavio Junqueira commented on BOOKKEEPER-270:
---------------------------------------------
I understand that it would be best to treat bookies as black boxes. However, I couldn't think of a good way of saying precisely the cases we cover (and I don't claim my description is currently precise enough) without giving some detail about the implementation. I'm fine with hiding internal detail, but I'm not ok with not being precise about the cases we cover. If you can think of a better way, I'll be happy to hear.
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-270.patch, BOOKKEEPER-270.patch
>
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284946#comment-13284946 ]
Flavio Junqueira commented on BOOKKEEPER-270:
---------------------------------------------
This is excellent, Ivan. I just have a couple of comments:
# My spell checker is complaining about a couple of things, so it would be good to fix those. I can do them upon commit if necessary, but if you end up updating the patch because of the second comment, please check the spelling;
# I liked the idea of having a section called troubleshooting and it sounds like this discussion fits perfectly such a section. How do you feel about having such a section and moving this discussion there?
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-270.diff, BOOKKEEPER-270.patch, BOOKKEEPER-270.patch
>
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285135#comment-13285135 ]
Hudson commented on BOOKKEEPER-270:
-----------------------------------
Integrated in bookkeeper-trunk #533 (See [https://builds.apache.org/job/bookkeeper-trunk/533/])
BOOKKEEPER-270: Review documentation on bookie cookie (ivank via fpj) (Revision 1343981)
Result = SUCCESS
fpj :
Files :
* /zookeeper/bookkeeper/trunk/doc/bookieRecovery.textile
* /zookeeper/bookkeeper/trunk/doc/bookkeeperConfig.textile
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-270.diff, BOOKKEEPER-270.diff, BOOKKEEPER-270.patch, BOOKKEEPER-270.patch
>
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Flavio Junqueira (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Flavio Junqueira updated BOOKKEEPER-270:
----------------------------------------
Attachment: BOOKKEEPER-270.patch
Cut at documentation for cookies.
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-270.patch, BOOKKEEPER-270.patch
>
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285162#comment-13285162 ]
Hudson commented on BOOKKEEPER-270:
-----------------------------------
Integrated in bookkeeper-trunk #534 (See [https://builds.apache.org/job/bookkeeper-trunk/534/])
BOOKKEEPER-270: Review documentation on bookie cookie (ivank via fpj) (Revision 1343986)
Result = ABORTED
fpj :
Files :
* /zookeeper/bookkeeper/trunk/CHANGES.txt
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Ivan Kelly
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-270.diff, BOOKKEEPER-270.diff, BOOKKEEPER-270.patch, BOOKKEEPER-270.patch
>
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-270) Review documentation on bookie
cookie
Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/BOOKKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ivan Kelly updated BOOKKEEPER-270:
----------------------------------
Attachment: BOOKKEEPER-270.diff
I've taken a run at this to document the failure procedure while keeping the internal implementation details out of view. See the attached patch.
> Review documentation on bookie cookie
> -------------------------------------
>
> Key: BOOKKEEPER-270
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-270
> Project: Bookkeeper
> Issue Type: Sub-task
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-270.diff, BOOKKEEPER-270.patch, BOOKKEEPER-270.patch
>
>
> Check BOOKKEEPER-163.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira