You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2014/11/15 19:20:45 UTC
[GitHub] incubator-brooklyn pull request: Fix catalog item ordering for det...
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/335
Fix catalog item ordering for determining the latest stable.
Prefer 2.3.0 over 2.3.0-build, 2.3.0-rc10 over 2.3.0-rc1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn fix/catalog-item-comparator
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/335.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #335
----
commit 9a36702adedd30afb9b0b0e944fcf0f5e37032f5
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2014-11-15T18:18:17Z
Fix catalog item ordering for determining the latest stable.
Prefer 2.3.0 over 2.3.0-build, 2.3.0-rc10 over 2.3.0-rc1
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix catalog item ordering for det...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/335
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix catalog item ordering for det...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/335#discussion_r20404058
--- Diff: utils/common/src/test/java/brooklyn/util/text/NaturalOrderComparatorTest.java ---
@@ -56,4 +64,18 @@ public void testBasicOnes() {
@Test(expectedExceptions={IllegalArgumentException.class})
public void testError3() { v.isInRange("[10.5]"); }
-}
+ @Test(groups="WIP", enabled=false)
+ public void testUnderscoreDoesNotChangeMeaningOfNumberInNoc() {
+ // why??
+ Assert.assertTrue(noc.compare("0.0.0_SNAPSHOT", "0.0.1-SNAPSHOT-20141111114709760") < 0);
+
+ Assert.assertTrue(v.isGreaterThanAndNotEqualTo(v_rc2.version));
+ Assert.assertTrue(v_rc2.isLessThanAndNotEqualTo(v.version));
+ }
+
+ @Test(groups="WIP", enabled=false)
--- End diff --
this shouldn't be WIP
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix catalog item ordering for det...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/335#issuecomment-63183440
WIP tests are currently failing for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix catalog item ordering for det...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/335#issuecomment-63182995
looks good - tiny test comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix catalog item ordering for det...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/335#discussion_r20404062
--- Diff: utils/common/src/test/java/brooklyn/util/text/NaturalOrderComparatorTest.java ---
@@ -56,4 +64,18 @@ public void testBasicOnes() {
@Test(expectedExceptions={IllegalArgumentException.class})
public void testError3() { v.isInRange("[10.5]"); }
-}
+ @Test(groups="WIP", enabled=false)
+ public void testUnderscoreDoesNotChangeMeaningOfNumberInNoc() {
+ // why??
+ Assert.assertTrue(noc.compare("0.0.0_SNAPSHOT", "0.0.1-SNAPSHOT-20141111114709760") < 0);
+
+ Assert.assertTrue(v.isGreaterThanAndNotEqualTo(v_rc2.version));
+ Assert.assertTrue(v_rc2.isLessThanAndNotEqualTo(v.version));
--- End diff --
these two shouldn't need to be WIP do they?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---