You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/28 15:08:44 UTC
[GitHub] [tvm] bkmgit opened a new pull request, #13499: [Docs][Bug] Fix broken link to tvmc python
bkmgit opened a new pull request, #13499:
URL: https://github.com/apache/tvm/pull/13499
Ensure correct link is generated to the next page in the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] bkmgit commented on pull request #13499: [Docs][Bug] Fix broken link to tvmc python
Posted by GitBox <gi...@apache.org>.
bkmgit commented on PR #13499:
URL: https://github.com/apache/tvm/pull/13499#issuecomment-1329378660
@gromero Thanks for your feedback. That is not the next tutorial in the sequence obtained at the [bottom of the page](https://tvm.apache.org/docs/tutorial/tvmc_command_line_driver.html) . The link you have suggested could be used but then it would be helpful to rephrase
```
In the next tutorial, [Compiling and Optimizing a Model with the Python Interface](https://tvm.apache.org/docs/tutorial/auto_tuning_with_pyton), we will cover the same compilation and optimization steps using the Python interface.
```
to
```
In the [next tutorial](https://tvm.apache.org/docs/tutorial/tvmc_python.html), we introduce the Python interface to TVM, and in the tutorial after that, [Compiling and Optimizing a Model with the Python Interface](https://tvm.apache.org/docs/tutorial/autotvm_relay_x86), we will cover the same compilation and optimization steps using the Python interface.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero merged pull request #13499: [Docs][Bug] Fix broken link to tvmc python
Posted by GitBox <gi...@apache.org>.
gromero merged PR #13499:
URL: https://github.com/apache/tvm/pull/13499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13499: [Docs][Bug] Fix broken link to tvmc python
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13499:
URL: https://github.com/apache/tvm/pull/13499#issuecomment-1329266292
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* No users to tag found in teams: `docs`, `bug` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #13499: [Docs][Bug] Fix broken link to tvmc python
Posted by GitBox <gi...@apache.org>.
gromero commented on PR #13499:
URL: https://github.com/apache/tvm/pull/13499#issuecomment-1329326558
@leandron Shouldn't that be pointing to https://github.com/apache/tvm/blob/main/gallery/tutorial/autotvm_relay_x86.py#L18 instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #13499: [Docs][Bug] Fix broken link to tvmc python
Posted by GitBox <gi...@apache.org>.
gromero commented on PR #13499:
URL: https://github.com/apache/tvm/pull/13499#issuecomment-1329508404
> @gromero Thanks for your feedback. That is not the next tutorial in the sequence obtained at the [bottom of the page](https://tvm.apache.org/docs/tutorial/tvmc_command_line_driver.html) . The link you have suggested could be used but then it would be helpful to rephrase
@bkmgit Got it!
> In the [next tutorial](https://tvm.apache.org/docs/tutorial/tvmc_python.html), we introduce the Python interface to TVM, and in the tutorial after that, [Compiling and Optimizing a Model with the Python Interface](https://tvm.apache.org/docs/tutorial/autotvm_relay_x86), we will cover the same compilation and optimization steps using the Python interface.
yeah I'm ok with that version.
Another option would be to just adjusting the text in your change, i.e. in `tvmc_command_line_driver.py`, to match the new link, so (remove the wrong tutorial title text):
"In the next tutorial, [Getting Starting using TVMC Python: a high-level API for TVM](https://tvm.apache.org/docs/tutorial/tvmc_python.html), we introduce the Python interface to TVM."
and move the second part to the bottom of tutorial [tvmc_python.py](https://tvm.apache.org/docs/tutorial/tvmc_python.html).
"In the next tutorial, [Compiling and Optimizing a Model with the Python Interface](https://tvm.apache.org/docs/tutorial/autotvm_relay_x86), we will cover the same compilation and optimization steps using the Python interface."
But either way works for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] bkmgit commented on pull request #13499: [Docs][Bug] Fix broken link to tvmc python
Posted by GitBox <gi...@apache.org>.
bkmgit commented on PR #13499:
URL: https://github.com/apache/tvm/pull/13499#issuecomment-1330544029
@gromero Thanks for the feedback. Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #13499: [Docs][Bug] Fix broken link to tvmc python
Posted by GitBox <gi...@apache.org>.
gromero commented on PR #13499:
URL: https://github.com/apache/tvm/pull/13499#issuecomment-1330618555
@leandron Since there are changes since you're last review, would you like to take another look? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org