[GitHub] [pulsar] nodece commented on a diff in pull request #19464: [fix][authentication] Improve AuthenticationFilter response

["nodece (via GitHub)" <gi...@apache.org>]

nodece commented on code in PR #19464:
URL: https://github.com/apache/pulsar/pull/19464#discussion_r1232986557


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/web/AuthenticationFilter.java:
##########
@@ -52,19 +52,29 @@ public AuthenticationFilter(AuthenticationService authenticationService) {
     @Override
     public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain)
             throws IOException, ServletException {
+        boolean allowed = false;
+        Exception authenticationException = null;
         try {
-            boolean doFilter = authenticationService
+            allowed = authenticationService

Review Comment:
   Got.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org