You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Torin Danil (JIRA)" <ji...@apache.org> on 2009/03/02 14:57:56 UTC
[jira] Created: (LUCENE-1551) Add reopen(IndexCommit) methods to
IndexReader
Add reopen(IndexCommit) methods to IndexReader
----------------------------------------------
Key: LUCENE-1551
URL: https://issues.apache.org/jira/browse/LUCENE-1551
Project: Lucene - Java
Issue Type: Improvement
Components: Index
Affects Versions: 2.9
Environment: Any
Reporter: Torin Danil
Priority: Minor
Add reopen(IndexCommit) methods to IndexReader to be able to reopen an index on any previously saved commit points with all advantages of LUCENE-1483.
Similar to open(IndexCommit) & company available in 2.4.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1551) Add reopen(IndexCommit) methods to
IndexReader
Posted by "Torin Danil (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679115#action_12679115 ]
Torin Danil commented on LUCENE-1551:
-------------------------------------
Since we moved delete to IndexWriter, I strongly feel that IndexReader SHOULD be always read-only,
so your patch makes perfect sense to me.
I know that there are still some operations that IndexWriter can't do, and real-time search needs them,
so that's why LUCENE-1516 was created, right? But those guys don't need to open previous commit point,
they need latest & greatest, so the patch should work for them too.
But in the end (lucene4, or maybe sooner?), could it be possible to move all modifying methods
to IndexWriter and let IndexReader to be what it says it is: a READER?
Beside this totally random talk, the patch looks good, I'll try to test it in a day or two and let you know if there are any problems.
> Add reopen(IndexCommit) methods to IndexReader
> ----------------------------------------------
>
> Key: LUCENE-1551
> URL: https://issues.apache.org/jira/browse/LUCENE-1551
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.9
> Environment: Any
> Reporter: Torin Danil
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1551.patch
>
>
> Add reopen(IndexCommit) methods to IndexReader to be able to reopen an index on any previously saved commit points with all advantages of LUCENE-1483.
> Similar to open(IndexCommit) & company available in 2.4.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1551) Add reopen(IndexCommit) methods to
IndexReader
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1551.
----------------------------------------
Resolution: Fixed
OK, thanks Torin. I just committed this!
> Add reopen(IndexCommit) methods to IndexReader
> ----------------------------------------------
>
> Key: LUCENE-1551
> URL: https://issues.apache.org/jira/browse/LUCENE-1551
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.9
> Environment: Any
> Reporter: Torin Danil
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1551.patch
>
>
> Add reopen(IndexCommit) methods to IndexReader to be able to reopen an index on any previously saved commit points with all advantages of LUCENE-1483.
> Similar to open(IndexCommit) & company available in 2.4.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1551) Add reopen(IndexCommit) methods to
IndexReader
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reassigned LUCENE-1551:
------------------------------------------
Assignee: Michael McCandless
> Add reopen(IndexCommit) methods to IndexReader
> ----------------------------------------------
>
> Key: LUCENE-1551
> URL: https://issues.apache.org/jira/browse/LUCENE-1551
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.9
> Environment: Any
> Reporter: Torin Danil
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
>
> Add reopen(IndexCommit) methods to IndexReader to be able to reopen an index on any previously saved commit points with all advantages of LUCENE-1483.
> Similar to open(IndexCommit) & company available in 2.4.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1551) Add reopen(IndexCommit) methods to
IndexReader
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1551:
---------------------------------------
Fix Version/s: 2.9
> Add reopen(IndexCommit) methods to IndexReader
> ----------------------------------------------
>
> Key: LUCENE-1551
> URL: https://issues.apache.org/jira/browse/LUCENE-1551
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.9
> Environment: Any
> Reporter: Torin Danil
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
>
> Add reopen(IndexCommit) methods to IndexReader to be able to reopen an index on any previously saved commit points with all advantages of LUCENE-1483.
> Similar to open(IndexCommit) & company available in 2.4.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1551) Add reopen(IndexCommit) methods to
IndexReader
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678943#action_12678943 ]
Michael McCandless commented on LUCENE-1551:
--------------------------------------------
I think reopen(IndexCommit) should always give you a readOnly reader?
> Add reopen(IndexCommit) methods to IndexReader
> ----------------------------------------------
>
> Key: LUCENE-1551
> URL: https://issues.apache.org/jira/browse/LUCENE-1551
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.9
> Environment: Any
> Reporter: Torin Danil
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
>
> Add reopen(IndexCommit) methods to IndexReader to be able to reopen an index on any previously saved commit points with all advantages of LUCENE-1483.
> Similar to open(IndexCommit) & company available in 2.4.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1551) Add reopen(IndexCommit) methods to
IndexReader
Posted by "Torin Danil (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680780#action_12680780 ]
Torin Danil commented on LUCENE-1551:
-------------------------------------
Yeah, sorry for delay.
It worked just fine. If there are no objections, I'd say go ahead and commit.
> Add reopen(IndexCommit) methods to IndexReader
> ----------------------------------------------
>
> Key: LUCENE-1551
> URL: https://issues.apache.org/jira/browse/LUCENE-1551
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.9
> Environment: Any
> Reporter: Torin Danil
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1551.patch
>
>
> Add reopen(IndexCommit) methods to IndexReader to be able to reopen an index on any previously saved commit points with all advantages of LUCENE-1483.
> Similar to open(IndexCommit) & company available in 2.4.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1551) Add reopen(IndexCommit) methods to
IndexReader
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680686#action_12680686 ]
Michael McCandless commented on LUCENE-1551:
--------------------------------------------
Torin have you had a chance to test this?
> Add reopen(IndexCommit) methods to IndexReader
> ----------------------------------------------
>
> Key: LUCENE-1551
> URL: https://issues.apache.org/jira/browse/LUCENE-1551
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.9
> Environment: Any
> Reporter: Torin Danil
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1551.patch
>
>
> Add reopen(IndexCommit) methods to IndexReader to be able to reopen an index on any previously saved commit points with all advantages of LUCENE-1483.
> Similar to open(IndexCommit) & company available in 2.4.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1551) Add reopen(IndexCommit) methods to
IndexReader
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679164#action_12679164 ]
Michael McCandless commented on LUCENE-1551:
--------------------------------------------
{quote}
Since we moved delete to IndexWriter, I strongly feel that IndexReader SHOULD be always read-only,
so your patch makes perfect sense to me.
{quote}
I agree...
In 3.0, we are switching IndexReader.open to return a readOnly reader
by default (it's now read/write).
{quote}
I know that there are still some operations that IndexWriter can't do, and real-time search needs them,
so that's why LUCENE-1516 was created, right? But those guys don't need to open previous commit point,
they need latest & greatest, so the patch should work for them too.
{quote}
Right, once realtime search is released, proves stable, etc.,
IndexReader should no longer need any write operations (I think?).
{quote}
But in the end (lucene4, or maybe sooner?), could it be possible to move all modifying methods
to IndexWriter and let IndexReader to be what it says it is: a READER?
{quote}
I think LUCENE-1516 won't land until after 3.0 (though, it's making
fast progress now, so it could be we get initial version into 2.9).
Then sometime in 3.x, we deprecate all write methods in IndexReader
and add anything missing (setNorm, undeleteAll) into IndexWriter.
Then in 4.x we would remove IndexReader's deprecated methods.
bq. Beside this totally random talk, the patch looks good, I'll try to test it in a day or two and let you know if there are any problems.
Excellent, thanks -- I'll hold off on committing until we hear back
how your tests go!
> Add reopen(IndexCommit) methods to IndexReader
> ----------------------------------------------
>
> Key: LUCENE-1551
> URL: https://issues.apache.org/jira/browse/LUCENE-1551
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.9
> Environment: Any
> Reporter: Torin Danil
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1551.patch
>
>
> Add reopen(IndexCommit) methods to IndexReader to be able to reopen an index on any previously saved commit points with all advantages of LUCENE-1483.
> Similar to open(IndexCommit) & company available in 2.4.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1551) Add reopen(IndexCommit) methods to
IndexReader
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1551:
---------------------------------------
Attachment: LUCENE-1551.patch
Attached patch. I plan to commit in a few days.
> Add reopen(IndexCommit) methods to IndexReader
> ----------------------------------------------
>
> Key: LUCENE-1551
> URL: https://issues.apache.org/jira/browse/LUCENE-1551
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Affects Versions: 2.9
> Environment: Any
> Reporter: Torin Danil
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1551.patch
>
>
> Add reopen(IndexCommit) methods to IndexReader to be able to reopen an index on any previously saved commit points with all advantages of LUCENE-1483.
> Similar to open(IndexCommit) & company available in 2.4.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org