You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/18 08:53:13 UTC

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #26934: [SPARK-30293][SQL] Remove closeTimestamp!=0 statement since we add a close status

AngersZhuuuu commented on a change in pull request #26934: [SPARK-30293][SQL] Remove closeTimestamp!=0 statement since we add a close status
URL: https://github.com/apache/spark/pull/26934#discussion_r359220660
 
 

 ##########
 File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/HiveThriftServer2Listener.scala
 ##########
 @@ -231,7 +231,7 @@ private[thriftserver] class HiveThriftServer2Listener(
     }
     val view = kvstore.view(classOf[ExecutionInfo]).index("finishTime").first(0L)
 
 Review comment:
   > `finishTime` -> `closeTime`?
   
   Should add a index `closeTime`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org