You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "FlyingZC (via GitHub)" <gi...@apache.org> on 2023/07/13 08:14:41 UTC

[GitHub] [shardingsphere] FlyingZC opened a new issue, #27150: Support parsing Oracle INSERT /*+ sql

FlyingZC opened a new issue, #27150:
URL: https://github.com/apache/shardingsphere/issues/27150

   # Background
   Hi community,
   This issue is for #26878.
   
   ShardingSphere parser engine helps users parse a SQL to get the AST (Abstract Syntax Tree) and visit this tree to get SQLStatement (Java Object). Currently, we are planning to enhance the support for Oracle SQL parsing in ShardingSphere.
   
   More details:
   https://shardingsphere.apache.org/document/current/en/reference/sharding/parse/
   
   # Task
   This issue is to support more oracle sql parse, as follows:
   ```sql
   INSERT /*+ APPEND NOLOGGING PARALLEL */ INTO sales_overall
   2 SELECT * FROM sales_activity_direct
   3 LOG ERRORS INTO err$_sales_overall ('load_test2')
   4 REJECT LIMIT 10;
   ```
   
   ```sql
   INSERT INTO Out SELECT * FROM ("Table Function"(SELECT * FROM In));
   ```
   
   ```sql
   INSERT INTO T2 (SELECT dbms_rowid.rowid_block_number(ROWID, 'BIGFILE')
      FROM some_table 
      WHERE key_value = 42);
   ```
   
   ```sql
   INSERT INTO TableName 
     PARTITION (
       PartitionName|
       DATAOBJ_TO_PARTITION(base_table, :physical_partid))
     AS SubQuery
   ```
   
   ```sql
   INSERT INTO DEPARTMENTS (
   *
   ERROR at line 1:
   ORA-01400: cannot insert NULL into ("HR"."DEPARTMENTS"."DEPARTMENT_ID")
   ```
   
   # Process
   1. First confirm that this is a correct oracle sql syntax, if not please ignore;
   2. Compare SQL definitions in Oficial SQL Doc and ShardingSphere SQL Doc;
   3. If there is any difference in ShardingSphere SQL Doc, please correct them by referring to the Official SQL Doc;
   4. Run mvn install the current_file_module;
   5. Check whether there are any exceptions. If indeed, please fix them. (Especially xxxVisitor.class);
   6. Add new corresponding SQL case in SQL Cases and expected parsed result in Expected Statment XML;
   7. Run SQLParserParameterizedTest to make sure no exceptions.
   
   # Relevant Skills
   1. Master JAVA language
   2. Have a basic understanding of Antlr `g4` file
   3. Be familiar with Oracle SQLs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] FlyingZC commented on issue #27150: Support parsing Oracle INSERT /*+ sql

Posted by "FlyingZC (via GitHub)" <gi...@apache.org>.
FlyingZC commented on issue #27150:
URL: https://github.com/apache/shardingsphere/issues/27150#issuecomment-1673033114

   The first sql syntax is correctly.
   ```sql
   INSERT /*+ APPEND NOLOGGING PARALLEL */ INTO sales_overall
    SELECT * FROM sales_activity_direct
    LOG ERRORS INTO err$_sales_overall ('load_test2')
    REJECT LIMIT 10;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] FlyingZC closed issue #27150: Support parsing Oracle INSERT /*+ sql

Posted by "FlyingZC (via GitHub)" <gi...@apache.org>.
FlyingZC closed issue #27150: Support parsing Oracle INSERT /*+ sql
URL: https://github.com/apache/shardingsphere/issues/27150


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] FlyingZC commented on issue #27150: Support parsing Oracle INSERT /*+ sql

Posted by "FlyingZC (via GitHub)" <gi...@apache.org>.
FlyingZC commented on issue #27150:
URL: https://github.com/apache/shardingsphere/issues/27150#issuecomment-1673038258

   Close, the third sql is now supported, the other sqls syntax itself has problems.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org