You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/08/31 21:29:52 UTC
[GitHub] [incubator-pinot] npawar opened a new pull request #5953: Make realtime threshold property names less ambiguous
npawar opened a new pull request #5953:
URL: https://github.com/apache/incubator-pinot/pull/5953
## Description
The realtime threshold property names are confusing to users.
The property for "rows" reads as "realtime.segment.flush.threshold.size" and makes users put the segment size in there.
The property for segment size reads as "realtime.segment.flush.desired.size" and doesn't convey that it is a threshold and is expecting a segment size.
Introducing "realtime.segment.flush.threshold.rows" for rows threshold and "realtime.segment.flush.threshold.segment.size" for segment size threshold. The time property is fine "realtime.segment.flush.threshold.time".
The old properties are still present, for backward compatibility.
## Release Notes
New configurations introduced in stream configs "realtime.segment.flush.threshold.rows" and "realtime.segment.flush.threshold.segment.size".
Deprecated "realtime.segment.flush.threshold.size" and "realtime.segment.flush.desired.size"
## Documentation
Will add before merging, if this change approved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #5953: Make realtime threshold property names less ambiguous
Posted by GitBox <gi...@apache.org>.
npawar commented on pull request #5953:
URL: https://github.com/apache/incubator-pinot/pull/5953#issuecomment-684974188
> please annotate the PR for release notes that these properties are deprecated.
> Update doc accordingly
already labeled release-notes and added release notes section
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] npawar merged pull request #5953: Make realtime threshold property names less ambiguous
Posted by GitBox <gi...@apache.org>.
npawar merged pull request #5953:
URL: https://github.com/apache/incubator-pinot/pull/5953
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org