You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Milamber <mi...@apache.org> on 2019/10/18 10:50:40 UTC

[VOTE] Release JMeter 5.2 RC4

The fourth release candidate for JMeter 5.2 (26ef2cef53) has been
prepared, and your votes are solicited.

* This release brings two major changes for the distributed 
version-control system and the building tool:
    - migration from Subversion (svn) to Git repository (compliant with 
GitHub and ASF GitBox)
    - migration from Apache Ant to Gradle build system

This for 2 main objectives:
    * Improve the ease for contributors to make improvements and 
corrections of bugs
    * Allow to have new and more frequent versions of JMeter by 
automating release steps.

Special Thanks for Vladimir Sitnikov (vladimirsitnikov@a.o) for these 
works and supports.

Please, test this release candidate (with load tests and/or functional
tests) using Java 8+ on Linux/Windows/macOS, especially on the changes.
Feedback is very welcome within the next 72 hours.

@PMC and Commiters ==> This is the first release with the new 
process/tool with Gradle and Git repository, so please double check this 
release to find all issue in theses changes in the building and 
releasing mechanisms for JMeter. <==

You can read the New and Noteworthy section with some screenshots to
illustrate improvements and full list of changes at:
https://apache.github.io/jmeter-site-preview/site/changes.html

JMeter is a Java desktop application designed to load test functional
behavior and measure performance. The current version targets Java 8+

Download - Archives/hashes/sigs:
https://dist.apache.org/repos/dist/dev/jmeter/apache-jmeter-5.2-rc4/
(dist revision 36377)

RAT report:
https://apache.github.io/jmeter-site-preview/rat/

SHA512 hashes of archives for this vote: see footnote [1]

Site preview is here:
https://apache.github.io/jmeter-site-preview/site/

JavaDoc API preview is here:
https://apache.github.io/jmeter-site-preview/site/api/

Maven staging repository is accessible here:
https://repository.apache.org/content/repositories/orgapachejmeter-1056/org/apache/jmeter/

Tag:
https://gitbox.apache.org/repos/asf?p=jmeter.git;a=tag;h=refs/tags/v5.2-rc4

Keys are here:
https://www.apache.org/dist/jmeter/KEYS

N.B.
To create the distribution and test JMeter: "./gradlew build -Prelease 
-PskipSigning".

JMeter 5.2 requires Java 8 or later to run.

The artifacts were built with
   Java(TM) SE Runtime Environment Oracle Corporation (build 1.8.0_221-b11)
   Java HotSpot(TM) 64-Bit Server VM Oracle Corporation (build 
25.221-b11, mixed mode)

Some known issues and incompatible changes are listed on changes page.
https://apache.github.io/jmeter-site-preview/site/changes.html#Known%20problems%20and%20workarounds


All feedback and vote are welcome.

[  ] +1  I support this release
[  ] +0  I am OK with this release
[  ] -0  OK, but....
[  ] -1  I do not support this release (please indicate why)

The vote will remain open for at least 72 hours.

The PMC members please indicate the mention "(binding)" with your vote.


Note: If the vote passes, the intention is to release the archive files
and rename the RC tag as the release tag.

Thanks in advance!

Milamber

===
[1] SHA512 hashes of archives for this vote:

fa68f14e56ac45787befba3a328862715d7b50693fca5e202f7d83b6b3119a5700493837d94c42759ea9ecfc3245b08a289bc5295a68f81157b7c5ef432a62f2
*apache-jmeter-5.2.tgz
e762fb36b086e94050c66b90ff55ee6a54eb86c0df8b5f109b5ac1c50be461507596badfa95db3ae037a3265f58bad857a2619a801d527d969ce66015f6f6327
*apache-jmeter-5.2.zip
b6d6e73ecfd5407dd1ffa2df8931459163335d495ddec7559e6d396985ae3d520950fb20bd562678eaf0b00530a5e33f829c5476760196b3b0ef29a584a2a74f
*apache-jmeter-5.2_src.tgz
8b47d6c30636941c8f5567c914c23a0e03166f85d91830af2f5949ef5301be5b6429f6dd7445a3ca45e048c3251c8d3c69255afc9ea7c67d879142573a15d47a
*apache-jmeter-5.2_src.zip

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Vladimir Sitnikov <si...@gmail.com>.
Great.

+1 (binding), I support this release.

Source artifacts: verified checksums, PGP, build, tests, runGui.
Source artifacts are reproducible (that is :src:dist:build produces the
same source artifacts like the ones presented for the vote)

Binary artifacts: verified checksums, PGP, ./jmeter

---
Commands:

svn checkout
https://dist.apache.org/repos/dist/dev/jmeter/apache-jmeter-5.2-rc4
cd apache-jmeter-5.2-rc4
for i in *.asc; do gpg --verify $i; done;
for i in *.zip *.tgz; do shasum -a512 $i; done;

tar xzf apache-jmeter-5.2_src.tgz # or unzip apache-jmeter-5.2_src.zip
cd apache-jmeter-5.2

./gradlew build -Prelease -PskipSigning

Vladimir

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Philippe Mouawad <ph...@gmail.com>.
Hello,
Thanks to RM.

I tested following features on my side:
- Recording
- Testing in GUI and CLI
- Report generation
- Function call

No issue found on my side.
[X] +1  I support this release

Regards
Philippe M.

On Fri, Oct 18, 2019 at 12:50 PM Milamber <mi...@apache.org> wrote:

> The fourth release candidate for JMeter 5.2 (26ef2cef53) has been
> prepared, and your votes are solicited.
>
> * This release brings two major changes for the distributed
> version-control system and the building tool:
>     - migration from Subversion (svn) to Git repository (compliant with
> GitHub and ASF GitBox)
>     - migration from Apache Ant to Gradle build system
>
> This for 2 main objectives:
>     * Improve the ease for contributors to make improvements and
> corrections of bugs
>     * Allow to have new and more frequent versions of JMeter by
> automating release steps.
>
> Special Thanks for Vladimir Sitnikov (vladimirsitnikov@a.o) for these
> works and supports.
>
> Please, test this release candidate (with load tests and/or functional
> tests) using Java 8+ on Linux/Windows/macOS, especially on the changes.
> Feedback is very welcome within the next 72 hours.
>
> @PMC and Commiters ==> This is the first release with the new
> process/tool with Gradle and Git repository, so please double check this
> release to find all issue in theses changes in the building and
> releasing mechanisms for JMeter. <==
>
> You can read the New and Noteworthy section with some screenshots to
> illustrate improvements and full list of changes at:
> https://apache.github.io/jmeter-site-preview/site/changes.html
>
> JMeter is a Java desktop application designed to load test functional
> behavior and measure performance. The current version targets Java 8+
>
> Download - Archives/hashes/sigs:
> https://dist.apache.org/repos/dist/dev/jmeter/apache-jmeter-5.2-rc4/
> (dist revision 36377)
>
> RAT report:
> https://apache.github.io/jmeter-site-preview/rat/
>
> SHA512 hashes of archives for this vote: see footnote [1]
>
> Site preview is here:
> https://apache.github.io/jmeter-site-preview/site/
>
> JavaDoc API preview is here:
> https://apache.github.io/jmeter-site-preview/site/api/
>
> Maven staging repository is accessible here:
>
> https://repository.apache.org/content/repositories/orgapachejmeter-1056/org/apache/jmeter/
>
> Tag:
> https://gitbox.apache.org/repos/asf?p=jmeter.git;a=tag;h=refs/tags/v5.2-rc4
>
> Keys are here:
> https://www.apache.org/dist/jmeter/KEYS
>
> N.B.
> To create the distribution and test JMeter: "./gradlew build -Prelease
> -PskipSigning".
>
> JMeter 5.2 requires Java 8 or later to run.
>
> The artifacts were built with
>    Java(TM) SE Runtime Environment Oracle Corporation (build 1.8.0_221-b11)
>    Java HotSpot(TM) 64-Bit Server VM Oracle Corporation (build
> 25.221-b11, mixed mode)
>
> Some known issues and incompatible changes are listed on changes page.
>
> https://apache.github.io/jmeter-site-preview/site/changes.html#Known%20problems%20and%20workarounds
>
>
> All feedback and vote are welcome.
>
> [  ] +1  I support this release
> [  ] +0  I am OK with this release
> [  ] -0  OK, but....
> [  ] -1  I do not support this release (please indicate why)
>
> The vote will remain open for at least 72 hours.
>
> The PMC members please indicate the mention "(binding)" with your vote.
>
>
> Note: If the vote passes, the intention is to release the archive files
> and rename the RC tag as the release tag.
>
> Thanks in advance!
>
> Milamber
>
> ===
> [1] SHA512 hashes of archives for this vote:
>
>
> fa68f14e56ac45787befba3a328862715d7b50693fca5e202f7d83b6b3119a5700493837d94c42759ea9ecfc3245b08a289bc5295a68f81157b7c5ef432a62f2
> *apache-jmeter-5.2.tgz
>
> e762fb36b086e94050c66b90ff55ee6a54eb86c0df8b5f109b5ac1c50be461507596badfa95db3ae037a3265f58bad857a2619a801d527d969ce66015f6f6327
> *apache-jmeter-5.2.zip
>
> b6d6e73ecfd5407dd1ffa2df8931459163335d495ddec7559e6d396985ae3d520950fb20bd562678eaf0b00530a5e33f829c5476760196b3b0ef29a584a2a74f
> *apache-jmeter-5.2_src.tgz
>
> 8b47d6c30636941c8f5567c914c23a0e03166f85d91830af2f5949ef5301be5b6429f6dd7445a3ca45e048c3251c8d3c69255afc9ea7c67d879142573a15d47a
> *apache-jmeter-5.2_src.zip
>

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Felix Schumacher <fe...@internetallee.de>.

Am 23. Oktober 2019 13:21:06 MESZ schrieb Philippe Mouawad <p....@ubik-ingenierie.com>:
>Hi Felix,
>Do you confirm the bug?

Yes, I can confirm it. 

Felix

>I’ll try this evening
>Thanks
>
>On Wednesday, October 23, 2019, Felix Schumacher <
>felix.schumacher@internetallee.de> wrote:
>
>> There has been a bug report
>> https://bz.apache.org/bugzilla/show_bug.cgi?id=63876 that the JavaFX
>> component has not been compiled into the binary release.
>>
>> Apart from that the release looks good.
>>
>> Would it be too much to ask for another RC?
>>
>> Felix
>>
>> Am 18.10.19 um 12:50 schrieb Milamber:
>> > The fourth release candidate for JMeter 5.2 (26ef2cef53) has been
>> > prepared, and your votes are solicited.
>> >
>> > * This release brings two major changes for the distributed
>> > version-control system and the building tool:
>> >    - migration from Subversion (svn) to Git repository (compliant
>with
>> > GitHub and ASF GitBox)
>> >    - migration from Apache Ant to Gradle build system
>> >
>> > This for 2 main objectives:
>> >    * Improve the ease for contributors to make improvements and
>> > corrections of bugs
>> >    * Allow to have new and more frequent versions of JMeter by
>> > automating release steps.
>> >
>> > Special Thanks for Vladimir Sitnikov (vladimirsitnikov@a.o) for
>these
>> > works and supports.
>> >
>> > Please, test this release candidate (with load tests and/or
>functional
>> > tests) using Java 8+ on Linux/Windows/macOS, especially on the
>changes.
>> > Feedback is very welcome within the next 72 hours.
>> >
>> > @PMC and Commiters ==> This is the first release with the new
>> > process/tool with Gradle and Git repository, so please double check
>> > this release to find all issue in theses changes in the building
>and
>> > releasing mechanisms for JMeter. <==
>> >
>> > You can read the New and Noteworthy section with some screenshots
>to
>> > illustrate improvements and full list of changes at:
>> > https://apache.github.io/jmeter-site-preview/site/changes.html
>> >
>> > JMeter is a Java desktop application designed to load test
>functional
>> > behavior and measure performance. The current version targets Java
>8+
>> >
>> > Download - Archives/hashes/sigs:
>> >
>https://dist.apache.org/repos/dist/dev/jmeter/apache-jmeter-5.2-rc4/
>> > (dist revision 36377)
>> >
>> > RAT report:
>> > https://apache.github.io/jmeter-site-preview/rat/
>> >
>> > SHA512 hashes of archives for this vote: see footnote [1]
>> >
>> > Site preview is here:
>> > https://apache.github.io/jmeter-site-preview/site/
>> >
>> > JavaDoc API preview is here:
>> > https://apache.github.io/jmeter-site-preview/site/api/
>> >
>> > Maven staging repository is accessible here:
>> > https://repository.apache.org/content/repositories/
>> orgapachejmeter-1056/org/apache/jmeter/
>> >
>> >
>> > Tag:
>> > https://gitbox.apache.org/repos/asf?p=jmeter.git;a=tag;
>> h=refs/tags/v5.2-rc4
>> >
>> >
>> > Keys are here:
>> > https://www.apache.org/dist/jmeter/KEYS
>> >
>> > N.B.
>> > To create the distribution and test JMeter: "./gradlew build
>-Prelease
>> > -PskipSigning".
>> >
>> > JMeter 5.2 requires Java 8 or later to run.
>> >
>> > The artifacts were built with
>> >   Java(TM) SE Runtime Environment Oracle Corporation (build
>> > 1.8.0_221-b11)
>> >   Java HotSpot(TM) 64-Bit Server VM Oracle Corporation (build
>> > 25.221-b11, mixed mode)
>> >
>> > Some known issues and incompatible changes are listed on changes
>page.
>> > https://apache.github.io/jmeter-site-preview/site/
>> changes.html#Known%20problems%20and%20workarounds
>> >
>> >
>> >
>> > All feedback and vote are welcome.
>> >
>> > [  ] +1  I support this release
>> > [  ] +0  I am OK with this release
>> > [  ] -0  OK, but....
>> > [  ] -1  I do not support this release (please indicate why)
>> >
>> > The vote will remain open for at least 72 hours.
>> >
>> > The PMC members please indicate the mention "(binding)" with your
>vote.
>> >
>> >
>> > Note: If the vote passes, the intention is to release the archive
>files
>> > and rename the RC tag as the release tag.
>> >
>> > Thanks in advance!
>> >
>> > Milamber
>> >
>> > ===
>> > [1] SHA512 hashes of archives for this vote:
>> >
>> > fa68f14e56ac45787befba3a328862715d7b50693fca5e202f7d83b6b311
>> 9a5700493837d94c42759ea9ecfc3245b08a289bc5295a68f81157b7c5ef432a62f2
>> >
>> > *apache-jmeter-5.2.tgz
>> > e762fb36b086e94050c66b90ff55ee6a54eb86c0df8b5f109b5ac1c50be4
>> 61507596badfa95db3ae037a3265f58bad857a2619a801d527d969ce66015f6f6327
>> >
>> > *apache-jmeter-5.2.zip
>> > b6d6e73ecfd5407dd1ffa2df8931459163335d495ddec7559e6d396985ae
>> 3d520950fb20bd562678eaf0b00530a5e33f829c5476760196b3b0ef29a584a2a74f
>> >
>> > *apache-jmeter-5.2_src.tgz
>> > 8b47d6c30636941c8f5567c914c23a0e03166f85d91830af2f5949ef5301
>> be5b6429f6dd7445a3ca45e048c3251c8d3c69255afc9ea7c67d879142573a15d47a
>> >
>> > *apache-jmeter-5.2_src.zip
>>

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Philippe Mouawad <pm...@apache.org>.
Hello,

-1 also for me, I change my vote


Regards
Thanks

On Thursday, October 24, 2019, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

> As Philippe finds it useful too. I will vote
>
> -1
>
> We should do another rc.
>
> @vladimir is the release plugin ready to use with the changed sha512
> files?
>
>
> Felix
>
> Am 24. Oktober 2019 21:23:27 MESZ schrieb Milamber <mi...@apache.org>:
> >
> >I can cancel the RC4 vote or a PMC member can put a -1 (veto) to the
> >release.
> >Currently if I count my (future) vote +1 and the 2 +1 from Vladimir and
> >
> >Philippe, the RC4 will pass the vote.
> >
> >What is your (PMC member) preference?
> >
> >On 23/10/2019 16:28, Philippe Mouawad wrote:
> >> Hello,
> >>
> >> I think we should do another rc restoring browser component.
> >>
> >> I find it helpful when debugging a script.
> >>
> >> So unless there is a blocker, it should be restored.
> >>
> >> Thanks
> >>
> >> On Wednesday, October 23, 2019, Felix Schumacher <
> >> felix.schumacher@internetallee.de> wrote:
> >>
> >>> Am 23.10.19 um 15:12 schrieb Vladimir Sitnikov:
> >>>>> I already use the Oracle Java 8 to build the releases (RC4
> >include)
> >>>> Well. By "Require release manager" I mean **every** release
> >manager.
> >>>> For instance, I have not purchased Java license from Oracle. Does
> >that
> >>> mean
> >>>> I must buy one in order to be the release manager?
> >>> You don't have to buy a license to use the last openly available JDK
> >8
> >>> from Oracle. But it might be difficult to download it. (I found a
> >link
> >>> to the archive under the FAQ from the download for Java 8.
> >>> https://www.oracle.com/technetwork/java/archive-139210.html )
> >>>> The next question is what if someone downloads JMeter sources and
> >tries
> >>> to
> >>>> build it?
> >>> That depends -- as earlier -- on the version of used Java. At the
> >moment
> >>> you will only get a working JavaFX control, if you use Oracle JDK 8
> >>> (plus the parameter).
> >>>> Does that mean they must use Oracle Java?
> >>> No (if they are not interested in that special control)
> >>>> Does that mean they should get build failure when using builds like
> >>>> AdoptOpenJDK?
> >>> No (it didn't with the ant build -- I think we checked for a JavaFX
> >>> class on the classpath to decide whether we should compile it)
> >>>> The current implementation is "JavaFX opt-in".
> >>> At the moment I tend to include it on building the release, but I
> >have
> >>> sympathy with your arguments, that JavaFX is really difficult to use
> >at
> >>> build/run time.
> >>>
> >>> I am less sure with every time we are talking about it, that it is
> >>> valuable enough to keep the feature.
> >>>
> >>> But if we drop it now from the release, we should mention it in the
> >>> change logs and hope that someone comes up with an alternative, that
> >we
> >>> can include some day.
> >>>
> >>> Felix
> >>>
> >>>> Vladimir
> >>>>
>

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Felix Schumacher <fe...@internetallee.de>.
As Philippe finds it useful too. I will vote

-1

We should do another rc.

@vladimir is the release plugin ready to use with the changed sha512 files? 


Felix 

Am 24. Oktober 2019 21:23:27 MESZ schrieb Milamber <mi...@apache.org>:
>
>I can cancel the RC4 vote or a PMC member can put a -1 (veto) to the 
>release.
>Currently if I count my (future) vote +1 and the 2 +1 from Vladimir and
>
>Philippe, the RC4 will pass the vote.
>
>What is your (PMC member) preference?
>
>On 23/10/2019 16:28, Philippe Mouawad wrote:
>> Hello,
>>
>> I think we should do another rc restoring browser component.
>>
>> I find it helpful when debugging a script.
>>
>> So unless there is a blocker, it should be restored.
>>
>> Thanks
>>
>> On Wednesday, October 23, 2019, Felix Schumacher <
>> felix.schumacher@internetallee.de> wrote:
>>
>>> Am 23.10.19 um 15:12 schrieb Vladimir Sitnikov:
>>>>> I already use the Oracle Java 8 to build the releases (RC4
>include)
>>>> Well. By "Require release manager" I mean **every** release
>manager.
>>>> For instance, I have not purchased Java license from Oracle. Does
>that
>>> mean
>>>> I must buy one in order to be the release manager?
>>> You don't have to buy a license to use the last openly available JDK
>8
>>> from Oracle. But it might be difficult to download it. (I found a
>link
>>> to the archive under the FAQ from the download for Java 8.
>>> https://www.oracle.com/technetwork/java/archive-139210.html )
>>>> The next question is what if someone downloads JMeter sources and
>tries
>>> to
>>>> build it?
>>> That depends -- as earlier -- on the version of used Java. At the
>moment
>>> you will only get a working JavaFX control, if you use Oracle JDK 8
>>> (plus the parameter).
>>>> Does that mean they must use Oracle Java?
>>> No (if they are not interested in that special control)
>>>> Does that mean they should get build failure when using builds like
>>>> AdoptOpenJDK?
>>> No (it didn't with the ant build -- I think we checked for a JavaFX
>>> class on the classpath to decide whether we should compile it)
>>>> The current implementation is "JavaFX opt-in".
>>> At the moment I tend to include it on building the release, but I
>have
>>> sympathy with your arguments, that JavaFX is really difficult to use
>at
>>> build/run time.
>>>
>>> I am less sure with every time we are talking about it, that it is
>>> valuable enough to keep the feature.
>>>
>>> But if we drop it now from the release, we should mention it in the
>>> change logs and hope that someone comes up with an alternative, that
>we
>>> can include some day.
>>>
>>> Felix
>>>
>>>> Vladimir
>>>>

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Milamber <mi...@apache.org>.
I can cancel the RC4 vote or a PMC member can put a -1 (veto) to the 
release.
Currently if I count my (future) vote +1 and the 2 +1 from Vladimir and 
Philippe, the RC4 will pass the vote.

What is your (PMC member) preference?

On 23/10/2019 16:28, Philippe Mouawad wrote:
> Hello,
>
> I think we should do another rc restoring browser component.
>
> I find it helpful when debugging a script.
>
> So unless there is a blocker, it should be restored.
>
> Thanks
>
> On Wednesday, October 23, 2019, Felix Schumacher <
> felix.schumacher@internetallee.de> wrote:
>
>> Am 23.10.19 um 15:12 schrieb Vladimir Sitnikov:
>>>> I already use the Oracle Java 8 to build the releases (RC4 include)
>>> Well. By "Require release manager" I mean **every** release manager.
>>> For instance, I have not purchased Java license from Oracle. Does that
>> mean
>>> I must buy one in order to be the release manager?
>> You don't have to buy a license to use the last openly available JDK 8
>> from Oracle. But it might be difficult to download it. (I found a link
>> to the archive under the FAQ from the download for Java 8.
>> https://www.oracle.com/technetwork/java/archive-139210.html )
>>> The next question is what if someone downloads JMeter sources and tries
>> to
>>> build it?
>> That depends -- as earlier -- on the version of used Java. At the moment
>> you will only get a working JavaFX control, if you use Oracle JDK 8
>> (plus the parameter).
>>> Does that mean they must use Oracle Java?
>> No (if they are not interested in that special control)
>>> Does that mean they should get build failure when using builds like
>>> AdoptOpenJDK?
>> No (it didn't with the ant build -- I think we checked for a JavaFX
>> class on the classpath to decide whether we should compile it)
>>> The current implementation is "JavaFX opt-in".
>> At the moment I tend to include it on building the release, but I have
>> sympathy with your arguments, that JavaFX is really difficult to use at
>> build/run time.
>>
>> I am less sure with every time we are talking about it, that it is
>> valuable enough to keep the feature.
>>
>> But if we drop it now from the release, we should mention it in the
>> change logs and hope that someone comes up with an alternative, that we
>> can include some day.
>>
>> Felix
>>
>>> Vladimir
>>>


Re: [VOTE] Release JMeter 5.2 RC4

Posted by Philippe Mouawad <pm...@apache.org>.
Hello,

I think we should do another rc restoring browser component.

I find it helpful when debugging a script.

So unless there is a blocker, it should be restored.

Thanks

On Wednesday, October 23, 2019, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

>
> Am 23.10.19 um 15:12 schrieb Vladimir Sitnikov:
> >> I already use the Oracle Java 8 to build the releases (RC4 include)
> > Well. By "Require release manager" I mean **every** release manager.
> > For instance, I have not purchased Java license from Oracle. Does that
> mean
> > I must buy one in order to be the release manager?
> You don't have to buy a license to use the last openly available JDK 8
> from Oracle. But it might be difficult to download it. (I found a link
> to the archive under the FAQ from the download for Java 8.
> https://www.oracle.com/technetwork/java/archive-139210.html )
> >
> > The next question is what if someone downloads JMeter sources and tries
> to
> > build it?
> That depends -- as earlier -- on the version of used Java. At the moment
> you will only get a working JavaFX control, if you use Oracle JDK 8
> (plus the parameter).
> > Does that mean they must use Oracle Java?
> No (if they are not interested in that special control)
> > Does that mean they should get build failure when using builds like
> > AdoptOpenJDK?
> No (it didn't with the ant build -- I think we checked for a JavaFX
> class on the classpath to decide whether we should compile it)
> >
> > The current implementation is "JavaFX opt-in".
>
> At the moment I tend to include it on building the release, but I have
> sympathy with your arguments, that JavaFX is really difficult to use at
> build/run time.
>
> I am less sure with every time we are talking about it, that it is
> valuable enough to keep the feature.
>
> But if we drop it now from the release, we should mention it in the
> change logs and hope that someone comes up with an alternative, that we
> can include some day.
>
> Felix
>
> >
> > Vladimir
> >
>

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Felix Schumacher <fe...@internetallee.de>.
Am 23.10.19 um 15:12 schrieb Vladimir Sitnikov:
>> I already use the Oracle Java 8 to build the releases (RC4 include)
> Well. By "Require release manager" I mean **every** release manager.
> For instance, I have not purchased Java license from Oracle. Does that mean
> I must buy one in order to be the release manager?
You don't have to buy a license to use the last openly available JDK 8
from Oracle. But it might be difficult to download it. (I found a link
to the archive under the FAQ from the download for Java 8. 
https://www.oracle.com/technetwork/java/archive-139210.html )
>
> The next question is what if someone downloads JMeter sources and tries to
> build it?
That depends -- as earlier -- on the version of used Java. At the moment
you will only get a working JavaFX control, if you use Oracle JDK 8
(plus the parameter).
> Does that mean they must use Oracle Java?
No (if they are not interested in that special control)
> Does that mean they should get build failure when using builds like
> AdoptOpenJDK?
No (it didn't with the ant build -- I think we checked for a JavaFX
class on the classpath to decide whether we should compile it)
>
> The current implementation is "JavaFX opt-in".

At the moment I tend to include it on building the release, but I have
sympathy with your arguments, that JavaFX is really difficult to use at
build/run time.

I am less sure with every time we are talking about it, that it is
valuable enough to keep the feature.

But if we drop it now from the release, we should mention it in the
change logs and hope that someone comes up with an alternative, that we
can include some day.

Felix

>
> Vladimir
>

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Vladimir Sitnikov <si...@gmail.com>.
>I already use the Oracle Java 8 to build the releases (RC4 include)

Well. By "Require release manager" I mean **every** release manager.
For instance, I have not purchased Java license from Oracle. Does that mean
I must buy one in order to be the release manager?

The next question is what if someone downloads JMeter sources and tries to
build it?
Does that mean they must use Oracle Java?
Does that mean they should get build failure when using builds like
AdoptOpenJDK?

The current implementation is "JavaFX opt-in".

Vladimir

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Milamber <mi...@apache.org>.

On 23/10/2019 13:09, Vladimir Sitnikov wrote:
> OpenJDK8 does not have JavaFX, so the current JMeter code does not compile
> with OpenJDK8.
> For instance, if you download AdoptOpenJDK build, then you don't have
> JavaFX there.
>
> Frankly speaking, I would suggest considering java fx dropped in 5.2, and
> re-add it in 5.3 (e.g. as a part of upgrading to Java 11 + OpenJFX11)
>
> The workarounds there could be:
> 1) Add Java 11 to the build pipeline. For instance, build all the code with
> Java 11 with target=1.8
> That would enable us to use OpenJFX as a library
>
> 2) Use reflection-based code to implement RenderInBrowser (which would be
> rather complicated)
>
> 3) Require release manager to use Oracle Java 8 for making a release


I already use the Oracle Java 8 to build the releases (RC4 include)


>
> 4) other suggestions?
>
> Vladimir
>


Re: [VOTE] Release JMeter 5.2 RC4

Posted by Vladimir Sitnikov <si...@gmail.com>.
>OpenJDK8 does not have JavaFX, so the current JMeter code does not compile
with OpenJDK8.

Correction: RenderInBrowser.java cannot be compiled with OpenJDK8.
That is why RenderInBrowser.java is excluded by default.

Vladimir

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Vladimir Sitnikov <si...@gmail.com>.
OpenJDK8 does not have JavaFX, so the current JMeter code does not compile
with OpenJDK8.
For instance, if you download AdoptOpenJDK build, then you don't have
JavaFX there.

Frankly speaking, I would suggest considering java fx dropped in 5.2, and
re-add it in 5.3 (e.g. as a part of upgrading to Java 11 + OpenJFX11)

The workarounds there could be:
1) Add Java 11 to the build pipeline. For instance, build all the code with
Java 11 with target=1.8
That would enable us to use OpenJFX as a library

2) Use reflection-based code to implement RenderInBrowser (which would be
rather complicated)

3) Require release manager to use Oracle Java 8 for making a release

4) other suggestions?

Vladimir

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Philippe Mouawad <p....@ubik-ingenierie.com>.
Hi Felix,
Do you confirm the bug?
I’ll try this evening
Thanks

On Wednesday, October 23, 2019, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

> There has been a bug report
> https://bz.apache.org/bugzilla/show_bug.cgi?id=63876 that the JavaFX
> component has not been compiled into the binary release.
>
> Apart from that the release looks good.
>
> Would it be too much to ask for another RC?
>
> Felix
>
> Am 18.10.19 um 12:50 schrieb Milamber:
> > The fourth release candidate for JMeter 5.2 (26ef2cef53) has been
> > prepared, and your votes are solicited.
> >
> > * This release brings two major changes for the distributed
> > version-control system and the building tool:
> >    - migration from Subversion (svn) to Git repository (compliant with
> > GitHub and ASF GitBox)
> >    - migration from Apache Ant to Gradle build system
> >
> > This for 2 main objectives:
> >    * Improve the ease for contributors to make improvements and
> > corrections of bugs
> >    * Allow to have new and more frequent versions of JMeter by
> > automating release steps.
> >
> > Special Thanks for Vladimir Sitnikov (vladimirsitnikov@a.o) for these
> > works and supports.
> >
> > Please, test this release candidate (with load tests and/or functional
> > tests) using Java 8+ on Linux/Windows/macOS, especially on the changes.
> > Feedback is very welcome within the next 72 hours.
> >
> > @PMC and Commiters ==> This is the first release with the new
> > process/tool with Gradle and Git repository, so please double check
> > this release to find all issue in theses changes in the building and
> > releasing mechanisms for JMeter. <==
> >
> > You can read the New and Noteworthy section with some screenshots to
> > illustrate improvements and full list of changes at:
> > https://apache.github.io/jmeter-site-preview/site/changes.html
> >
> > JMeter is a Java desktop application designed to load test functional
> > behavior and measure performance. The current version targets Java 8+
> >
> > Download - Archives/hashes/sigs:
> > https://dist.apache.org/repos/dist/dev/jmeter/apache-jmeter-5.2-rc4/
> > (dist revision 36377)
> >
> > RAT report:
> > https://apache.github.io/jmeter-site-preview/rat/
> >
> > SHA512 hashes of archives for this vote: see footnote [1]
> >
> > Site preview is here:
> > https://apache.github.io/jmeter-site-preview/site/
> >
> > JavaDoc API preview is here:
> > https://apache.github.io/jmeter-site-preview/site/api/
> >
> > Maven staging repository is accessible here:
> > https://repository.apache.org/content/repositories/
> orgapachejmeter-1056/org/apache/jmeter/
> >
> >
> > Tag:
> > https://gitbox.apache.org/repos/asf?p=jmeter.git;a=tag;
> h=refs/tags/v5.2-rc4
> >
> >
> > Keys are here:
> > https://www.apache.org/dist/jmeter/KEYS
> >
> > N.B.
> > To create the distribution and test JMeter: "./gradlew build -Prelease
> > -PskipSigning".
> >
> > JMeter 5.2 requires Java 8 or later to run.
> >
> > The artifacts were built with
> >   Java(TM) SE Runtime Environment Oracle Corporation (build
> > 1.8.0_221-b11)
> >   Java HotSpot(TM) 64-Bit Server VM Oracle Corporation (build
> > 25.221-b11, mixed mode)
> >
> > Some known issues and incompatible changes are listed on changes page.
> > https://apache.github.io/jmeter-site-preview/site/
> changes.html#Known%20problems%20and%20workarounds
> >
> >
> >
> > All feedback and vote are welcome.
> >
> > [  ] +1  I support this release
> > [  ] +0  I am OK with this release
> > [  ] -0  OK, but....
> > [  ] -1  I do not support this release (please indicate why)
> >
> > The vote will remain open for at least 72 hours.
> >
> > The PMC members please indicate the mention "(binding)" with your vote.
> >
> >
> > Note: If the vote passes, the intention is to release the archive files
> > and rename the RC tag as the release tag.
> >
> > Thanks in advance!
> >
> > Milamber
> >
> > ===
> > [1] SHA512 hashes of archives for this vote:
> >
> > fa68f14e56ac45787befba3a328862715d7b50693fca5e202f7d83b6b311
> 9a5700493837d94c42759ea9ecfc3245b08a289bc5295a68f81157b7c5ef432a62f2
> >
> > *apache-jmeter-5.2.tgz
> > e762fb36b086e94050c66b90ff55ee6a54eb86c0df8b5f109b5ac1c50be4
> 61507596badfa95db3ae037a3265f58bad857a2619a801d527d969ce66015f6f6327
> >
> > *apache-jmeter-5.2.zip
> > b6d6e73ecfd5407dd1ffa2df8931459163335d495ddec7559e6d396985ae
> 3d520950fb20bd562678eaf0b00530a5e33f829c5476760196b3b0ef29a584a2a74f
> >
> > *apache-jmeter-5.2_src.tgz
> > 8b47d6c30636941c8f5567c914c23a0e03166f85d91830af2f5949ef5301
> be5b6429f6dd7445a3ca45e048c3251c8d3c69255afc9ea7c67d879142573a15d47a
> >
> > *apache-jmeter-5.2_src.zip
>


-- 


[image: logo Ubik Ingenierie] <https://www.ubik-ingenierie.com> Philippe
Mouawad
Senior Performance Expert
320914981 <+33320914981> | p.mouawad@ubik-ingenierie.com
[image: ubik-ingenierie.com] ubik-ingenierie.com
<https://www.ubik-ingenierie.com> | [image: 03.20.91.49.81] 03.20.91.49.81
<+33320914981> | [image: 23 rue du chemin de fer , 59100 , Roubaix] 23 rue
du chemin de fer, 59100, Roubaix
<https://www.openstreetmap.org/#map=18/50.69454/3.16455>

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Felix Schumacher <fe...@internetallee.de>.
There has been a bug report
https://bz.apache.org/bugzilla/show_bug.cgi?id=63876 that the JavaFX
component has not been compiled into the binary release.

Apart from that the release looks good.

Would it be too much to ask for another RC?

Felix

Am 18.10.19 um 12:50 schrieb Milamber:
> The fourth release candidate for JMeter 5.2 (26ef2cef53) has been
> prepared, and your votes are solicited.
>
> * This release brings two major changes for the distributed
> version-control system and the building tool:
>    - migration from Subversion (svn) to Git repository (compliant with
> GitHub and ASF GitBox)
>    - migration from Apache Ant to Gradle build system
>
> This for 2 main objectives:
>    * Improve the ease for contributors to make improvements and
> corrections of bugs
>    * Allow to have new and more frequent versions of JMeter by
> automating release steps.
>
> Special Thanks for Vladimir Sitnikov (vladimirsitnikov@a.o) for these
> works and supports.
>
> Please, test this release candidate (with load tests and/or functional
> tests) using Java 8+ on Linux/Windows/macOS, especially on the changes.
> Feedback is very welcome within the next 72 hours.
>
> @PMC and Commiters ==> This is the first release with the new
> process/tool with Gradle and Git repository, so please double check
> this release to find all issue in theses changes in the building and
> releasing mechanisms for JMeter. <==
>
> You can read the New and Noteworthy section with some screenshots to
> illustrate improvements and full list of changes at:
> https://apache.github.io/jmeter-site-preview/site/changes.html
>
> JMeter is a Java desktop application designed to load test functional
> behavior and measure performance. The current version targets Java 8+
>
> Download - Archives/hashes/sigs:
> https://dist.apache.org/repos/dist/dev/jmeter/apache-jmeter-5.2-rc4/
> (dist revision 36377)
>
> RAT report:
> https://apache.github.io/jmeter-site-preview/rat/
>
> SHA512 hashes of archives for this vote: see footnote [1]
>
> Site preview is here:
> https://apache.github.io/jmeter-site-preview/site/
>
> JavaDoc API preview is here:
> https://apache.github.io/jmeter-site-preview/site/api/
>
> Maven staging repository is accessible here:
> https://repository.apache.org/content/repositories/orgapachejmeter-1056/org/apache/jmeter/
>
>
> Tag:
> https://gitbox.apache.org/repos/asf?p=jmeter.git;a=tag;h=refs/tags/v5.2-rc4
>
>
> Keys are here:
> https://www.apache.org/dist/jmeter/KEYS
>
> N.B.
> To create the distribution and test JMeter: "./gradlew build -Prelease
> -PskipSigning".
>
> JMeter 5.2 requires Java 8 or later to run.
>
> The artifacts were built with
>   Java(TM) SE Runtime Environment Oracle Corporation (build
> 1.8.0_221-b11)
>   Java HotSpot(TM) 64-Bit Server VM Oracle Corporation (build
> 25.221-b11, mixed mode)
>
> Some known issues and incompatible changes are listed on changes page.
> https://apache.github.io/jmeter-site-preview/site/changes.html#Known%20problems%20and%20workarounds
>
>
>
> All feedback and vote are welcome.
>
> [  ] +1  I support this release
> [  ] +0  I am OK with this release
> [  ] -0  OK, but....
> [  ] -1  I do not support this release (please indicate why)
>
> The vote will remain open for at least 72 hours.
>
> The PMC members please indicate the mention "(binding)" with your vote.
>
>
> Note: If the vote passes, the intention is to release the archive files
> and rename the RC tag as the release tag.
>
> Thanks in advance!
>
> Milamber
>
> ===
> [1] SHA512 hashes of archives for this vote:
>
> fa68f14e56ac45787befba3a328862715d7b50693fca5e202f7d83b6b3119a5700493837d94c42759ea9ecfc3245b08a289bc5295a68f81157b7c5ef432a62f2
>
> *apache-jmeter-5.2.tgz
> e762fb36b086e94050c66b90ff55ee6a54eb86c0df8b5f109b5ac1c50be461507596badfa95db3ae037a3265f58bad857a2619a801d527d969ce66015f6f6327
>
> *apache-jmeter-5.2.zip
> b6d6e73ecfd5407dd1ffa2df8931459163335d495ddec7559e6d396985ae3d520950fb20bd562678eaf0b00530a5e33f829c5476760196b3b0ef29a584a2a74f
>
> *apache-jmeter-5.2_src.tgz
> 8b47d6c30636941c8f5567c914c23a0e03166f85d91830af2f5949ef5301be5b6429f6dd7445a3ca45e048c3251c8d3c69255afc9ea7c67d879142573a15d47a
>
> *apache-jmeter-5.2_src.zip

Re: [VOTE] Release JMeter 5.2 RC4

Posted by UBIK LOAD PACK Support <su...@ubikloadpack.com>.
Hello,

Thanks for RM.
We tested RC4 version. No issue found on our side.

[X] +1  I support this release

-- 

Regards
@ubikloadpack Team

On Fri, Oct 18, 2019 at 12:50 PM Milamber <mi...@apache.org> wrote:

> The fourth release candidate for JMeter 5.2 (26ef2cef53) has been
> prepared, and your votes are solicited.
>
> * This release brings two major changes for the distributed
> version-control system and the building tool:
>     - migration from Subversion (svn) to Git repository (compliant with
> GitHub and ASF GitBox)
>     - migration from Apache Ant to Gradle build system
>
> This for 2 main objectives:
>     * Improve the ease for contributors to make improvements and
> corrections of bugs
>     * Allow to have new and more frequent versions of JMeter by
> automating release steps.
>
> Special Thanks for Vladimir Sitnikov (vladimirsitnikov@a.o) for these
> works and supports.
>
> Please, test this release candidate (with load tests and/or functional
> tests) using Java 8+ on Linux/Windows/macOS, especially on the changes.
> Feedback is very welcome within the next 72 hours.
>
> @PMC and Commiters ==> This is the first release with the new
> process/tool with Gradle and Git repository, so please double check this
> release to find all issue in theses changes in the building and
> releasing mechanisms for JMeter. <==
>
> You can read the New and Noteworthy section with some screenshots to
> illustrate improvements and full list of changes at:
> https://apache.github.io/jmeter-site-preview/site/changes.html
>
> JMeter is a Java desktop application designed to load test functional
> behavior and measure performance. The current version targets Java 8+
>
> Download - Archives/hashes/sigs:
> https://dist.apache.org/repos/dist/dev/jmeter/apache-jmeter-5.2-rc4/
> (dist revision 36377)
>
> RAT report:
> https://apache.github.io/jmeter-site-preview/rat/
>
> SHA512 hashes of archives for this vote: see footnote [1]
>
> Site preview is here:
> https://apache.github.io/jmeter-site-preview/site/
>
> JavaDoc API preview is here:
> https://apache.github.io/jmeter-site-preview/site/api/
>
> Maven staging repository is accessible here:
>
> https://repository.apache.org/content/repositories/orgapachejmeter-1056/org/apache/jmeter/
>
> Tag:
> https://gitbox.apache.org/repos/asf?p=jmeter.git;a=tag;h=refs/tags/v5.2-rc4
>
> Keys are here:
> https://www.apache.org/dist/jmeter/KEYS
>
> N.B.
> To create the distribution and test JMeter: "./gradlew build -Prelease
> -PskipSigning".
>
> JMeter 5.2 requires Java 8 or later to run.
>
> The artifacts were built with
>    Java(TM) SE Runtime Environment Oracle Corporation (build 1.8.0_221-b11)
>    Java HotSpot(TM) 64-Bit Server VM Oracle Corporation (build
> 25.221-b11, mixed mode)
>
> Some known issues and incompatible changes are listed on changes page.
>
> https://apache.github.io/jmeter-site-preview/site/changes.html#Known%20problems%20and%20workarounds
>
>
> All feedback and vote are welcome.
>
> [  ] +1  I support this release
> [  ] +0  I am OK with this release
> [  ] -0  OK, but....
> [  ] -1  I do not support this release (please indicate why)
>
> The vote will remain open for at least 72 hours.
>
> The PMC members please indicate the mention "(binding)" with your vote.
>
>
> Note: If the vote passes, the intention is to release the archive files
> and rename the RC tag as the release tag.
>
> Thanks in advance!
>
> Milamber
>
> ===
> [1] SHA512 hashes of archives for this vote:
>
>
> fa68f14e56ac45787befba3a328862715d7b50693fca5e202f7d83b6b3119a5700493837d94c42759ea9ecfc3245b08a289bc5295a68f81157b7c5ef432a62f2
> *apache-jmeter-5.2.tgz
>
> e762fb36b086e94050c66b90ff55ee6a54eb86c0df8b5f109b5ac1c50be461507596badfa95db3ae037a3265f58bad857a2619a801d527d969ce66015f6f6327
> *apache-jmeter-5.2.zip
>
> b6d6e73ecfd5407dd1ffa2df8931459163335d495ddec7559e6d396985ae3d520950fb20bd562678eaf0b00530a5e33f829c5476760196b3b0ef29a584a2a74f
> *apache-jmeter-5.2_src.tgz
>
> 8b47d6c30636941c8f5567c914c23a0e03166f85d91830af2f5949ef5301be5b6429f6dd7445a3ca45e048c3251c8d3c69255afc9ea7c67d879142573a15d47a
> *apache-jmeter-5.2_src.zip
>

Re: [VOTE] Release JMeter 5.2 RC4

Posted by sebb <se...@gmail.com>.
I get a test failure on macOS:

org.apache.jmeter.protocol.http.control.DnsManagerTest >
badDnsInCustomResolverShouldFailHttpSampler(String, WireMockServer)[1]
FAILED
    org.opentest4j.AssertionFailedError: HTTP is using a custom DNS
resolver, so it must fail resolving localhost
    url: http://localhost:50029/index.html
    response: Not Found
    data.size: 84
    data: No response could be served as there are no stub mappings in
this WireMock instance.
     ==> expected: <Non HTTP response message: Failed to resolve host
name: localhost> but was: <Not Found>
        at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
        at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:69)
        at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:188)
        at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1146)
        at org.apache.jmeter.protocol.http.control.DnsManagerTest.badDnsInCustomResolverShouldFailHttpSampler(DnsManagerTest.java:58)

There are quite a lot of Javadoc warnings and use of deprecated API

Also the build complains about a license violation:

> Task :src:licenses:renderLicenseForSource
Dependencies of license category B are not allowed for SOURCE artifacts
=======================================================================

CC-BY-SA-3.0
* openiconlibrary:openiconlibrary:

OFL-1.1
* font-awesome-font:font-awesome-font:4.2.0

Also the test output is quite noisy, which makes it harder to spot warnings.
I think some of the output was added to make it easier to debug CI builds.
Ideally suppress most of it except when building under a CI.

On Sat, 26 Oct 2019 at 11:00, Felix Schumacher
<fe...@internetallee.de> wrote:
>
>
> Am 26.10.19 um 10:59 schrieb Milamber:
> >
> > Ok to start the RC5 today, or anyone need to add some changes?
>
> The release-plugin that generates the sha512 checksums still needs to be
> integrated.
>
> I currently try to update it from 1.34.0 to 1.36.0, but it keeps
> fighting back.
>
> Gradle doesn't complain about checksums of the plugins anymore, but the
> sha512 checksums are not generated/are in the wrong format.
>
> Felix
>
> >
> >
> >
> >
> > On 25/10/2019 13:39, Philippe Mouawad wrote:
> >> Hello,
> >>
> >> On french google group, a problem with documentation has been reported
> >>
> >> Following property logic has been changed, I’ll update doc this evening
> >> unless someone wants to do it before me:
> >>
> >> proxy.number.requests Add numeric *prefix* to Sampler names.defaults to:
> >> true
> >>
> >> Thanks
> >> proxy.number.requests Add numeric *prefix* to Sampler names.defaults to:
> >> true
> >>
> >>
> >> On Friday, October 25, 2019, sebb <se...@gmail.com> wrote:
> >>
> >>> On Thu, 24 Oct 2019 at 23:20, Vladimir Sitnikov
> >>> <si...@gmail.com> wrote:
> >>>> Milamber>This vote for RC4 not passed with 2 x -1 (veto) from PMC
> >>>> member.
> >>>>
> >>>> As per the ASF policy, releases may not be vetoed.
> >>> Agreed, the -1 is not a veto in the case of a release; i.e. a single
> >>> -1 does not automatically cancel the release.
> >>> However -1 votes do count towards the result, and may cause the vote to
> >>> fail.
> >>>
> >>> Also the release manager (RM) is at liberty to cancel a vote even if
> >>> there are sufficient +1 votes for it to pass.
> >>> This can happen if a problem is detected which the RM considers serious
> >>> enough.
> >>> It's not necessary for existing votes to be changed in order to
> >>> cancel the
> >>> vote.
> >>>
> >>>>> https://www.apache.org/foundation/voting.html#ReleaseVotes
> >>>>> Releases **may not** be vetoed
> >>>> Vladimir
> >>
> >

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Felix Schumacher <fe...@internetallee.de>.
Am 26.10.19 um 10:59 schrieb Milamber:
>
> Ok to start the RC5 today, or anyone need to add some changes?

The release-plugin that generates the sha512 checksums still needs to be
integrated.

I currently try to update it from 1.34.0 to 1.36.0, but it keeps
fighting back.

Gradle doesn't complain about checksums of the plugins anymore, but the
sha512 checksums are not generated/are in the wrong format.

Felix

>
>
>
>
> On 25/10/2019 13:39, Philippe Mouawad wrote:
>> Hello,
>>
>> On french google group, a problem with documentation has been reported
>>
>> Following property logic has been changed, I’ll update doc this evening
>> unless someone wants to do it before me:
>>
>> proxy.number.requests Add numeric *prefix* to Sampler names.defaults to:
>> true
>>
>> Thanks
>> proxy.number.requests Add numeric *prefix* to Sampler names.defaults to:
>> true
>>
>>
>> On Friday, October 25, 2019, sebb <se...@gmail.com> wrote:
>>
>>> On Thu, 24 Oct 2019 at 23:20, Vladimir Sitnikov
>>> <si...@gmail.com> wrote:
>>>> Milamber>This vote for RC4 not passed with 2 x -1 (veto) from PMC
>>>> member.
>>>>
>>>> As per the ASF policy, releases may not be vetoed.
>>> Agreed, the -1 is not a veto in the case of a release; i.e. a single
>>> -1 does not automatically cancel the release.
>>> However -1 votes do count towards the result, and may cause the vote to
>>> fail.
>>>
>>> Also the release manager (RM) is at liberty to cancel a vote even if
>>> there are sufficient +1 votes for it to pass.
>>> This can happen if a problem is detected which the RM considers serious
>>> enough.
>>> It's not necessary for existing votes to be changed in order to
>>> cancel the
>>> vote.
>>>
>>>>> https://www.apache.org/foundation/voting.html#ReleaseVotes
>>>>> Releases **may not** be vetoed
>>>> Vladimir
>>
>

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Milamber <mi...@apache.org>.
Hello Vladimir,

I will prepare the RC5 tonight (in 2-3 hours).

Milamber

On 29/10/2019 10:23, Vladimir Sitnikov wrote:
> Milamber,
>
> AFAIK we are good for the next release candidate.
> Could you please create the rc?
>
> Vladimir
>


Re: [VOTE] Release JMeter 5.2 RC4

Posted by Vladimir Sitnikov <si...@gmail.com>.
Milamber,

AFAIK we are good for the next release candidate.
Could you please create the rc?

Vladimir

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Philippe Mouawad <pm...@apache.org>.
Hi Felix,
See my answer inline below


Thanks

On Sunday, October 27, 2019, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

>
>
> Am 27. Oktober 2019 08:36:44 MEZ schrieb Philippe Mouawad <
> pmouawad@apache.org>:
> >Hello,
> >Could somebody check that Bug 63723 is fixed.
>
> I couldn't reproduce the failure when it was reported. So I don't think I
> will be able to reproduce it now.


So even with the scenario I provided you didn’t reproduce it  on 5.1.1 ?

Could you review the fix made ?

Thanks

>
> Felix
>
> >
> >I checked on my side and found it was.
> >My test case was to add a different and significant startup delay for
> >thread group of each agent so that the first one ends before the second
> >starts.
> >
> >
> >But reporter says it’s not without providing anything useful.
> >
> >Thanks
> >Regards
> >
> >On Saturday, October 26, 2019, Felix Schumacher <
> >felix.schumacher@internetallee.de> wrote:
> >
> >>
> >> Am 26.10.19 um 10:59 schrieb Milamber:
> >> >
> >> > Ok to start the RC5 today, or anyone need to add some changes?
> >>
> >> With Vladimir's last changes, the sha512 checksums are generated
> >> correctly (in my tests).
> >>
> >> I have added a few links to gradle.md in the docs and removed a bit
> >of
> >> misplaced spaces.
> >>
> >> From my side you can start RC5.
> >>
> >> Felix
> >>
> >> >
> >> >
> >> >
> >> >
> >> > On 25/10/2019 13:39, Philippe Mouawad wrote:
> >> >> Hello,
> >> >>
> >> >> On french google group, a problem with documentation has been
> >reported
> >> >>
> >> >> Following property logic has been changed, I’ll update doc this
> >evening
> >> >> unless someone wants to do it before me:
> >> >>
> >> >> proxy.number.requests Add numeric *prefix* to Sampler
> >names.defaults to:
> >> >> true
> >> >>
> >> >> Thanks
> >> >> proxy.number.requests Add numeric *prefix* to Sampler
> >names.defaults to:
> >> >> true
> >> >>
> >> >>
> >> >> On Friday, October 25, 2019, sebb <se...@gmail.com> wrote:
> >> >>
> >> >>> On Thu, 24 Oct 2019 at 23:20, Vladimir Sitnikov
> >> >>> <si...@gmail.com> wrote:
> >> >>>> Milamber>This vote for RC4 not passed with 2 x -1 (veto) from
> >PMC
> >> >>>> member.
> >> >>>>
> >> >>>> As per the ASF policy, releases may not be vetoed.
> >> >>> Agreed, the -1 is not a veto in the case of a release; i.e. a
> >single
> >> >>> -1 does not automatically cancel the release.
> >> >>> However -1 votes do count towards the result, and may cause the
> >vote to
> >> >>> fail.
> >> >>>
> >> >>> Also the release manager (RM) is at liberty to cancel a vote even
> >if
> >> >>> there are sufficient +1 votes for it to pass.
> >> >>> This can happen if a problem is detected which the RM considers
> >serious
> >> >>> enough.
> >> >>> It's not necessary for existing votes to be changed in order to
> >> >>> cancel the
> >> >>> vote.
> >> >>>
> >> >>>>> https://www.apache.org/foundation/voting.html#ReleaseVotes
> >> >>>>> Releases **may not** be vetoed
> >> >>>> Vladimir
> >> >>
> >> >
> >>
>

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Felix Schumacher <fe...@internetallee.de>.

Am 27. Oktober 2019 08:36:44 MEZ schrieb Philippe Mouawad <pm...@apache.org>:
>Hello,
>Could somebody check that Bug 63723 is fixed.

I couldn't reproduce the failure when it was reported. So I don't think I will be able to reproduce it now. 

Felix 

>
>I checked on my side and found it was.
>My test case was to add a different and significant startup delay for
>thread group of each agent so that the first one ends before the second
>starts.
>
>
>But reporter says it’s not without providing anything useful.
>
>Thanks
>Regards
>
>On Saturday, October 26, 2019, Felix Schumacher <
>felix.schumacher@internetallee.de> wrote:
>
>>
>> Am 26.10.19 um 10:59 schrieb Milamber:
>> >
>> > Ok to start the RC5 today, or anyone need to add some changes?
>>
>> With Vladimir's last changes, the sha512 checksums are generated
>> correctly (in my tests).
>>
>> I have added a few links to gradle.md in the docs and removed a bit
>of
>> misplaced spaces.
>>
>> From my side you can start RC5.
>>
>> Felix
>>
>> >
>> >
>> >
>> >
>> > On 25/10/2019 13:39, Philippe Mouawad wrote:
>> >> Hello,
>> >>
>> >> On french google group, a problem with documentation has been
>reported
>> >>
>> >> Following property logic has been changed, I’ll update doc this
>evening
>> >> unless someone wants to do it before me:
>> >>
>> >> proxy.number.requests Add numeric *prefix* to Sampler
>names.defaults to:
>> >> true
>> >>
>> >> Thanks
>> >> proxy.number.requests Add numeric *prefix* to Sampler
>names.defaults to:
>> >> true
>> >>
>> >>
>> >> On Friday, October 25, 2019, sebb <se...@gmail.com> wrote:
>> >>
>> >>> On Thu, 24 Oct 2019 at 23:20, Vladimir Sitnikov
>> >>> <si...@gmail.com> wrote:
>> >>>> Milamber>This vote for RC4 not passed with 2 x -1 (veto) from
>PMC
>> >>>> member.
>> >>>>
>> >>>> As per the ASF policy, releases may not be vetoed.
>> >>> Agreed, the -1 is not a veto in the case of a release; i.e. a
>single
>> >>> -1 does not automatically cancel the release.
>> >>> However -1 votes do count towards the result, and may cause the
>vote to
>> >>> fail.
>> >>>
>> >>> Also the release manager (RM) is at liberty to cancel a vote even
>if
>> >>> there are sufficient +1 votes for it to pass.
>> >>> This can happen if a problem is detected which the RM considers
>serious
>> >>> enough.
>> >>> It's not necessary for existing votes to be changed in order to
>> >>> cancel the
>> >>> vote.
>> >>>
>> >>>>> https://www.apache.org/foundation/voting.html#ReleaseVotes
>> >>>>> Releases **may not** be vetoed
>> >>>> Vladimir
>> >>
>> >
>>

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Philippe Mouawad <pm...@apache.org>.
Hello,
Could somebody check that Bug 63723 is fixed.

I checked on my side and found it was.
My test case was to add a different and significant startup delay for
thread group of each agent so that the first one ends before the second
starts.


But reporter says it’s not without providing anything useful.

Thanks
Regards

On Saturday, October 26, 2019, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

>
> Am 26.10.19 um 10:59 schrieb Milamber:
> >
> > Ok to start the RC5 today, or anyone need to add some changes?
>
> With Vladimir's last changes, the sha512 checksums are generated
> correctly (in my tests).
>
> I have added a few links to gradle.md in the docs and removed a bit of
> misplaced spaces.
>
> From my side you can start RC5.
>
> Felix
>
> >
> >
> >
> >
> > On 25/10/2019 13:39, Philippe Mouawad wrote:
> >> Hello,
> >>
> >> On french google group, a problem with documentation has been reported
> >>
> >> Following property logic has been changed, I’ll update doc this evening
> >> unless someone wants to do it before me:
> >>
> >> proxy.number.requests Add numeric *prefix* to Sampler names.defaults to:
> >> true
> >>
> >> Thanks
> >> proxy.number.requests Add numeric *prefix* to Sampler names.defaults to:
> >> true
> >>
> >>
> >> On Friday, October 25, 2019, sebb <se...@gmail.com> wrote:
> >>
> >>> On Thu, 24 Oct 2019 at 23:20, Vladimir Sitnikov
> >>> <si...@gmail.com> wrote:
> >>>> Milamber>This vote for RC4 not passed with 2 x -1 (veto) from PMC
> >>>> member.
> >>>>
> >>>> As per the ASF policy, releases may not be vetoed.
> >>> Agreed, the -1 is not a veto in the case of a release; i.e. a single
> >>> -1 does not automatically cancel the release.
> >>> However -1 votes do count towards the result, and may cause the vote to
> >>> fail.
> >>>
> >>> Also the release manager (RM) is at liberty to cancel a vote even if
> >>> there are sufficient +1 votes for it to pass.
> >>> This can happen if a problem is detected which the RM considers serious
> >>> enough.
> >>> It's not necessary for existing votes to be changed in order to
> >>> cancel the
> >>> vote.
> >>>
> >>>>> https://www.apache.org/foundation/voting.html#ReleaseVotes
> >>>>> Releases **may not** be vetoed
> >>>> Vladimir
> >>
> >
>

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Felix Schumacher <fe...@internetallee.de>.
Am 26.10.19 um 10:59 schrieb Milamber:
>
> Ok to start the RC5 today, or anyone need to add some changes?

With Vladimir's last changes, the sha512 checksums are generated
correctly (in my tests).

I have added a few links to gradle.md in the docs and removed a bit of
misplaced spaces.

From my side you can start RC5.

Felix

>
>
>
>
> On 25/10/2019 13:39, Philippe Mouawad wrote:
>> Hello,
>>
>> On french google group, a problem with documentation has been reported
>>
>> Following property logic has been changed, I’ll update doc this evening
>> unless someone wants to do it before me:
>>
>> proxy.number.requests Add numeric *prefix* to Sampler names.defaults to:
>> true
>>
>> Thanks
>> proxy.number.requests Add numeric *prefix* to Sampler names.defaults to:
>> true
>>
>>
>> On Friday, October 25, 2019, sebb <se...@gmail.com> wrote:
>>
>>> On Thu, 24 Oct 2019 at 23:20, Vladimir Sitnikov
>>> <si...@gmail.com> wrote:
>>>> Milamber>This vote for RC4 not passed with 2 x -1 (veto) from PMC
>>>> member.
>>>>
>>>> As per the ASF policy, releases may not be vetoed.
>>> Agreed, the -1 is not a veto in the case of a release; i.e. a single
>>> -1 does not automatically cancel the release.
>>> However -1 votes do count towards the result, and may cause the vote to
>>> fail.
>>>
>>> Also the release manager (RM) is at liberty to cancel a vote even if
>>> there are sufficient +1 votes for it to pass.
>>> This can happen if a problem is detected which the RM considers serious
>>> enough.
>>> It's not necessary for existing votes to be changed in order to
>>> cancel the
>>> vote.
>>>
>>>>> https://www.apache.org/foundation/voting.html#ReleaseVotes
>>>>> Releases **may not** be vetoed
>>>> Vladimir
>>
>

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Philippe Mouawad <ph...@gmail.com>.
ok by me

On Saturday, October 26, 2019, Milamber <mi...@apache.org> wrote:

>
> Ok to start the RC5 today, or anyone need to add some changes?
>
>
>
>
> On 25/10/2019 13:39, Philippe Mouawad wrote:
>
>> Hello,
>>
>> On french google group, a problem with documentation has been reported
>>
>> Following property logic has been changed, I’ll update doc this evening
>> unless someone wants to do it before me:
>>
>> proxy.number.requests Add numeric *prefix* to Sampler names.defaults to:
>> true
>>
>> Thanks
>> proxy.number.requests Add numeric *prefix* to Sampler names.defaults to:
>> true
>>
>>
>> On Friday, October 25, 2019, sebb <se...@gmail.com> wrote:
>>
>> On Thu, 24 Oct 2019 at 23:20, Vladimir Sitnikov
>>> <si...@gmail.com> wrote:
>>>
>>>> Milamber>This vote for RC4 not passed with 2 x -1 (veto) from PMC
>>>> member.
>>>>
>>>> As per the ASF policy, releases may not be vetoed.
>>>>
>>> Agreed, the -1 is not a veto in the case of a release; i.e. a single
>>> -1 does not automatically cancel the release.
>>> However -1 votes do count towards the result, and may cause the vote to
>>> fail.
>>>
>>> Also the release manager (RM) is at liberty to cancel a vote even if
>>> there are sufficient +1 votes for it to pass.
>>> This can happen if a problem is detected which the RM considers serious
>>> enough.
>>> It's not necessary for existing votes to be changed in order to cancel
>>> the
>>> vote.
>>>
>>> https://www.apache.org/foundation/voting.html#ReleaseVotes
>>>>> Releases **may not** be vetoed
>>>>>
>>>> Vladimir
>>>>
>>>
>>
>

-- 
Cordialement.
Philippe Mouawad.

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Milamber <mi...@apache.org>.
Ok to start the RC5 today, or anyone need to add some changes?




On 25/10/2019 13:39, Philippe Mouawad wrote:
> Hello,
>
> On french google group, a problem with documentation has been reported
>
> Following property logic has been changed, I’ll update doc this evening
> unless someone wants to do it before me:
>
> proxy.number.requests Add numeric *prefix* to Sampler names.defaults to:
> true
>
> Thanks
> proxy.number.requests Add numeric *prefix* to Sampler names.defaults to:
> true
>
>
> On Friday, October 25, 2019, sebb <se...@gmail.com> wrote:
>
>> On Thu, 24 Oct 2019 at 23:20, Vladimir Sitnikov
>> <si...@gmail.com> wrote:
>>> Milamber>This vote for RC4 not passed with 2 x -1 (veto) from PMC member.
>>>
>>> As per the ASF policy, releases may not be vetoed.
>> Agreed, the -1 is not a veto in the case of a release; i.e. a single
>> -1 does not automatically cancel the release.
>> However -1 votes do count towards the result, and may cause the vote to
>> fail.
>>
>> Also the release manager (RM) is at liberty to cancel a vote even if
>> there are sufficient +1 votes for it to pass.
>> This can happen if a problem is detected which the RM considers serious
>> enough.
>> It's not necessary for existing votes to be changed in order to cancel the
>> vote.
>>
>>>> https://www.apache.org/foundation/voting.html#ReleaseVotes
>>>> Releases **may not** be vetoed
>>> Vladimir
>


Re: [VOTE] Release JMeter 5.2 RC4

Posted by Philippe Mouawad <p....@ubik-ingenierie.com>.
Hello,

On french google group, a problem with documentation has been reported

Following property logic has been changed, I’ll update doc this evening
unless someone wants to do it before me:

proxy.number.requests Add numeric *prefix* to Sampler names.defaults to:
true

Thanks
proxy.number.requests Add numeric *prefix* to Sampler names.defaults to:
true


On Friday, October 25, 2019, sebb <se...@gmail.com> wrote:

> On Thu, 24 Oct 2019 at 23:20, Vladimir Sitnikov
> <si...@gmail.com> wrote:
> >
> > Milamber>This vote for RC4 not passed with 2 x -1 (veto) from PMC member.
> >
> > As per the ASF policy, releases may not be vetoed.
>
> Agreed, the -1 is not a veto in the case of a release; i.e. a single
> -1 does not automatically cancel the release.
> However -1 votes do count towards the result, and may cause the vote to
> fail.
>
> Also the release manager (RM) is at liberty to cancel a vote even if
> there are sufficient +1 votes for it to pass.
> This can happen if a problem is detected which the RM considers serious
> enough.
> It's not necessary for existing votes to be changed in order to cancel the
> vote.
>
> > > https://www.apache.org/foundation/voting.html#ReleaseVotes
> > > Releases **may not** be vetoed
> >
> > Vladimir
>


-- 


[image: logo Ubik Ingenierie] <https://www.ubik-ingenierie.com> Philippe
Mouawad
Senior Performance Expert
320914981 <+33320914981> | p.mouawad@ubik-ingenierie.com
[image: ubik-ingenierie.com] ubik-ingenierie.com
<https://www.ubik-ingenierie.com> | [image: 03.20.91.49.81] 03.20.91.49.81
<+33320914981> | [image: 23 rue du chemin de fer , 59100 , Roubaix] 23 rue
du chemin de fer, 59100, Roubaix
<https://www.openstreetmap.org/#map=18/50.69454/3.16455>

Re: [NOT PASS] Re: [VOTE] Release JMeter 5.2 RC4

Posted by sebb <se...@gmail.com>.
On Thu, 24 Oct 2019 at 23:20, Vladimir Sitnikov
<si...@gmail.com> wrote:
>
> Milamber>This vote for RC4 not passed with 2 x -1 (veto) from PMC member.
>
> As per the ASF policy, releases may not be vetoed.

Agreed, the -1 is not a veto in the case of a release; i.e. a single
-1 does not automatically cancel the release.
However -1 votes do count towards the result, and may cause the vote to fail.

Also the release manager (RM) is at liberty to cancel a vote even if
there are sufficient +1 votes for it to pass.
This can happen if a problem is detected which the RM considers serious enough.
It's not necessary for existing votes to be changed in order to cancel the vote.

> > https://www.apache.org/foundation/voting.html#ReleaseVotes
> > Releases **may not** be vetoed
>
> Vladimir

Re: [NOT PASS] Re: [VOTE] Release JMeter 5.2 RC4

Posted by Vladimir Sitnikov <si...@gmail.com>.
Milamber>This vote for RC4 not passed with 2 x -1 (veto) from PMC member.

As per the ASF policy, releases may not be vetoed.

> https://www.apache.org/foundation/voting.html#ReleaseVotes
> Releases **may not** be vetoed

Vladimir

[NOT PASS] Re: [VOTE] Release JMeter 5.2 RC4

Posted by Milamber <mi...@apache.org>.
Hello,

This vote for RC4 not passed with 2 x -1 (veto) from PMC member.

After fixing the issue to release a new RC 5 will purpose for vote.

Thanks for your test about the RC4.

Milamber

On 18/10/2019 11:50, Milamber wrote:
> The fourth release candidate for JMeter 5.2 (26ef2cef53) has been
> prepared, and your votes are solicited.
>
> * This release brings two major changes for the distributed 
> version-control system and the building tool:
>    - migration from Subversion (svn) to Git repository (compliant with 
> GitHub and ASF GitBox)
>    - migration from Apache Ant to Gradle build system
>
> This for 2 main objectives:
>    * Improve the ease for contributors to make improvements and 
> corrections of bugs
>    * Allow to have new and more frequent versions of JMeter by 
> automating release steps.
>
> Special Thanks for Vladimir Sitnikov (vladimirsitnikov@a.o) for these 
> works and supports.
>
> Please, test this release candidate (with load tests and/or functional
> tests) using Java 8+ on Linux/Windows/macOS, especially on the changes.
> Feedback is very welcome within the next 72 hours.
>
> @PMC and Commiters ==> This is the first release with the new 
> process/tool with Gradle and Git repository, so please double check 
> this release to find all issue in theses changes in the building and 
> releasing mechanisms for JMeter. <==
>
> You can read the New and Noteworthy section with some screenshots to
> illustrate improvements and full list of changes at:
> https://apache.github.io/jmeter-site-preview/site/changes.html
>
> JMeter is a Java desktop application designed to load test functional
> behavior and measure performance. The current version targets Java 8+
>
> Download - Archives/hashes/sigs:
> https://dist.apache.org/repos/dist/dev/jmeter/apache-jmeter-5.2-rc4/
> (dist revision 36377)
>
> RAT report:
> https://apache.github.io/jmeter-site-preview/rat/
>
> SHA512 hashes of archives for this vote: see footnote [1]
>
> Site preview is here:
> https://apache.github.io/jmeter-site-preview/site/
>
> JavaDoc API preview is here:
> https://apache.github.io/jmeter-site-preview/site/api/
>
> Maven staging repository is accessible here:
> https://repository.apache.org/content/repositories/orgapachejmeter-1056/org/apache/jmeter/ 
>
>
> Tag:
> https://gitbox.apache.org/repos/asf?p=jmeter.git;a=tag;h=refs/tags/v5.2-rc4 
>
>
> Keys are here:
> https://www.apache.org/dist/jmeter/KEYS
>
> N.B.
> To create the distribution and test JMeter: "./gradlew build -Prelease 
> -PskipSigning".
>
> JMeter 5.2 requires Java 8 or later to run.
>
> The artifacts were built with
>   Java(TM) SE Runtime Environment Oracle Corporation (build 
> 1.8.0_221-b11)
>   Java HotSpot(TM) 64-Bit Server VM Oracle Corporation (build 
> 25.221-b11, mixed mode)
>
> Some known issues and incompatible changes are listed on changes page.
> https://apache.github.io/jmeter-site-preview/site/changes.html#Known%20problems%20and%20workarounds 
>
>
>
> All feedback and vote are welcome.
>
> [  ] +1  I support this release
> [  ] +0  I am OK with this release
> [  ] -0  OK, but....
> [  ] -1  I do not support this release (please indicate why)
>
> The vote will remain open for at least 72 hours.
>
> The PMC members please indicate the mention "(binding)" with your vote.
>
>
> Note: If the vote passes, the intention is to release the archive files
> and rename the RC tag as the release tag.
>
> Thanks in advance!
>
> Milamber
>
> ===
> [1] SHA512 hashes of archives for this vote:
>
> fa68f14e56ac45787befba3a328862715d7b50693fca5e202f7d83b6b3119a5700493837d94c42759ea9ecfc3245b08a289bc5295a68f81157b7c5ef432a62f2 
>
> *apache-jmeter-5.2.tgz
> e762fb36b086e94050c66b90ff55ee6a54eb86c0df8b5f109b5ac1c50be461507596badfa95db3ae037a3265f58bad857a2619a801d527d969ce66015f6f6327 
>
> *apache-jmeter-5.2.zip
> b6d6e73ecfd5407dd1ffa2df8931459163335d495ddec7559e6d396985ae3d520950fb20bd562678eaf0b00530a5e33f829c5476760196b3b0ef29a584a2a74f 
>
> *apache-jmeter-5.2_src.tgz
> 8b47d6c30636941c8f5567c914c23a0e03166f85d91830af2f5949ef5301be5b6429f6dd7445a3ca45e048c3251c8d3c69255afc9ea7c67d879142573a15d47a 
>
> *apache-jmeter-5.2_src.zip
>


Re: [VOTE] Release JMeter 5.2 RC4

Posted by Felix Schumacher <fe...@internetallee.de>.
Am 24.10.19 um 10:15 schrieb Rainer Jung:
> Am 23.10.2019 um 17:21 schrieb Vladimir Sitnikov:
>>> I looked into the gradle build scripts, but didn't find the place where
>>> the checksums are generated
>>
>> It is here:
>> https://github.com/vlsi/vlsi-release-plugins/blob/73b67142a10ff3bcedc136d1a99e3d9f3a827a2e/plugins/stage-vote-release-plugin/src/main/kotlin/com/github/vlsi/gradle/release/ReleaseArtifacts.kt#L75
>>
>
> If I understand it correctly, one could add something like
>
>   "format" to "MD5SUM",
>
> or more explicitly
>
>   "pattern" to "{0} *{1}",
>
> since these are supported by the original ant checksum task.

I already submitted a pr, but I couldn't test it yet. (I chose the
MD5SUM route)

https://github.com/vlsi/vlsi-release-plugins/pull/25

Felix

>
> Regards,
>
> Rainer

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Rainer Jung <ra...@kippdata.de>.
Am 23.10.2019 um 17:21 schrieb Vladimir Sitnikov:
>> I looked into the gradle build scripts, but didn't find the place where
>> the checksums are generated
> 
> It is here:
> https://github.com/vlsi/vlsi-release-plugins/blob/73b67142a10ff3bcedc136d1a99e3d9f3a827a2e/plugins/stage-vote-release-plugin/src/main/kotlin/com/github/vlsi/gradle/release/ReleaseArtifacts.kt#L75

If I understand it correctly, one could add something like

   "format" to "MD5SUM",

or more explicitly

   "pattern" to "{0} *{1}",

since these are supported by the original ant checksum task.

Regards,

Rainer

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Vladimir Sitnikov <si...@gmail.com>.
>I looked into the gradle build scripts, but didn't find the place where
>the checksums are generated

It is here:
https://github.com/vlsi/vlsi-release-plugins/blob/73b67142a10ff3bcedc136d1a99e3d9f3a827a2e/plugins/stage-vote-release-plugin/src/main/kotlin/com/github/vlsi/gradle/release/ReleaseArtifacts.kt#L75

Vladimir

Re: [VOTE] Release JMeter 5.2 RC4

Posted by Felix Schumacher <fe...@internetallee.de>.
I have a question about another minor thing. The generated checksum
files contain the checksum only.

For ease of use, it would be great, if they could contain the filename
(prefixed with a *), too. That way we could check the checksums with
"sha512sum -c *.sha512" instead of "for i in *.sha512; do echo $(cat $i;
echo $(basename $i .sha512)) | sha512sum -c - ; done"

I looked into the gradle build scripts, but didn't find the place where
the checksums are generated.

Felix

Am 18.10.19 um 12:50 schrieb Milamber:
> The fourth release candidate for JMeter 5.2 (26ef2cef53) has been
> prepared, and your votes are solicited.
>
> * This release brings two major changes for the distributed
> version-control system and the building tool:
>    - migration from Subversion (svn) to Git repository (compliant with
> GitHub and ASF GitBox)
>    - migration from Apache Ant to Gradle build system
>
> This for 2 main objectives:
>    * Improve the ease for contributors to make improvements and
> corrections of bugs
>    * Allow to have new and more frequent versions of JMeter by
> automating release steps.
>
> Special Thanks for Vladimir Sitnikov (vladimirsitnikov@a.o) for these
> works and supports.
>
> Please, test this release candidate (with load tests and/or functional
> tests) using Java 8+ on Linux/Windows/macOS, especially on the changes.
> Feedback is very welcome within the next 72 hours.
>
> @PMC and Commiters ==> This is the first release with the new
> process/tool with Gradle and Git repository, so please double check
> this release to find all issue in theses changes in the building and
> releasing mechanisms for JMeter. <==
>
> You can read the New and Noteworthy section with some screenshots to
> illustrate improvements and full list of changes at:
> https://apache.github.io/jmeter-site-preview/site/changes.html
>
> JMeter is a Java desktop application designed to load test functional
> behavior and measure performance. The current version targets Java 8+
>
> Download - Archives/hashes/sigs:
> https://dist.apache.org/repos/dist/dev/jmeter/apache-jmeter-5.2-rc4/
> (dist revision 36377)
>
> RAT report:
> https://apache.github.io/jmeter-site-preview/rat/
>
> SHA512 hashes of archives for this vote: see footnote [1]
>
> Site preview is here:
> https://apache.github.io/jmeter-site-preview/site/
>
> JavaDoc API preview is here:
> https://apache.github.io/jmeter-site-preview/site/api/
>
> Maven staging repository is accessible here:
> https://repository.apache.org/content/repositories/orgapachejmeter-1056/org/apache/jmeter/
>
>
> Tag:
> https://gitbox.apache.org/repos/asf?p=jmeter.git;a=tag;h=refs/tags/v5.2-rc4
>
>
> Keys are here:
> https://www.apache.org/dist/jmeter/KEYS
>
> N.B.
> To create the distribution and test JMeter: "./gradlew build -Prelease
> -PskipSigning".
>
> JMeter 5.2 requires Java 8 or later to run.
>
> The artifacts were built with
>   Java(TM) SE Runtime Environment Oracle Corporation (build
> 1.8.0_221-b11)
>   Java HotSpot(TM) 64-Bit Server VM Oracle Corporation (build
> 25.221-b11, mixed mode)
>
> Some known issues and incompatible changes are listed on changes page.
> https://apache.github.io/jmeter-site-preview/site/changes.html#Known%20problems%20and%20workarounds
>
>
>
> All feedback and vote are welcome.
>
> [  ] +1  I support this release
> [  ] +0  I am OK with this release
> [  ] -0  OK, but....
> [  ] -1  I do not support this release (please indicate why)
>
> The vote will remain open for at least 72 hours.
>
> The PMC members please indicate the mention "(binding)" with your vote.
>
>
> Note: If the vote passes, the intention is to release the archive files
> and rename the RC tag as the release tag.
>
> Thanks in advance!
>
> Milamber
>
> ===
> [1] SHA512 hashes of archives for this vote:
>
> fa68f14e56ac45787befba3a328862715d7b50693fca5e202f7d83b6b3119a5700493837d94c42759ea9ecfc3245b08a289bc5295a68f81157b7c5ef432a62f2
>
> *apache-jmeter-5.2.tgz
> e762fb36b086e94050c66b90ff55ee6a54eb86c0df8b5f109b5ac1c50be461507596badfa95db3ae037a3265f58bad857a2619a801d527d969ce66015f6f6327
>
> *apache-jmeter-5.2.zip
> b6d6e73ecfd5407dd1ffa2df8931459163335d495ddec7559e6d396985ae3d520950fb20bd562678eaf0b00530a5e33f829c5476760196b3b0ef29a584a2a74f
>
> *apache-jmeter-5.2_src.tgz
> 8b47d6c30636941c8f5567c914c23a0e03166f85d91830af2f5949ef5301be5b6429f6dd7445a3ca45e048c3251c8d3c69255afc9ea7c67d879142573a15d47a
>
> *apache-jmeter-5.2_src.zip