You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by wadsashika <gi...@git.apache.org> on 2015/03/23 22:22:48 UTC
[GitHub] couchdb-fauxton pull request: Invalid 'undefined' class in All Doc...
GitHub user wadsashika opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/329
Invalid 'undefined' class in All Docs header button element
This remove the invalide undefined class in select button of All Docs header which appear when landing the page
Closes COUCHDB-2577
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wadsashika/couchdb-fauxton 2577-Invalid-undifined-class-in-All-Docs-header-button-element
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/329.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #329
----
commit c24a4e4b64affb24b78e44a40e2105c484f5de01
Author: Dulanga Sashika <wa...@gmail.com>
Date: 2015-03-23T21:20:37Z
Invalid 'undefined' class in All Docs header button element
This remove the invalide undefined class in select button of All Docs header which appear when landing the page
Closes COUCHDB-2577
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Invalid 'undefined' class in All Doc...
Posted by wadsashika <gi...@git.apache.org>.
Github user wadsashika closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/329
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Invalid 'undefined' class in All Doc...
Posted by wadsashika <gi...@git.apache.org>.
Github user wadsashika commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/329#issuecomment-85525115
No no I will send it again with the test function. I deleted my branch from
the github.
On Tue, Mar 24, 2015 at 6:26 PM, Robert Kowalski <no...@github.com>
wrote:
> oh, why did you close the PR?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/couchdb-fauxton/pull/329#issuecomment-85485031>
> .
>
--
W. A. Dulanga Sashika,
Undergraduate Student,
Department of Computer Science and Engineering,
University of Moratuwa.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Invalid 'undefined' class in All Doc...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/329#issuecomment-85485031
oh, why did you close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Invalid 'undefined' class in All Doc...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/329#issuecomment-85209833
Thank you for your contribution! Every PR needs tests, can you provide a test?
Example test: https://github.com/apache/couchdb-fauxton/blob/master/app/addons/documents/tests/headerSpec.react.jsx#L43
You can run them using `grunt test`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---