You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "SzyWilliam (via GitHub)" <gi...@apache.org> on 2024/04/09 06:58:46 UTC
[PR] RATIS-2053. Notify term index change when configuration changes [ratis]
SzyWilliam opened a new pull request, #1063:
URL: https://github.com/apache/ratis/pull/1063
## What changes were proposed in this pull request?
Statemachine will not update LastApplied TermIndex when handling configuration change logs. This will lead problems for linearizable reads here https://github.com/apache/ratis/blob/bc6221b32fff9022cebb02bb243aea9fff35e290/ratis-server/src/main/java/org/apache/ratis/server/impl/ReadRequests.java#L102-L105.
Linearizable read will compare the `apply index` (of state machine instead of RaftServer) with `read index`. So we need to update the state machines' `apply index` when applying configuration logs.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-2053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2053. Notify term index change when configuration changes [ratis]
Posted by "SzyWilliam (via GitHub)" <gi...@apache.org>.
SzyWilliam commented on PR #1063:
URL: https://github.com/apache/ratis/pull/1063#issuecomment-2048743682
@szetszwo Thanks for reviewing this! I found that RaftServer would update TermIndex when applying non-statemachine logs here https://github.com/apache/ratis/blob/8638a2ffa802de576aae546c22160da3d9339a8f/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java#L1809.
So this patch is duplicate. Let me close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] RATIS-2053. Notify term index change when configuration changes [ratis]
Posted by "SzyWilliam (via GitHub)" <gi...@apache.org>.
SzyWilliam closed pull request #1063: RATIS-2053. Notify term index change when configuration changes
URL: https://github.com/apache/ratis/pull/1063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org