You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Amogh Vasekar <am...@citrix.com> on 2014/05/05 20:54:35 UTC
Review Request 21087: Remove hard-coding for platform emulators in Xen Server
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21087/
-----------------------------------------------------------
Review request for cloudstack and Nitin Mehta.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6358
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6358
Repository: cloudstack-git
Description
-------
As a part of supporting dynamic guest OS defined by user, removing the hard-coded dependencies.
This patch is for XenServer
Diffs
-----
api/src/com/cloud/agent/api/to/VirtualMachineTO.java bbd83852abf840ab5d93f53ad0c71e61491b2dda
core/src/com/cloud/agent/api/VMSnapshotBaseCommand.java d2abd54e0407ab597636d9c9d5a596e55f987108
engine/storage/snapshot/src/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java e86bd23b0500f25268a603a7c41e8e00d18957d2
engine/storage/snapshot/test/src/VMSnapshotStrategyTest.java 9eaa7e19c134caf0633bb9099c5f858075fddba7
engine/storage/src/org/apache/cloudstack/storage/helper/HypervisorHelperImpl.java b41c1fa14ac77cffa53ce5ae2aec6d9bea9cd649
plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 89e4ab5d94b61cc6acdefc8102da4a33dbbf23b5
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java ad3797306c92d80d929a1e09b46b471231baa6c0
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpOssResource.java 4a69d3aececd718cdb7257d3807225c429b73823
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer16Resource.java 8cb7997305f1344429c5b256bea35878137bb5a3
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java cc623bfab61f732a4310e3c6c93a51bc36a463b9
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 3dc527e93d82733823f4e8fddb242d698c21629f
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56Resource.java a78ed819bdeb4878850989915a7280b0639e3ab6
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56SP2Resource.java 9e7d5dd09d0c1a1d18c6c348ce098218933d18ed
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer600Resource.java 021b9cbd4dc7ed4a5041c69aa55f29daa732f52b
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer602Resource.java 5c9bfbb5952008b332900cd7af21671f7dc465a5
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer610Resource.java 0c3e1e9660abdbfee1dcfe58c62145cbe0e06c9b
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer620Resource.java c10dc1e90cbce2ff41cc62e2120f5e23931a4207
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer620SP1Resource.java 4f04961e35742d7e846cec47725551d67b704bfc
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/Xenserver625Resource.java 40143646f7744e05e2ca009d99d53973ceaf58ee
Diff: https://reviews.apache.org/r/21087/diff/
Testing
-------
1. Local testing on XenServer 6.0.2
2. Successfully got up system VMs
3. Successfully created a CentOS VM
4. Created VM snapshot and reverted to snapshot
5. Manipulated guest_os_hypervisor table for mapping, and checked for correct propagation of platform emulator.
Thanks,
Amogh Vasekar
Re: Review Request 21087: Remove hard-coding for platform emulators in Xen
Server
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21087/#review42431
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On May 6, 2014, 10:45 p.m., Amogh Vasekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21087/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 10:45 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6358
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6358
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> As a part of supporting dynamic guest OS defined by user, removing the hard-coded dependencies.
> This patch is for XenServer
>
>
> Diffs
> -----
>
> api/src/com/cloud/agent/api/to/VirtualMachineTO.java bbd83852abf840ab5d93f53ad0c71e61491b2dda
> core/src/com/cloud/agent/api/VMSnapshotBaseCommand.java d2abd54e0407ab597636d9c9d5a596e55f987108
> engine/storage/snapshot/src/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java e86bd23b0500f25268a603a7c41e8e00d18957d2
> engine/storage/snapshot/test/src/VMSnapshotStrategyTest.java 9eaa7e19c134caf0633bb9099c5f858075fddba7
> engine/storage/src/org/apache/cloudstack/storage/helper/HypervisorHelperImpl.java b41c1fa14ac77cffa53ce5ae2aec6d9bea9cd649
> plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 89e4ab5d94b61cc6acdefc8102da4a33dbbf23b5
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java ad3797306c92d80d929a1e09b46b471231baa6c0
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpOssResource.java 4a69d3aececd718cdb7257d3807225c429b73823
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer16Resource.java 8cb7997305f1344429c5b256bea35878137bb5a3
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java cc623bfab61f732a4310e3c6c93a51bc36a463b9
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 3dc527e93d82733823f4e8fddb242d698c21629f
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56Resource.java a78ed819bdeb4878850989915a7280b0639e3ab6
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56SP2Resource.java 9e7d5dd09d0c1a1d18c6c348ce098218933d18ed
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer600Resource.java 021b9cbd4dc7ed4a5041c69aa55f29daa732f52b
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer602Resource.java 5c9bfbb5952008b332900cd7af21671f7dc465a5
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer610Resource.java 0c3e1e9660abdbfee1dcfe58c62145cbe0e06c9b
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer620Resource.java c10dc1e90cbce2ff41cc62e2120f5e23931a4207
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer620SP1Resource.java 4f04961e35742d7e846cec47725551d67b704bfc
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/Xenserver625Resource.java 40143646f7744e05e2ca009d99d53973ceaf58ee
>
> Diff: https://reviews.apache.org/r/21087/diff/
>
>
> Testing
> -------
>
> 1. Local testing on XenServer 6.0.2
> 2. Successfully got up system VMs
> 3. Successfully created a CentOS VM
> 4. Created VM snapshot and reverted to snapshot
> 5. Manipulated guest_os_hypervisor table for mapping, and checked for correct propagation of platform emulator.
>
>
> Thanks,
>
> Amogh Vasekar
>
>
Re: Review Request 21087: Remove hard-coding for platform emulators in Xen
Server
Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21087/
-----------------------------------------------------------
(Updated May 6, 2014, 10:45 p.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
Cleanly applying patch
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6358
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6358
Repository: cloudstack-git
Description
-------
As a part of supporting dynamic guest OS defined by user, removing the hard-coded dependencies.
This patch is for XenServer
Diffs (updated)
-----
api/src/com/cloud/agent/api/to/VirtualMachineTO.java bbd83852abf840ab5d93f53ad0c71e61491b2dda
core/src/com/cloud/agent/api/VMSnapshotBaseCommand.java d2abd54e0407ab597636d9c9d5a596e55f987108
engine/storage/snapshot/src/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java e86bd23b0500f25268a603a7c41e8e00d18957d2
engine/storage/snapshot/test/src/VMSnapshotStrategyTest.java 9eaa7e19c134caf0633bb9099c5f858075fddba7
engine/storage/src/org/apache/cloudstack/storage/helper/HypervisorHelperImpl.java b41c1fa14ac77cffa53ce5ae2aec6d9bea9cd649
plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 89e4ab5d94b61cc6acdefc8102da4a33dbbf23b5
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java ad3797306c92d80d929a1e09b46b471231baa6c0
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpOssResource.java 4a69d3aececd718cdb7257d3807225c429b73823
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer16Resource.java 8cb7997305f1344429c5b256bea35878137bb5a3
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java cc623bfab61f732a4310e3c6c93a51bc36a463b9
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 3dc527e93d82733823f4e8fddb242d698c21629f
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56Resource.java a78ed819bdeb4878850989915a7280b0639e3ab6
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56SP2Resource.java 9e7d5dd09d0c1a1d18c6c348ce098218933d18ed
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer600Resource.java 021b9cbd4dc7ed4a5041c69aa55f29daa732f52b
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer602Resource.java 5c9bfbb5952008b332900cd7af21671f7dc465a5
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer610Resource.java 0c3e1e9660abdbfee1dcfe58c62145cbe0e06c9b
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer620Resource.java c10dc1e90cbce2ff41cc62e2120f5e23931a4207
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer620SP1Resource.java 4f04961e35742d7e846cec47725551d67b704bfc
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/Xenserver625Resource.java 40143646f7744e05e2ca009d99d53973ceaf58ee
Diff: https://reviews.apache.org/r/21087/diff/
Testing
-------
1. Local testing on XenServer 6.0.2
2. Successfully got up system VMs
3. Successfully created a CentOS VM
4. Created VM snapshot and reverted to snapshot
5. Manipulated guest_os_hypervisor table for mapping, and checked for correct propagation of platform emulator.
Thanks,
Amogh Vasekar
Re: Review Request 21087: Remove hard-coding for platform emulators in Xen
Server
Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21087/
-----------------------------------------------------------
(Updated May 5, 2014, 7:02 p.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
Cleaning up some code
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6358
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6358
Repository: cloudstack-git
Description
-------
As a part of supporting dynamic guest OS defined by user, removing the hard-coded dependencies.
This patch is for XenServer
Diffs (updated)
-----
api/src/com/cloud/agent/api/to/VirtualMachineTO.java bbd83852abf840ab5d93f53ad0c71e61491b2dda
core/src/com/cloud/agent/api/VMSnapshotBaseCommand.java d2abd54e0407ab597636d9c9d5a596e55f987108
engine/storage/snapshot/src/org/apache/cloudstack/storage/vmsnapshot/DefaultVMSnapshotStrategy.java e86bd23b0500f25268a603a7c41e8e00d18957d2
engine/storage/snapshot/test/src/VMSnapshotStrategyTest.java 9eaa7e19c134caf0633bb9099c5f858075fddba7
engine/storage/src/org/apache/cloudstack/storage/helper/HypervisorHelperImpl.java b41c1fa14ac77cffa53ce5ae2aec6d9bea9cd649
plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java 89e4ab5d94b61cc6acdefc8102da4a33dbbf23b5
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java ad3797306c92d80d929a1e09b46b471231baa6c0
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpOssResource.java 4a69d3aececd718cdb7257d3807225c429b73823
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer16Resource.java 8cb7997305f1344429c5b256bea35878137bb5a3
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java cc623bfab61f732a4310e3c6c93a51bc36a463b9
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 3dc527e93d82733823f4e8fddb242d698c21629f
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56Resource.java a78ed819bdeb4878850989915a7280b0639e3ab6
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56SP2Resource.java 9e7d5dd09d0c1a1d18c6c348ce098218933d18ed
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer600Resource.java 021b9cbd4dc7ed4a5041c69aa55f29daa732f52b
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer602Resource.java 5c9bfbb5952008b332900cd7af21671f7dc465a5
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer610Resource.java 0c3e1e9660abdbfee1dcfe58c62145cbe0e06c9b
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer620Resource.java c10dc1e90cbce2ff41cc62e2120f5e23931a4207
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer620SP1Resource.java 4f04961e35742d7e846cec47725551d67b704bfc
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/Xenserver625Resource.java 40143646f7744e05e2ca009d99d53973ceaf58ee
Diff: https://reviews.apache.org/r/21087/diff/
Testing
-------
1. Local testing on XenServer 6.0.2
2. Successfully got up system VMs
3. Successfully created a CentOS VM
4. Created VM snapshot and reverted to snapshot
5. Manipulated guest_os_hypervisor table for mapping, and checked for correct propagation of platform emulator.
Thanks,
Amogh Vasekar