[jira] [Commented] (TEZ-4169) Remove unused transitive compile time jackson dependencies

["TezQA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100048#comment-17100048 ] 

TezQA commented on TEZ-4169:
----------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 10m  1s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 36s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m  5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  2m  5s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 55s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 52s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 26s{color} | {color:green} tez-protobuf-history-plugin in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  3m 47s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 38s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 33m  8s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | tez.dag.api.client.TestTimelineReaderFactory |
|   | tez.common.TestTezCommonUtils |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/PreCommit-TEZ-Build/389/artifact/out/Dockerfile |
| JIRA Issue | TEZ-4169 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13002093/TEZ-4169.01.patch |
| Optional Tests | dupname asflicense javac javadoc unit xml compile |
| uname | Linux 0a886933cedd 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 4e4b8e5 |
| Default Java | 1.8.0_252 |
| unit | https://builds.apache.org/job/PreCommit-TEZ-Build/389/artifact/out/patch-unit-root.txt |
|  Test Results | https://builds.apache.org/job/PreCommit-TEZ-Build/389/testReport/ |
| Max. process+thread count | 297 (vs. ulimit of 5500) |
| modules | C: tez-plugins/tez-protobuf-history-plugin . U: . |
| Console output | https://builds.apache.org/job/PreCommit-TEZ-Build/389/console |
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |


This message was automatically generated.



> Remove unused transitive compile time jackson dependencies
> ----------------------------------------------------------
>
>                 Key: TEZ-4169
>                 URL: https://issues.apache.org/jira/browse/TEZ-4169
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>         Attachments: TEZ-4169.01.patch
>
>
> Tez has many occurrences of jackson dependencies in its dep tree, however none of them is direct:
> {code}
>  lbodor@HW12459  ~/apache/tez   master  mvn dependency:tree | grep jackson | wc -l
>      204
> {code}
> This is misleading, because tez protobuf history plugin does depend on jackson mapper, so it should have jackson as a direct dependency.
> Similarly to other dependencies, transitive deps can also trigger security scan alerts, complaining about outdated jackson dependencies. It would be cleaner to:
> 1. completely remove unused transitive jackson depdendencies and re-add them in test scope where it's needed for clarity's sake
> 2. include jackson as direct dependency where it's used (this could move focus to that place when there is a need for an upgrade)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)