[jira] [Commented] (FLINK-4610) Replace keySet/getValue with entrySet in UdfAnalyzerUtils

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15479259#comment-15479259 ] 

ASF GitHub Bot commented on FLINK-4610:
---------------------------------------

GitHub user apivovarov opened a pull request:

    https://github.com/apache/flink/pull/2491

    [FLINK-4610] Replace keySet/getValue with entrySet in UdfAnalyzerUtils

    https://issues.apache.org/jira/browse/FLINK-4610

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apivovarov/flink FLINK-4610

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2491.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2491
    
----
commit 7440989c09fae5325dbb3cebf0cf9d10f59dcbdd
Author: Alexander Pivovarov <ap...@gmail.com>
Date:   2016-09-10T06:10:12Z

    [FLINK-4610] Replace keySet/getValue with entrySet in UdfAnalyzerUtils

----


> Replace keySet/getValue with entrySet in UdfAnalyzerUtils
> ---------------------------------------------------------
>
>                 Key: FLINK-4610
>                 URL: https://issues.apache.org/jira/browse/FLINK-4610
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API
>    Affects Versions: 1.1.2
>            Reporter: Alexander Pivovarov
>            Priority: Minor
>
> Map.keySet + getValue combination is not very efficient
> It can be replaced with Map.entrySet to avoid values lookup
> Also MapEntry allows to modify MapEntry value while iterating thought the map using entrySet.iterator



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)