[GitHub] [openwhisk] rabbah commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys
URL: https://github.com/apache/openwhisk/pull/4855#discussion_r391146899
 
 

 ##########
 File path: core/controller/src/main/scala/org/apache/openwhisk/core/controller/actions/PrimitiveActions.scala
 ##########
 @@ -179,6 +179,7 @@ protected[actions] trait PrimitiveActions {
       waitForResponse.isDefined,
       args,
       action.parameters.initParameters,
+      action.parameters.lockedParameters(payload.map(_.fields.keySet).getOrElse(Set.empty)),
 
 Review comment:
   here, we exclude parameters that are overridden from the content body.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services