[GitHub] [trafficserver] randall commented on a change in pull request #8274: Use better done file locations for some AuTests

[GitBox <gi...@apache.org>]

randall commented on a change in pull request #8274:
URL: https://github.com/apache/trafficserver/pull/8274#discussion_r695070554



##########
File path: tests/gold_tests/continuations/double_h2.test.py
##########
@@ -109,9 +109,13 @@
 
 def make_done_stat_ready(tsenv):
     def done_stat_ready(process, hasRunFor, **kw):
-        retval = subprocess.run("traffic_ctl metric get continuations_verify.test.done > done  2> /dev/null", shell=True, env=tsenv)
+        done_file = os.path.join(process.RunDirectory, "continuations_verify.done")
+        retval = subprocess.run(

Review comment:
       Or how about getting rid of the redirection/grep and doing it in pure python?
   
   eg
   ```
      retval = subprocess.run("traffic_ctl metric get continuations_verify.test.done", shell=True, capture_output=True, text=True, env=tsenv)
          return retval.returncode == 0 and '1' in retval.stdout
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org