You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/14 01:14:29 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #32541: [SPARK-34764][UI][FOLLOW-UP] Fix indentation for JavaScript linter
HyukjinKwon opened a new pull request #32541:
URL: https://github.com/apache/spark/pull/32541
### What changes were proposed in this pull request?
This PR is a followup of https://github.com/apache/spark/pull/32436 which broke JavaScript linter. There was a logical conflict - the linter was added after the last successful test run in that PR.
```
added 118 packages in 1.482s
/__w/spark/spark/core/src/main/resources/org/apache/spark/ui/static/executorspage.js
34:41 error 'type' is defined but never used. Allowed unused args must match /^_ignored_.*/u no-unused-vars
34:47 error 'row' is defined but never used. Allowed unused args must match /^_ignored_.*/u no-unused-vars
35:1 error Expected indentation of 2 spaces but found 4 indent
36:1 error Expected indentation of 4 spaces but found 7 indent
37:1 error Expected indentation of 2 spaces but found 4 indent
38:1 error Expected indentation of 4 spaces but found 7 indent
39:1 error Expected indentation of 2 spaces but found 4 indent
556:1 error Expected indentation of 14 spaces but found 16 indent
557:1 error Expected indentation of 14 spaces but found 16 indent
```
### Why are the changes needed?
To recover the build
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
Manually tested:
```bash
./dev/lint-js
lint-js checks passed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32541: [SPARK-34764][UI][FOLLOW-UP] Fix indentation and missing arguments for JavaScript linter
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32541:
URL: https://github.com/apache/spark/pull/32541#issuecomment-840990663
Thanks all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32541: [SPARK-34764][UI][FOLLOW-UP] Fix indentation and missing arguments for JavaScript linter
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32541:
URL: https://github.com/apache/spark/pull/32541#issuecomment-840934589
**[Test build #138534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138534/testReport)** for PR 32541 at commit [`69a08ac`](https://github.com/apache/spark/commit/69a08ac03e68ed26b19faa4ba2d34fb3d8a486d9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #32541: [SPARK-34764][UI][FOLLOW-UP] Fix indentation and missing arguments for JavaScript linter
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #32541:
URL: https://github.com/apache/spark/pull/32541#issuecomment-840984681
JavaScript linter passed. Merging to `master`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32541: [SPARK-34764][UI][FOLLOW-UP] Fix indentation for JavaScript linter
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32541:
URL: https://github.com/apache/spark/pull/32541#issuecomment-840930322
cc @holdenk @sarutak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32541: [SPARK-34764][UI][FOLLOW-UP] Fix indentation and missing arguments for JavaScript linter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32541:
URL: https://github.com/apache/spark/pull/32541#issuecomment-840963541
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43056/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32541: [SPARK-34764][UI][FOLLOW-UP] Fix indentation and missing arguments for JavaScript linter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32541:
URL: https://github.com/apache/spark/pull/32541#issuecomment-840959852
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43056/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32541: [SPARK-34764][UI][FOLLOW-UP] Fix indentation and missing arguments for JavaScript linter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32541:
URL: https://github.com/apache/spark/pull/32541#issuecomment-840998179
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138534/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak closed pull request #32541: [SPARK-34764][UI][FOLLOW-UP] Fix indentation and missing arguments for JavaScript linter
Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #32541:
URL: https://github.com/apache/spark/pull/32541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32541: [SPARK-34764][UI][FOLLOW-UP] Fix indentation and missing arguments for JavaScript linter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32541:
URL: https://github.com/apache/spark/pull/32541#issuecomment-840934589
**[Test build #138534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138534/testReport)** for PR 32541 at commit [`69a08ac`](https://github.com/apache/spark/commit/69a08ac03e68ed26b19faa4ba2d34fb3d8a486d9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32541: [SPARK-34764][UI][FOLLOW-UP] Fix indentation and missing arguments for JavaScript linter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32541:
URL: https://github.com/apache/spark/pull/32541#issuecomment-840963541
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43056/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32541: [SPARK-34764][UI][FOLLOW-UP] Fix indentation and missing arguments for JavaScript linter
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32541:
URL: https://github.com/apache/spark/pull/32541#issuecomment-840996613
**[Test build #138534 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138534/testReport)** for PR 32541 at commit [`69a08ac`](https://github.com/apache/spark/commit/69a08ac03e68ed26b19faa4ba2d34fb3d8a486d9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32541: [SPARK-34764][UI][FOLLOW-UP] Fix indentation and missing arguments for JavaScript linter
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32541:
URL: https://github.com/apache/spark/pull/32541#issuecomment-840998179
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138534/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org