You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/09 06:26:03 UTC

[GitHub] [hudi] yihua commented on a diff in pull request #5268: [HUDI-3807] Add a new config to control the use of metadata index in HoodieBloomIndex

yihua commented on code in PR #5268:
URL: https://github.com/apache/hudi/pull/5268#discussion_r846582646


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/bloom/SparkHoodieBloomIndexHelper.java:
##########
@@ -75,7 +80,9 @@ public static SparkHoodieBloomIndexHelper getInstance() {
         + config.getBloomIndexParallelism() + "}");
 
     JavaRDD<List<HoodieKeyLookupResult>> keyLookupResultRDD;
-    if (config.isMetadataBloomFilterIndexEnabled()) {
+    if (config.getBloomIndexUseMetadata()
+        && getCompletedMetadataPartitions(hoodieTable.getMetaClient().getTableConfig())

Review Comment:
   `HoodieTableMetadataUtil::getCompletedMetadataPartitions` is an existing API.  We can tackle this code cleanup in a separate PR: HUDI-3836.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org