You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kgyrtkirk (via GitHub)" <gi...@apache.org> on 2023/11/24 08:01:55 UTC
[I] Changing the queryFrameWork in Calcite*Tests may have sideeffects (druid)
kgyrtkirk opened a new issue, #15427:
URL: https://github.com/apache/druid/issues/15427
the method named `requireMergeBuffers(1)` ; changes the field `queryFramework` which may change the behaviour of later testcases
adding this testcase to `CalciteQueryTest` creates 2 failing tests
```java
@Test
public void testMergeBufferSettingHasSideEffect() {
requireMergeBuffers(1);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [I] Changing the queryFrameWork in Calcite*Tests may have sideeffects (druid)
Posted by "LakshSingla (via GitHub)" <gi...@apache.org>.
LakshSingla commented on issue #15427:
URL: https://github.com/apache/druid/issues/15427#issuecomment-1825289937
I have seen this issue. I attempted to solve it but the way merge buffers are wired, I wasn't able to find a simple fix for the same - I was able to create a new framework per test (which isn't ideal as it increased the test time by 10x)
I attempted to cache the num merge buffers currently being used, reset that int per test, and check the last test's merge buffers (we cached), and if the two mismatched, then call requireMergeBuffers(..) again. This would cause the merge buffers to increase when we call the requireMergeBuffers(..) code, and reset back to 0 the next test until we call it back again explicitly.
However, it didn't work as expected because of how the test framework was written.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [I] Changing the queryFrameWork in Calcite*Tests may have sideeffects (druid)
Posted by "LakshSingla (via GitHub)" <gi...@apache.org>.
LakshSingla closed issue #15427: Changing the queryFrameWork in Calcite*Tests may have sideeffects
URL: https://github.com/apache/druid/issues/15427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org