[GitHub] [iceberg] Fokko commented on a diff in pull request #7059: Flink: Bump to Flink 1.15.3

["Fokko (via GitHub)" <gi...@apache.org>]

Fokko commented on code in PR #7059:
URL: https://github.com/apache/iceberg/pull/7059#discussion_r1136938453


##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java:
##########
@@ -69,16 +73,20 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context context) {
     List<String> equalityColumns =
         tableSchema.getPrimaryKey().map(UniqueConstraint::getColumns).orElseGet(ImmutableList::of);
 
-    return (DataStreamSinkProvider)

Review Comment:
   That's a fair point. What you're saying is that the new version of Iceberg won't work with 1.15.0, 1.15.1, and 1.15.2 anymore, so we should not update. Makes sense to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org