You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/23 07:28:59 UTC
[GitHub] [shardingsphere] sandynz commented on a diff in pull request #20450: Add show migration source resource DistSQL and implementation
sandynz commented on code in PR #20450:
URL: https://github.com/apache/shardingsphere/pull/20450#discussion_r952247714
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/core/util/PipelineSchemaTableUtil.java:
##########
@@ -71,19 +72,18 @@ public static Map<String, List<String>> getSchemaTablesMapFromActual(final Pipel
}
/**
- * get default schema by connection.getSchema().
+ * Get default schema by connection.getSchema().
*
- * @param pipelineDataSourceConfig pipeline data source config
+ * @param dataSourceConfig pipeline data source config
* @return schema
*/
- public static String getDefaultSchema(final PipelineDataSourceConfiguration pipelineDataSourceConfig) {
- try (PipelineDataSourceWrapper dataSource = PipelineDataSourceFactory.newInstance(pipelineDataSourceConfig)) {
+ @SneakyThrows(SQLException.class)
Review Comment:
`@SneakyThrows(SQLException.class)` could be improved later, maybe we could throw SQLException on upper layer `createJobAndStart`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org