You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/01/11 23:18:31 UTC
[GitHub] [tinkerpop] phreed opened a new pull request #1544: Tinkerpop 2628
phreed opened a new pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544
There remain three modules whose tests do not pass.
``` <modules>
<module>gremlin-language</module>
<module>gremlin-shaded</module>
<module>gremlin-core</module>
<module>gremlin-annotations</module>
<module>gremlin-test</module>
<module>gremlin-groovy</module>
<module>tinkergraph-gremlin</module>
<!-- <module>gremlin-javascript</module>-->
<module>gremlin-python</module>
<module>gremlin-dotnet</module>
<!-- <module>hadoop-gremlin</module>-->
<!-- <module>spark-gremlin</module>-->
<module>neo4j-gremlin</module>
<module>sparql-gremlin</module>
<module>gremlin-driver</module>
<module>gremlin-console</module>
<module>gremlin-server</module>
<module>gremlin-archetype</module>
<module>gremlin-tools</module>
<module>gremlint</module>
</modules>
```
[INFO] Reactor Summary for Apache TinkerPop 3.6.0-SNAPSHOT:
[INFO]
[INFO] Apache TinkerPop ................................... SUCCESS [ 9.052 s]
[INFO] Apache TinkerPop :: Gremlin Language ............... SUCCESS [ 21.188 s]
[INFO] Apache TinkerPop :: Gremlin Shaded ................. SUCCESS [ 2.115 s]
[INFO] Apache TinkerPop :: Gremlin Core ................... SUCCESS [01:09 min]
[INFO] Apache TinkerPop :: Gremlin Annotations ............ SUCCESS [ 9.824 s]
[INFO] Apache TinkerPop :: Gremlin Test ................... SUCCESS [ 27.575 s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ............ SUCCESS [02:48 min]
[INFO] Apache TinkerPop :: Gremlin Groovy ................. SUCCESS [03:09 min]
[INFO] Apache TinkerPop :: Gremlin Python ................. SUCCESS [ 0.339 s]
[INFO] Apache TinkerPop :: Gremlin.Net .................... SUCCESS [ 1.644 s]
[INFO] Apache TinkerPop :: Gremlin.Net - Source ........... SUCCESS [ 1.272 s]
[INFO] Apache TinkerPop :: Gremlin.Net - Tests ............ SUCCESS [ 0.300 s]
[INFO] Apache TinkerPop :: Neo4j Gremlin .................. SUCCESS [ 4.169 s]
[INFO] Apache TinkerPop :: SPARQL Gremlin ................. SUCCESS [ 7.930 s]
[INFO] Apache TinkerPop :: Gremlin Driver ................. SUCCESS [ 46.333 s]
[INFO] Apache TinkerPop :: Gremlin Server ................. SUCCESS [01:32 min]
[INFO] Apache TinkerPop :: Gremlin Console ................ SUCCESS [ 33.061 s]
[INFO] Apache TinkerPop :: Gremlin Archetype .............. SUCCESS [ 0.240 s]
[INFO] Apache TinkerPop :: Archetype - TinkerGraph ........ SUCCESS [ 6.431 s]
[INFO] Apache TinkerPop :: Archetype - Server ............. SUCCESS [ 13.662 s]
[INFO] Apache TinkerPop :: Archetype - DSL ................ SUCCESS [ 7.316 s]
[INFO] Apache TinkerPop :: Gremlin Tools .................. SUCCESS [ 0.971 s]
[INFO] Apache TinkerPop :: Gremlin Benchmark .............. SUCCESS [ 17.050 s]
[INFO] Apache TinkerPop :: Gremlin Coverage ............... SUCCESS [ 0.814 s]
[INFO] Apache TinkerPop :: Gremlin IO Test ................ SUCCESS [ 42.285 s]
[INFO] Apache TinkerPop :: Gremlint ....................... SUCCESS [ 50.232 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:44 min
[INFO] Finished at: 2022-01-11T17:16:13-06:00
[INFO] ------------------------------------------------------------------------
```
Additional site configuration documentation for windows.
Windows 10 does not have standard package management.
I prefer chocolatey https://community.chocolatey.org/ .
* gremlin-javascript:
```powershell
choco install nodejs
npm install npx
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette closed pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
spmallette closed pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] phreed commented on a change in pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
phreed commented on a change in pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#discussion_r783333920
##########
File path: gremlin-dotnet/src/pom.xml
##########
@@ -53,16 +53,25 @@ limitations under the License.
<goal>execute</goal>
</goals>
<configuration>
+ <properties>
+ <property>
+ <name>projectBaseDir</name>
+ <value>${project.basedir}</value>
+ </property>
+ <property>
+ <name>mavenVersion</name>
+ <value>${project.version}</value>
+ </property>
+ </properties>
<scripts>
<script>
-def mavenVersion = "${project.version}"
-def file = new File("${project.basedir}/Gremlin.Net/Gremlin.Net.csproj")
+def file = new File(projectBaseDir,"Gremlin.Net/Gremlin.Net.csproj")
file.write(file.getText("UTF-8").replaceFirst(/<Version>(.*)<\/Version>/, "<Version>" + mavenVersion + "</Version>"))
-file = new File("${project.basedir}/Gremlin.Net.Template/Gremlin.Net.Template.csproj")
Review comment:
The issue arises from when the string interpolation happens. If the "${project.basedir}/..." is evaluated by maven then gradle sees the unescaped string and must parse it.
If the `<property>` approach is used, then the [gmavenplus-plugin|https://groovy.github.io/GMavenPlus/plugin-info.html] creates a gradle string variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] phreed commented on pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
phreed commented on pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#issuecomment-1012519074
Great, apparently I do not know how to do the rebasing and squashing. Do you have any instructions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] phreed edited a comment on pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
phreed edited a comment on pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#issuecomment-1012519074
Great, apparently I do not know how to do the rebasing and squashing. Do you have any instructions?
I made another PR https://github.com/apache/tinkerpop/pull/1548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] phreed commented on a change in pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
phreed commented on a change in pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#discussion_r783328256
##########
File path: gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetricsTest.java
##########
@@ -59,6 +59,8 @@ public void shouldPrintIndentationsCorrectly() {
" backend-query 0.000\n" +
" \\_query=gIndex:slice-query\n" +
" >TOTAL - - 0.000 -";
- assertEquals(expectedOutput, profile.toString());
+ assertEquals("traversal metrics",
Review comment:
Yes, that would be clearer. Do you want me to make the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] phreed commented on a change in pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
phreed commented on a change in pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#discussion_r783326612
##########
File path: gremlin-console/bin/gremlin.sh
##########
@@ -1 +1,17 @@
+
Review comment:
Yes, the rat plugin was complaining about the license header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] phreed edited a comment on pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
phreed edited a comment on pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#issuecomment-1012519074
Great, apparently I do not know how to do the rebasing and squashing. Do you have any instructions?
Do I need to make another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] phreed commented on a change in pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
phreed commented on a change in pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#discussion_r783333920
##########
File path: gremlin-dotnet/src/pom.xml
##########
@@ -53,16 +53,25 @@ limitations under the License.
<goal>execute</goal>
</goals>
<configuration>
+ <properties>
+ <property>
+ <name>projectBaseDir</name>
+ <value>${project.basedir}</value>
+ </property>
+ <property>
+ <name>mavenVersion</name>
+ <value>${project.version}</value>
+ </property>
+ </properties>
<scripts>
<script>
-def mavenVersion = "${project.version}"
-def file = new File("${project.basedir}/Gremlin.Net/Gremlin.Net.csproj")
+def file = new File(projectBaseDir,"Gremlin.Net/Gremlin.Net.csproj")
file.write(file.getText("UTF-8").replaceFirst(/<Version>(.*)<\/Version>/, "<Version>" + mavenVersion + "</Version>"))
-file = new File("${project.basedir}/Gremlin.Net.Template/Gremlin.Net.Template.csproj")
Review comment:
The issue arises from when the string interpolation happens. If the "${project.basedir}/..." is evaluated by maven then gradle sees the unescaped string and must parse it.
If the `<property>` approach is used, then the [gmavenplus-plugin](https://groovy.github.io/GMavenPlus/plugin-info.html) presents gradle with a string variable (i.e. no string interpolation).
Here is an example https://github.com/groovy/GMavenPlus/wiki/Examples#execute-scripts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] phreed commented on a change in pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
phreed commented on a change in pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#discussion_r783333920
##########
File path: gremlin-dotnet/src/pom.xml
##########
@@ -53,16 +53,25 @@ limitations under the License.
<goal>execute</goal>
</goals>
<configuration>
+ <properties>
+ <property>
+ <name>projectBaseDir</name>
+ <value>${project.basedir}</value>
+ </property>
+ <property>
+ <name>mavenVersion</name>
+ <value>${project.version}</value>
+ </property>
+ </properties>
<scripts>
<script>
-def mavenVersion = "${project.version}"
-def file = new File("${project.basedir}/Gremlin.Net/Gremlin.Net.csproj")
+def file = new File(projectBaseDir,"Gremlin.Net/Gremlin.Net.csproj")
file.write(file.getText("UTF-8").replaceFirst(/<Version>(.*)<\/Version>/, "<Version>" + mavenVersion + "</Version>"))
-file = new File("${project.basedir}/Gremlin.Net.Template/Gremlin.Net.Template.csproj")
Review comment:
The issue arises from when the string interpolation happens. If the "${project.basedir}/..." is evaluated by maven then gradle sees the unescaped string and must parse it.
If the `<property>` approach is used, then the [gmavenplus-plugin](https://groovy.github.io/GMavenPlus/plugin-info.html) a gradle string variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] phreed commented on a change in pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
phreed commented on a change in pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#discussion_r783365507
##########
File path: gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetricsTest.java
##########
@@ -47,18 +47,19 @@ public void shouldPrintIndentationsCorrectly() {
childMetrics.addNested(backendMetrics);
final DefaultTraversalMetrics profile = new DefaultTraversalMetrics(100, metrics);
- final String expectedOutput = "Traversal Metrics\n" +
- "Step Count Traversers Time (ms) % Dur\n" +
- "=============================================================================================================\n" +
- "GraphStep 0.000\n" +
- " GraphQuery 0.000\n" +
- " \\_condition=name = Bob\n" +
- " AND-Query 0.000\n" +
- " \\_index=gIndex\n" +
- " \\_query-hint=ZSORTED\n" +
- " backend-query 0.000\n" +
- " \\_query=gIndex:slice-query\n" +
+ final String LS = System.lineSeparator();
+ final String expectedOutput = "Traversal Metrics" + LS +
+ "Step Count Traversers Time (ms) % Dur" + LS +
+ "=============================================================================================================" + LS +
+ "GraphStep 0.000" + LS +
+ " GraphQuery 0.000" + LS +
+ " \\_condition=name = Bob" + LS +
+ " AND-Query 0.000" + LS +
+ " \\_index=gIndex" + LS +
+ " \\_query-hint=ZSORTED" + LS +
+ " backend-query 0.000" + LS +
+ " \\_query=gIndex:slice-query" + LS +
" >TOTAL - - 0.000 -";
- assertEquals(expectedOutput, profile.toString());
Review comment:
As you recommended the expected-output is modified to include the system-line-separator rather than "repairing" the actual profile. I also added a title to the assertEquals call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on a change in pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
spmallette commented on a change in pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#discussion_r783198125
##########
File path: gremlin-console/bin/gremlin.sh
##########
@@ -1 +1,17 @@
+
Review comment:
was the rat plugin complaining about this license header? this pattern should be ignored. maybe there is something in our configuration of the rat plugin that doesn't work right for windows? thoughts?
https://github.com/apache/tinkerpop/blob/master/pom.xml#L403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on a change in pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
spmallette commented on a change in pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#discussion_r783447345
##########
File path: pom.xml
##########
@@ -400,7 +400,7 @@ limitations under the License.
<exclude>.repository/**</exclude>
<exclude>**/target/**</exclude>
<exclude>data/*.txt</exclude>
- <exclude>bin/gremlin.sh</exclude>
+ <exclude>**/bin/gremlin.sh</exclude>
Review comment:
former was correct i believe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#issuecomment-1013083869
merged on #1548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on a change in pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
spmallette commented on a change in pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#discussion_r783202225
##########
File path: gremlin-dotnet/src/pom.xml
##########
@@ -53,16 +53,25 @@ limitations under the License.
<goal>execute</goal>
</goals>
<configuration>
+ <properties>
+ <property>
+ <name>projectBaseDir</name>
+ <value>${project.basedir}</value>
+ </property>
+ <property>
+ <name>mavenVersion</name>
+ <value>${project.version}</value>
+ </property>
+ </properties>
<scripts>
<script>
-def mavenVersion = "${project.version}"
-def file = new File("${project.basedir}/Gremlin.Net/Gremlin.Net.csproj")
+def file = new File(projectBaseDir,"Gremlin.Net/Gremlin.Net.csproj")
file.write(file.getText("UTF-8").replaceFirst(/<Version>(.*)<\/Version>/, "<Version>" + mavenVersion + "</Version>"))
-file = new File("${project.basedir}/Gremlin.Net.Template/Gremlin.Net.Template.csproj")
Review comment:
Interesting. Could you mention what was happening here? Why does using a `<property>` work but the variable substitution not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on a change in pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
spmallette commented on a change in pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#discussion_r783446376
##########
File path: gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetricsTest.java
##########
@@ -59,6 +59,8 @@ public void shouldPrintIndentationsCorrectly() {
" backend-query 0.000\n" +
" \\_query=gIndex:slice-query\n" +
" >TOTAL - - 0.000 -";
- assertEquals(expectedOutput, profile.toString());
+ assertEquals("traversal metrics",
Review comment:
that would be great - yes please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] phreed commented on a change in pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
phreed commented on a change in pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#discussion_r783367868
##########
File path: pom.xml
##########
@@ -400,7 +400,7 @@ limitations under the License.
<exclude>.repository/**</exclude>
<exclude>**/target/**</exclude>
<exclude>data/*.txt</exclude>
- <exclude>bin/gremlin.sh</exclude>
+ <exclude>**/bin/gremlin.sh</exclude>
Review comment:
The file is not located in the root directory. I was not sure if the intent was to ignore any `gremlin.sh` or just the specific version. I assumed the former.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on a change in pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
spmallette commented on a change in pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#discussion_r783201014
##########
File path: gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetricsTest.java
##########
@@ -59,6 +59,8 @@ public void shouldPrintIndentationsCorrectly() {
" backend-query 0.000\n" +
" \\_query=gIndex:slice-query\n" +
" >TOTAL - - 0.000 -";
- assertEquals(expectedOutput, profile.toString());
+ assertEquals("traversal metrics",
Review comment:
good find, though I think it would be better to replace the hardcoded "\n" in the `expectedOutput` with `System.lineSeparator()` that way the test is just written properly from the ground up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] phreed commented on a change in pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
phreed commented on a change in pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#discussion_r783333920
##########
File path: gremlin-dotnet/src/pom.xml
##########
@@ -53,16 +53,25 @@ limitations under the License.
<goal>execute</goal>
</goals>
<configuration>
+ <properties>
+ <property>
+ <name>projectBaseDir</name>
+ <value>${project.basedir}</value>
+ </property>
+ <property>
+ <name>mavenVersion</name>
+ <value>${project.version}</value>
+ </property>
+ </properties>
<scripts>
<script>
-def mavenVersion = "${project.version}"
-def file = new File("${project.basedir}/Gremlin.Net/Gremlin.Net.csproj")
+def file = new File(projectBaseDir,"Gremlin.Net/Gremlin.Net.csproj")
file.write(file.getText("UTF-8").replaceFirst(/<Version>(.*)<\/Version>/, "<Version>" + mavenVersion + "</Version>"))
-file = new File("${project.basedir}/Gremlin.Net.Template/Gremlin.Net.Template.csproj")
Review comment:
The issue arises from when the string interpolation happens. If the "${project.basedir}/..." is evaluated by maven then gradle sees the unescaped string and must parse it.
If the `<property>` approach is used, then the [gmavenplus-plugin](https://groovy.github.io/GMavenPlus/plugin-info.html) presents gradle with a string variable (i.e. no string interpolation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on a change in pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
spmallette commented on a change in pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#discussion_r783447030
##########
File path: gremlin-dotnet/src/pom.xml
##########
@@ -53,16 +53,25 @@ limitations under the License.
<goal>execute</goal>
</goals>
<configuration>
+ <properties>
+ <property>
+ <name>projectBaseDir</name>
+ <value>${project.basedir}</value>
+ </property>
+ <property>
+ <name>mavenVersion</name>
+ <value>${project.version}</value>
+ </property>
+ </properties>
<scripts>
<script>
-def mavenVersion = "${project.version}"
-def file = new File("${project.basedir}/Gremlin.Net/Gremlin.Net.csproj")
+def file = new File(projectBaseDir,"Gremlin.Net/Gremlin.Net.csproj")
file.write(file.getText("UTF-8").replaceFirst(/<Version>(.*)<\/Version>/, "<Version>" + mavenVersion + "</Version>"))
-file = new File("${project.basedir}/Gremlin.Net.Template/Gremlin.Net.Template.csproj")
Review comment:
that makes sense. it will definitely be crucial that we get that Windows CI build going or we'll mess that up again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1544: Tinkerpop 2628
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1544:
URL: https://github.com/apache/tinkerpop/pull/1544#issuecomment-1012269091
This is looking pretty good to me now. Would you mind rebasing and squashing down your commits to just one to make the history a bit cleaner?
Aside from that VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org