[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2840: Expose ArrowNativeTypeOp trait to make it useful for type bound

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2840:
URL: https://github.com/apache/arrow-rs/pull/2840#discussion_r989796756


##########
arrow/src/datatypes/native.rs:
##########
@@ -16,114 +16,113 @@
 // under the License.
 
 use crate::error::{ArrowError, Result};
+pub use arrow_array::ArrowPrimitiveType;
 pub use arrow_buffer::{ArrowNativeType, ToByteSlice};
 use half::f16;
 use num::Zero;
+use std::ops::{Add, Div, Mul, Rem, Sub};
 
-pub use arrow_array::ArrowPrimitiveType;
+mod private {

Review Comment:
   As ArrowNativeType is sealed, we technically don't need this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org