You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2019/06/19 13:30:00 UTC
[jira] [Commented] (HIVE-21868) Vectorize CAST...FORMAT

    [ https://issues.apache.org/jira/browse/HIVE-21868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867615#comment-16867615 ] 

Hive QA commented on HIVE-21868:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 50s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  7m 35s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m  0s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 35s{color} | {color:blue} common in master has 62 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  5s{color} | {color:blue} ql in master has 2253 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 29s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 25s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 13s{color} | {color:red} common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 47s{color} | {color:red} ql: The patch generated 9 new + 495 unchanged - 1 fixed = 504 total (was 496) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m  0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  4m 20s{color} | {color:red} ql generated 35 new + 2231 unchanged - 22 fixed = 2266 total (was 2253) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 52s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastDateToCharWithFormat defines non-transient non-serializable instance field formatter  In CastDateToCharWithFormat.java:instance field formatter  In CastDateToCharWithFormat.java |
|  |  Found reliance on default encoding in org.apache.hadoop.hive.ql.exec.vector.expressions.CastDateToString.sqlFormat(BytesColumnVector, long[], int, HiveSqlDateTimeFormatter):in org.apache.hadoop.hive.ql.exec.vector.expressions.CastDateToString.sqlFormat(BytesColumnVector, long[], int, HiveSqlDateTimeFormatter): String.getBytes()  At CastDateToString.java:[line 67] |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastDateToStringWithFormat defines non-transient non-serializable instance field sqlFormatter  In CastDateToStringWithFormat.java:instance field sqlFormatter  In CastDateToStringWithFormat.java |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastDateToVarCharWithFormat defines non-transient non-serializable instance field formatter  In CastDateToVarCharWithFormat.java:instance field formatter  In CastDateToVarCharWithFormat.java |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastStringToDateWithFormat defines non-transient non-serializable instance field formatter  In CastStringToDateWithFormat.java:instance field formatter  In CastStringToDateWithFormat.java |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastStringToTimestampWithFormat defines non-transient non-serializable instance field formatter  In CastStringToTimestampWithFormat.java:instance field formatter  In CastStringToTimestampWithFormat.java |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastTimestampToCharWithFormat defines non-transient non-serializable instance field formatter  In CastTimestampToCharWithFormat.java:instance field formatter  In CastTimestampToCharWithFormat.java |
|  |  Found reliance on default encoding in org.apache.hadoop.hive.ql.exec.vector.expressions.CastTimestampToString.sqlFormat(BytesColumnVector, TimestampColumnVector, int, HiveSqlDateTimeFormatter):in org.apache.hadoop.hive.ql.exec.vector.expressions.CastTimestampToString.sqlFormat(BytesColumnVector, TimestampColumnVector, int, HiveSqlDateTimeFormatter): String.getBytes()  At CastTimestampToString.java:[line 76] |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastTimestampToStringWithFormat defines non-transient non-serializable instance field formatter  In CastTimestampToStringWithFormat.java:instance field formatter  In CastTimestampToStringWithFormat.java |
|  |  Class org.apache.hadoop.hive.ql.exec.vector.expressions.CastTimestampToVarCharWithFormat defines non-transient non-serializable instance field formatter  In CastTimestampToVarCharWithFormat.java:instance field formatter  In CastTimestampToVarCharWithFormat.java |
|  |  Switch statement found in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.castExpression() where default case is missing  At HiveParser_IdentifiersParser.java:where default case is missing  At HiveParser_IdentifiersParser.java:[lines 3968-3976] |
|  |  Dead store to LA31_100 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 33396] |
|  |  Dead store to LA31_101 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 33409] |
|  |  Dead store to LA31_102 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 33422] |
|  |  Dead store to LA31_15 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 33292] |
|  |  Dead store to LA31_16 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 33305] |
|  |  Dead store to LA31_17 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 33318] |
|  |  Dead store to LA31_18 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 33331] |
|  |  Dead store to LA31_19 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 33344] |
|  |  Dead store to LA31_97 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 33357] |
|  |  Dead store to LA31_98 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 33370] |
|  |  Dead store to LA31_99 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA31.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 33383] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA32 be a _static_ inner class?  At HiveParser_IdentifiersParser.java:inner class?  At HiveParser_IdentifiersParser.java:[lines 33568-33581] |
|  |  Dead store to LA36_169 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA36.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA36.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 33868] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA38 be a _static_ inner class?  At HiveParser_IdentifiersParser.java:inner class?  At HiveParser_IdentifiersParser.java:[lines 35078-35091] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA47 be a _static_ inner class?  At HiveParser_IdentifiersParser.java:inner class?  At HiveParser_IdentifiersParser.java:[lines 35999-36012] |
|  |  Should org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA51 be a _static_ inner class?  At HiveParser_IdentifiersParser.java:inner class?  At HiveParser_IdentifiersParser.java:[lines 36488-36501] |
|  |  Dead store to LA54_48 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 36746] |
|  |  Dead store to LA54_56 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 36759] |
|  |  Dead store to LA54_57 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 36772] |
|  |  Dead store to LA54_58 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 36785] |
|  |  Dead store to LA54_59 in org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser$DFA54.specialStateTransition(int, IntStream)  At HiveParser_IdentifiersParser.java:[line 36798] |
|  |  Class org.apache.hadoop.hive.ql.udf.generic.GenericUDFCastFormat defines non-transient non-serializable instance field formatter  In GenericUDFCastFormat.java:instance field formatter  In GenericUDFCastFormat.java |
|  |  Class org.apache.hadoop.hive.ql.udf.generic.GenericUDFCastFormat defines non-transient non-serializable instance field inputOI  In GenericUDFCastFormat.java:instance field inputOI  In GenericUDFCastFormat.java |
|  |  Class org.apache.hadoop.hive.ql.udf.generic.GenericUDFCastFormat defines non-transient non-serializable instance field outputOI  In GenericUDFCastFormat.java:instance field outputOI  In GenericUDFCastFormat.java |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17650/dev-support/hive-personality.sh |
| git revision | master / 7416fac |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17650/yetus/diff-checkstyle-common.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17650/yetus/diff-checkstyle-ql.txt |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-17650/yetus/new-findbugs-ql.html |
| modules | C: common ql U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17650/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Vectorize CAST...FORMAT
> -----------------------
>
>                 Key: HIVE-21868
>                 URL: https://issues.apache.org/jira/browse/HIVE-21868
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Karen Coppage
>            Assignee: Karen Coppage
>            Priority: Major
>         Attachments: HIVE-21868.01.patch, HIVE-21868.01.patch
>
>
> Vectorize UDFs for CAST (<TIMESTAMP/DATE> AS STRING/CHAR/VARCHAR FORMAT <STRING>) and CAST (<STRING/CHAR/VARCHAR> AS TIMESTAMP/DATE FORMAT <STRING>).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)