You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@apache.org> on 2012/11/30 04:11:09 UTC
Review Request: FLUME-1755: Load balancing RPC client has issues with downed
hosts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8288/
-----------------------------------------------------------
Review request for Flume.
Description
-------
Patch to fix exception handling in Load balancing RPC client
This addresses bug FLUME-1755.
https://issues.apache.org/jira/browse/FLUME-1755
Diffs
-----
flume-ng-sdk/src/main/java/org/apache/flume/api/LoadBalancingRpcClient.java 42297c1
flume-ng-sdk/src/test/java/org/apache/flume/api/TestLoadBalancingRpcClient.java 49a69bf
Diff: https://reviews.apache.org/r/8288/diff/
Testing
-------
Added a unit test to exercise this case. Fails on current code base.
Thanks,
Mike Percy
Re: Review Request: FLUME-1755: Load balancing RPC client has issues with
downed hosts
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8288/#review14149
-----------------------------------------------------------
Ship it!
OK cool, I didn't see that such a small patch fixed the problem I see now!
- Brock Noland
On Nov. 30, 2012, 3:11 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8288/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2012, 3:11 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Patch to fix exception handling in Load balancing RPC client
>
>
> This addresses bug FLUME-1755.
> https://issues.apache.org/jira/browse/FLUME-1755
>
>
> Diffs
> -----
>
> flume-ng-sdk/src/main/java/org/apache/flume/api/LoadBalancingRpcClient.java 42297c1
> flume-ng-sdk/src/test/java/org/apache/flume/api/TestLoadBalancingRpcClient.java 49a69bf
>
> Diff: https://reviews.apache.org/r/8288/diff/
>
>
> Testing
> -------
>
> Added a unit test to exercise this case. Fails on current code base.
>
>
> Thanks,
>
> Mike Percy
>
>
Re: Review Request: FLUME-1755: Load balancing RPC client has issues with
downed hosts
Posted by Mike Percy <mp...@apache.org>.
> On Dec. 6, 2012, 10:12 p.m., Brock Noland wrote:
> > This looks great. I assume it's just waiting for the patch to make the unit test pass?
Na I mean the unit test fails unless this patch is applied :)
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8288/#review14110
-----------------------------------------------------------
On Nov. 30, 2012, 3:11 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8288/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2012, 3:11 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Patch to fix exception handling in Load balancing RPC client
>
>
> This addresses bug FLUME-1755.
> https://issues.apache.org/jira/browse/FLUME-1755
>
>
> Diffs
> -----
>
> flume-ng-sdk/src/main/java/org/apache/flume/api/LoadBalancingRpcClient.java 42297c1
> flume-ng-sdk/src/test/java/org/apache/flume/api/TestLoadBalancingRpcClient.java 49a69bf
>
> Diff: https://reviews.apache.org/r/8288/diff/
>
>
> Testing
> -------
>
> Added a unit test to exercise this case. Fails on current code base.
>
>
> Thanks,
>
> Mike Percy
>
>
Re: Review Request: FLUME-1755: Load balancing RPC client has issues with
downed hosts
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8288/#review14110
-----------------------------------------------------------
This looks great. I assume it's just waiting for the patch to make the unit test pass?
- Brock Noland
On Nov. 30, 2012, 3:11 a.m., Mike Percy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8288/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2012, 3:11 a.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Patch to fix exception handling in Load balancing RPC client
>
>
> This addresses bug FLUME-1755.
> https://issues.apache.org/jira/browse/FLUME-1755
>
>
> Diffs
> -----
>
> flume-ng-sdk/src/main/java/org/apache/flume/api/LoadBalancingRpcClient.java 42297c1
> flume-ng-sdk/src/test/java/org/apache/flume/api/TestLoadBalancingRpcClient.java 49a69bf
>
> Diff: https://reviews.apache.org/r/8288/diff/
>
>
> Testing
> -------
>
> Added a unit test to exercise this case. Fails on current code base.
>
>
> Thanks,
>
> Mike Percy
>
>