You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "David Reiss (JIRA)" <ji...@apache.org> on 2008/08/28 02:42:45 UTC
[jira] Created: (THRIFT-126) TMemoryBuffer for Erlang
TMemoryBuffer for Erlang
------------------------
Key: THRIFT-126
URL: https://issues.apache.org/jira/browse/THRIFT-126
Project: Thrift
Issue Type: New Feature
Components: Library (Erlang)
Reporter: David Reiss
Assignee: David Reiss
Priority: Minor
TMemoryBuffer is really helpful for testing protocol changes. I just implemented it for Erlang. Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-126) TMemoryBuffer for Erlang
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688833#action_12688833 ]
David Reiss commented on THRIFT-126:
------------------------------------
I just have it on the same branch as the patch for 127.
> TMemoryBuffer for Erlang
> ------------------------
>
> Key: THRIFT-126
> URL: https://issues.apache.org/jira/browse/THRIFT-126
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch, 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch
>
>
> TMemoryBuffer is really helpful for testing protocol changes. I just implemented it for Erlang. Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-126) TMemoryBuffer for Erlang
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669103#action_12669103 ]
David Reiss commented on THRIFT-126:
------------------------------------
Eugene Letuchy believed the "You can reply to this email to add a comment to the issue online." message sent by JIRA, and sent the following comments to the list.
Looks pretty good to me too. My quibbles:
- Should export new_transport_factory/1 for parity with other transports.
- This may be a micro-optimization, but I think a binary representation for the buffer might be more efficient: per http://erlang.org/doc/efficiency_guide/binaryhandling.html#4, appending to the back of a binary is optimized in R12B to avoid a copy. The benefit of the IO list on the wire is clear, but since this is an in-memory buffer, we don't get the savings of avoiding io_list_to_binary, but do pay the cost of additional cons cells for the intermediate io-list.
I've implemented #1 in the revised patch. I'm going to punt on #2 for now since this module is only used for test cases so far.
> TMemoryBuffer for Erlang
> ------------------------
>
> Key: THRIFT-126
> URL: https://issues.apache.org/jira/browse/THRIFT-126
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch, 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch
>
>
> TMemoryBuffer is really helpful for testing protocol changes. I just implemented it for Erlang. Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-126) TMemoryBuffer for Erlang
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-126.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.1
> TMemoryBuffer for Erlang
> ------------------------
>
> Key: THRIFT-126
> URL: https://issues.apache.org/jira/browse/THRIFT-126
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Fix For: 0.1
>
> Attachments: 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch, 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch
>
>
> TMemoryBuffer is really helpful for testing protocol changes. I just implemented it for Erlang. Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-126) TMemoryBuffer for Erlang
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-126:
-------------------------------
Attachment: 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch
> TMemoryBuffer for Erlang
> ------------------------
>
> Key: THRIFT-126
> URL: https://issues.apache.org/jira/browse/THRIFT-126
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch
>
>
> TMemoryBuffer is really helpful for testing protocol changes. I just implemented it for Erlang. Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-126) TMemoryBuffer for Erlang
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626389#action_12626389 ]
David Reiss commented on THRIFT-126:
------------------------------------
http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=4779890
> TMemoryBuffer for Erlang
> ------------------------
>
> Key: THRIFT-126
> URL: https://issues.apache.org/jira/browse/THRIFT-126
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
>
> TMemoryBuffer is really helpful for testing protocol changes. I just implemented it for Erlang. Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (THRIFT-126) TMemoryBuffer for Erlang
Posted by Eugene Letuchy <el...@facebook.com>.
Looks pretty good to me too. My quibbles:
- Should export new_transport_factory/1 for parity with other transports.
- This may be a micro-optimization, but I think a binary representation for
the buffer might be more efficient: per
http://erlang.org/doc/efficiency_guide/binaryhandling.html#4, appending to the
back of a binary is optimized in R12B to avoid a copy. The benefit of the IO
list on the wire is clear, but since this is an in-memory buffer, we don't get
the savings of avoiding io_list_to_binary, but do pay the cost of additional
cons cells for the intermediate io-list.
- Eugene
On 1/29/09 8:26 PM, Todd Lipcon (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/THRIFT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668741#action_12668741 ]
>
> Todd Lipcon commented on THRIFT-126:
> ------------------------------------
>
> lgtm except for a nitpick - it says thrift_framed_transport in the header at the top. No big deal but worth fixing before committing.
>
>> TMemoryBuffer for Erlang
>> ------------------------
>>
>> Key: THRIFT-126
>> URL: https://issues.apache.org/jira/browse/THRIFT-126
>> Project: Thrift
>> Issue Type: New Feature
>> Components: Library (Erlang)
>> Reporter: David Reiss
>> Assignee: David Reiss
>> Priority: Minor
>> Attachments: 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch
>>
>>
>> TMemoryBuffer is really helpful for testing protocol changes. I just implemented it for Erlang. Patch in a moment.
>
[jira] Commented: (THRIFT-126) TMemoryBuffer for Erlang
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668741#action_12668741 ]
Todd Lipcon commented on THRIFT-126:
------------------------------------
lgtm except for a nitpick - it says thrift_framed_transport in the header at the top. No big deal but worth fixing before committing.
> TMemoryBuffer for Erlang
> ------------------------
>
> Key: THRIFT-126
> URL: https://issues.apache.org/jira/browse/THRIFT-126
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch
>
>
> TMemoryBuffer is really helpful for testing protocol changes. I just implemented it for Erlang. Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-126) TMemoryBuffer for Erlang
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-126:
-------------------------------
Attachment: 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch
> TMemoryBuffer for Erlang
> ------------------------
>
> Key: THRIFT-126
> URL: https://issues.apache.org/jira/browse/THRIFT-126
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch, 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch
>
>
> TMemoryBuffer is really helpful for testing protocol changes. I just implemented it for Erlang. Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-126) TMemoryBuffer for Erlang
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688497#action_12688497 ]
Bryan Duxbury commented on THRIFT-126:
--------------------------------------
Anything we're waiting on to commit this issue?
> TMemoryBuffer for Erlang
> ------------------------
>
> Key: THRIFT-126
> URL: https://issues.apache.org/jira/browse/THRIFT-126
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
> Attachments: 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch, 0001-THRIFT-126.-erl-TMemoryBuffer-for-Erlang.patch
>
>
> TMemoryBuffer is really helpful for testing protocol changes. I just implemented it for Erlang. Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-126) TMemoryBuffer for Erlang
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-126:
-------------------------------
Patch Info: [Patch Available]
> TMemoryBuffer for Erlang
> ------------------------
>
> Key: THRIFT-126
> URL: https://issues.apache.org/jira/browse/THRIFT-126
> Project: Thrift
> Issue Type: New Feature
> Components: Library (Erlang)
> Reporter: David Reiss
> Assignee: David Reiss
> Priority: Minor
>
> TMemoryBuffer is really helpful for testing protocol changes. I just implemented it for Erlang. Patch in a moment.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.