You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Nathan Hartman <ha...@gmail.com> on 2019/12/08 06:04:44 UTC
1.9.x release notes, SVN-4722
While replying on users@ [1] I noticed that the 1.9.x Release Notes
make no mention of SVN-4722, which affects 1.9.7, and is
fixed in 1.9.9+. This is the bug where a delta length being an exact
multiple of 16k causes an undeserved "filesystem is corrupt" error
during 'svn commit'.
Should this be added to the Known Issues section of the 1.9.x Release
Notes?
Something like this:
[[[
Commit can fail with an undeserved "Filesystem is corrupt" error
See issue 4722, "checksum fail during commit when delta is 16K".
Under a very specific set of circumstances, a commit may fail with an
undeserved "Filesystem is corrupt" error. This bug affects the 1.9.7
release only. A fix for this problem has been included in the 1.9.9
release.
]]]
(The line mentioning issue 4722 would have a link to
https://issues.apache.org/jira/browse/SVN-4722?issueNumber=4722.)
Nathan
[1] Thread on users@:
https://lists.apache.org/thread.html/60320cd79bcfd8adc7d03c7aa42545bb6e6eb99cd031ea746a2227b6%40%3Cusers.subversion.apache.org%3E
Re: 1.9.x release notes, SVN-4722
Posted by Stefan Sperling <st...@elego.de>.
On Sun, Dec 08, 2019 at 01:04:44AM -0500, Nathan Hartman wrote:
> While replying on users@ [1] I noticed that the 1.9.x Release Notes
> make no mention of SVN-4722, which affects 1.9.7, and is
> fixed in 1.9.9+. This is the bug where a delta length being an exact
> multiple of 16k causes an undeserved "filesystem is corrupt" error
> during 'svn commit'.
>
> Should this be added to the Known Issues section of the 1.9.x Release
> Notes?
>
> Something like this:
>
> [[[
>
> Commit can fail with an undeserved "Filesystem is corrupt" error
>
> See issue 4722, "checksum fail during commit when delta is 16K".
>
> Under a very specific set of circumstances, a commit may fail with an
> undeserved "Filesystem is corrupt" error. This bug affects the 1.9.7
> release only. A fix for this problem has been included in the 1.9.9
> release.
>
> ]]]
>
> (The line mentioning issue 4722 would have a link to
> https://issues.apache.org/jira/browse/SVN-4722?issueNumber=4722.)
>
> Nathan
>
Yes, this is a good idea. Having this paragraph in our release notes
will increase the chance that someone searching for this error message
will find the correct answer.
Re: 1.9.x release notes, SVN-4722
Posted by Nathan Hartman <ha...@gmail.com>.
On Tue, Dec 10, 2019 at 1:56 AM Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> > 1.9 release notes: Document known issue SVN-4722 in 1.9.6 and 1.9.7
> Historically, we've usually used the section's id in the «(symbol name)»
> part of the log message. In fact, I'd probably have written this as just:
>
> (#svn-4722): New subsection.
Fixed. Thank you.
> +1 to commit.
Done in r1871139.
Thanks for all your review efforts and input.
Nathan
Re: 1.9.x release notes, SVN-4722
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Nathan Hartman wrote on Tue, Dec 10, 2019 at 01:22:41 -0500:
> On Mon, Dec 9, 2019 at 10:22 PM Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> > There were multiple security issues fixed in later 1.9 patch releases; see
> > https://subversion.apache.org/security/
>
> Yes. I see quite a few affecting various 1.9.x. I will handle these
> separately.
Thanks.
> 1.9 release notes: Document known issue SVN-4722 in 1.9.6 and 1.9.7
>
> * docs/release-notes/1.9.html
> (Known issues in the release): Add new subsection,
> "Commit can fail with an undeserved SHA1 collision error,"
> to document issue SVN-4722, which affects 1.9.6 and 1.9.7.
Historically, we've usually used the section's id in the «(symbol name)»
part of the log message. In fact, I'd probably have written this as just:
(#svn-4722): New subsection.
This affects searchability of the logs.
In INSTALL this wouldn't make as much sense, though, because sections of INSTALL
don't have stable identifiers.
> +++ 1.9.html (working copy)
> @@ -1466,6 +1466,26 @@
>
> </div> <!-- shattered-sha1 -->
*nod*
> +<div class="h3" id="svn-4722">
> +<h3>Commit can fail with an undeserved SHA1 collision error
> + <a class="sectionlink" href="#svn-4722"
> + title="Link to this section">¶</a>
> +</h3>
> +
> +<p>See <a href="https://issues.apache.org/jira/browse/SVN-4722?issueNumber=4722"
> +>issue 4722, "checksum fail during commit when delta is 16K"</a>.
> +</p>
Consider moving the above paragraph to be last, immediately before the </div>
tag. (I think it'll read better that way, but YMMV.)
> +<p>When using a Subversion 1.9.6 or 1.9.7 server, a commit may fail
> +with an undeserved SHA1 collision error: "E160000: SHA1 of reps
> +… and … matches (…) but contents differ." This
> +bug affects the 1.9.6 and 1.9.7 releases.</p>
> +
> +<p>A fix for this problem has been included in the 1.9.9 release
> +(1.9.8 was not publicly released).</p>
> +
> +</div> <!-- svn-4722 -->
> +
> </div> <!-- issues -->
>
> <div class="h2" id="troubleshooting">
+1 to commit.
Re: 1.9.x release notes, SVN-4722
Posted by Nathan Hartman <ha...@gmail.com>.
On Mon, Dec 9, 2019 at 10:22 PM Daniel Shahaf <d....@daniel.shahaf.name> wrote:
>
> Change «"Filesystem is corrupt"» in the section title to match the actual error
> message?
Good catch! Fixed.
A more careful reading of SVN-4722 and the 1.9.x CHANGES file made me
realize that this issue affected 1.9.6 and 1.9.7 (previously I wrote
1.9.7 only). It was introduced in 1.9.6 with SHA1 collision avoidance.
(The 1.9.7 release was a fix for CVE-2017-9800 only.) So I updated the
text to reflect that. I also fixed a number of formatting issues and
made it consistent with other fixed issues in the document.
> There were multiple security issues fixed in later 1.9 patch releases; see
> https://subversion.apache.org/security/
Yes. I see quite a few affecting various 1.9.x. I will handle these
separately.
If the following seems reasonable, I'll go ahead and commit it later:
Log:
[[[
1.9 release notes: Document known issue SVN-4722 in 1.9.6 and 1.9.7
* docs/release-notes/1.9.html
(Known issues in the release): Add new subsection,
"Commit can fail with an undeserved SHA1 collision error,"
to document issue SVN-4722, which affects 1.9.6 and 1.9.7.
Review by: danielsh
]]]
Patch:
[[[
Index: 1.9.html
===================================================================
--- 1.9.html (revision 1871119)
+++ 1.9.html (working copy)
@@ -1466,6 +1466,26 @@
</div> <!-- shattered-sha1 -->
+<div class="h3" id="svn-4722">
+<h3>Commit can fail with an undeserved SHA1 collision error
+ <a class="sectionlink" href="#svn-4722"
+ title="Link to this section">¶</a>
+</h3>
+
+<p>See <a href="https://issues.apache.org/jira/browse/SVN-4722?issueNumber=4722"
+>issue 4722, "checksum fail during commit when delta is 16K"</a>.
+</p>
+
+<p>When using a Subversion 1.9.6 or 1.9.7 server, a commit may fail
+with an undeserved SHA1 collision error: "E160000: SHA1 of reps
+… and … matches (…) but contents differ." This
+bug affects the 1.9.6 and 1.9.7 releases.</p>
+
+<p>A fix for this problem has been included in the 1.9.9 release
+(1.9.8 was not publicly released).</p>
+
+</div> <!-- svn-4722 -->
+
</div> <!-- issues -->
<div class="h2" id="troubleshooting">
]]]
Nathan
Re: 1.9.x release notes, SVN-4722
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Nathan Hartman wrote on Mon, Dec 09, 2019 at 10:42:39 -0500:
> +<div class="h3" id="svn-4722">
> +<h3>Commit can fail with an undeserved "Filesystem is corrupt" error
> + <a class="sectionlink" href="#svn-4722"
> + title="Link to this section">¶</a>
> +</h3>
> +
> +<p>See issue 4722, "checksum fail during commit when delta is 16K".
> +</p>
> +
> +<p>When using a Subversion 1.9.7 server, a commit may fail with an
> +undeserved SHA1 collision error: "E160000: SHA1 of reps ... and ...
> +matches (...) but contents differ." For details, see
> +<a href="https://issues.apache.org/jira/browse/SVN-4722?issueNumber=4722"
> +>issue 4722, "checksum fail during commit when delta is 16K"</a>. This
> +bug affects the 1.9.7 release only. A fix for this problem has been
> +included in the 1.9.9 release (1.9.8 was not publicly released).
> +</p>
> +
Change «"Filesystem is corrupt"» in the section title to match the actual error
message?
> I know it's not terribly high priority to go back and fill in old
> release notes but it seems to me (based on discussions and questions
> we get) that many people are still using 1.9.7 on the server. Some are
> using older OS distros. Others are using Subversion packages that
> install onto a NAS. In any case, they have 1.9.7 because they haven't
> received updates. Maybe they don't see any issues in the release notes
> affecting versions later than 1.9.6 so they don't think it's important
> to update.
There were multiple security issues fixed in later 1.9 patch releases; see
https://subversion.apache.org/security/
> There are other bugs fixes in later 1.9.x as well. It's better to
> write it down than to keep it in my head.
Re: 1.9.x release notes, SVN-4722
Posted by Nathan Hartman <ha...@gmail.com>.
On Sun, Dec 8, 2019 at 10:38 PM Daniel Shahaf <d....@daniel.shahaf.name> wrote:
>
> Nathan Hartman wrote on Sun, 08 Dec 2019 06:04 +00:00:
> > Commit can fail with an undeserved "Filesystem is corrupt" error
> >
> > See issue 4722, "checksum fail during commit when delta is 16K".
> >
> > Under a very specific set of circumstances, a commit may fail with an
> > undeserved "Filesystem is corrupt" error. This bug affects the 1.9.7
> > release only. A fix for this problem has been included in the 1.9.9
> > release.
>
> Anyone reading this is going to wonder if either version number is a
> typo. Clarify that they aren't? E.g., say that "1.9.8 was not
> publicly released".
Agreed. More below:
> Having the error's number and the specific error message, if any, will be
> helpful. If they are stated on the JIRA issue or on the thread, it would be
> nice to quote them in the release notes. If they're not immediately available,
> however, in principle we could reconstruct them by reproducing the bug with
> 1.9.7; however, in light of 1.9's EOL schedule, I wouldn't consider it high
> priority to reconstruct those details.
>
> The string printed is svn_strerror(SVN_ERR_FS_CORRUPT), so the error number is
> probably E160004.
The original email to users@ mentions the error:
[[[
D:\confidential>svn commit secret.bin -m "Testing broken commit"
Sending secret.bin
Transmitting file data .svn: E160000: Commit failed (details follow):
svn: E160000: SHA1 of reps '604440 34 134255 136680
c9f4fabc4d093612fece03c339401058
db11617ef1454332336e00abc311d44bc698f3b3 605556-czmh/_8' and '-1 0
134255 136680 c9f4fabc4d093612fece03c339401058
db11617ef1454332336e00abc311d44bc698f3b3 605556-czmh/_8' matches
(db11617ef1454332336e00abc311d44bc698f3b3) but contents differ
]]]
Link:
https://svn.haxx.se/users/archive-2018-02/0098.shtml
also at:
http://mail-archives.apache.org/mod_mbox/subversion-users/201802.mbox/%3cCAJM5Lfu2+fDDmmc4938LrsF=UHEuRY9cprf2LKvg0CsCVp36AQ@mail.gmail.com%3e
I'm not sure where the "filesystem is corrupt" idea comes from. It may
have just been caused by people describing the problem in loose terms.
So I think I'll write:
[[[
Index: 1.9.html
===================================================================
--- 1.9.html (revision 1871084)
+++ 1.9.html (working copy)
@@ -1466,6 +1466,26 @@
</div> <!-- shattered-sha1 -->
+<div class="h3" id="svn-4722">
+<h3>Commit can fail with an undeserved "Filesystem is corrupt" error
+ <a class="sectionlink" href="#svn-4722"
+ title="Link to this section">¶</a>
+</h3>
+
+<p>See issue 4722, "checksum fail during commit when delta is 16K".
+</p>
+
+<p>When using a Subversion 1.9.7 server, a commit may fail with an
+undeserved SHA1 collision error: "E160000: SHA1 of reps ... and ...
+matches (...) but contents differ." For details, see
+<a href="https://issues.apache.org/jira/browse/SVN-4722?issueNumber=4722"
+>issue 4722, "checksum fail during commit when delta is 16K"</a>. This
+bug affects the 1.9.7 release only. A fix for this problem has been
+included in the 1.9.9 release (1.9.8 was not publicly released).
+</p>
+
+</div> <!-- svn-4722 -->
+
</div> <!-- issues -->
<div class="h2" id="troubleshooting">
]]]
I know it's not terribly high priority to go back and fill in old
release notes but it seems to me (based on discussions and questions
we get) that many people are still using 1.9.7 on the server. Some are
using older OS distros. Others are using Subversion packages that
install onto a NAS. In any case, they have 1.9.7 because they haven't
received updates. Maybe they don't see any issues in the release notes
affecting versions later than 1.9.6 so they don't think it's important
to update.
There are other bugs fixes in later 1.9.x as well. It's better to
write it down than to keep it in my head.
Nathan
Re: 1.9.x release notes, SVN-4722
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Nathan Hartman wrote on Sun, 08 Dec 2019 06:04 +00:00:
> Commit can fail with an undeserved "Filesystem is corrupt" error
>
> See issue 4722, "checksum fail during commit when delta is 16K".
>
> Under a very specific set of circumstances, a commit may fail with an
> undeserved "Filesystem is corrupt" error. This bug affects the 1.9.7
> release only. A fix for this problem has been included in the 1.9.9
> release.
Anyone reading this is going to wonder if either version number is a
typo. Clarify that they aren't? E.g., say that "1.9.8 was not
publicly released".
Having the error's number and the specific error message, if any, will be
helpful. If they are stated on the JIRA issue or on the thread, it would be
nice to quote them in the release notes. If they're not immediately available,
however, in principle we could reconstruct them by reproducing the bug with
1.9.7; however, in light of 1.9's EOL schedule, I wouldn't consider it high
priority to reconstruct those details.
The string printed is svn_strerror(SVN_ERR_FS_CORRUPT), so the error number is
probably E160004.
Thanks,
Daniel
> ]]]
>
> (The line mentioning issue 4722 would have a link to
> https://issues.apache.org/jira/browse/SVN-4722?issueNumber=4722.)
>
> Nathan
>
> [1] Thread on users@:
> https://lists.apache.org/thread.html/60320cd79bcfd8adc7d03c7aa42545bb6e6eb99cd031ea746a2227b6%40%3Cusers.subversion.apache.org%3E
>