You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@celeborn.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/08/10 02:46:37 UTC

[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1802: [CELEBORN-884][BUILD] Consolidate all dependencies into a global object `Dependencies`

pan3793 commented on code in PR #1802:
URL: https://github.com/apache/incubator-celeborn/pull/1802#discussion_r1289477050


##########
project/CelebornBuild.scala:
##########
@@ -55,20 +43,81 @@ object CelebornCommonSettings {
   val guavaVersion = "14.0.1"
   val hadoopVersion = "3.2.4"
   val javaxServletVersion = "3.1.0"
+  val junitInterfaceVersion = "0.13.3"
+  // don't forget update `junitInterfaceVersion` when we upgrade junit

Review Comment:
   seems no strong contract?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org