You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2026/06/22 21:42:10 UTC

[native-toolchain-CR] IMPALA-15010: Patch gperftools to use size t for thread cache sizes

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24497


Change subject: IMPALA-15010: Patch gperftools to use size_t for thread cache sizes
......................................................................

IMPALA-15010: Patch gperftools to use size_t for thread cache sizes

When we allowed a larger total thread cache size in IMPALA-13479,
it introduced the possibility of wrapping the int32_t thread
cache size. This switches the thread cache sizes to use size_t
to avoid any possibility of wrapping. Google TCMalloc had already
made this change for their thread caching implementation.

This also introduces the latest gperftools 2.18.1 and drops
gperftools 2.15.

Change-Id: I39d981b55b5bce9f30a4870b2d0b92fb568f9de4
---
M buildall.sh
A source/gperftools/gperftools-2.10-patches/0002-Use-size_t-for-thread-cache-sizes.patch
D source/gperftools/gperftools-2.15-patches/0001-Remove-1GB-thread-cache-limit.patch
A source/gperftools/gperftools-2.18.1-patches/0001-Remove-1GB-thread-cache-limit.patch
A source/gperftools/gperftools-2.18.1-patches/0002-Use-size_t-for-thread-cache-sizes.patch
5 files changed, 77 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/97/24497/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39d981b55b5bce9f30a4870b2d0b92fb568f9de4
Gerrit-Change-Number: 24497
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[native-toolchain-CR] IMPALA-15010: Patch gperftools to use size t for thread cache sizes

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24497 )

Change subject: IMPALA-15010: Patch gperftools to use size_t for thread cache sizes
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39d981b55b5bce9f30a4870b2d0b92fb568f9de4
Gerrit-Change-Number: 24497
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Jul 2026 20:24:32 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-15010: Patch gperftools to use size t for thread cache sizes

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24497 )

Change subject: IMPALA-15010: Patch gperftools to use size_t for thread cache sizes
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39d981b55b5bce9f30a4870b2d0b92fb568f9de4
Gerrit-Change-Number: 24497
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Aug 2026 23:36:19 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-15010: Patch gperftools to use size t for thread cache sizes

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24497 )

Change subject: IMPALA-15010: Patch gperftools to use size_t for thread cache sizes
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39d981b55b5bce9f30a4870b2d0b92fb568f9de4
Gerrit-Change-Number: 24497
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Jul 2026 18:22:10 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-15010: Patch gperftools to use size t for thread cache sizes

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24497 )

Change subject: IMPALA-15010: Patch gperftools to use size_t for thread cache sizes
......................................................................

IMPALA-15010: Patch gperftools to use size_t for thread cache sizes

When we allowed a larger total thread cache size in IMPALA-13479,
it introduced the possibility of wrapping the int32_t thread
cache size. This switches the thread cache sizes to use size_t
to avoid any possibility of wrapping. Google TCMalloc had already
made this change for their thread caching implementation.

This also introduces the latest gperftools 2.18.1 and drops
gperftools 2.15.

Change-Id: I39d981b55b5bce9f30a4870b2d0b92fb568f9de4
Reviewed-on: http://gerrit.cloudera.org:8080/24497
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M buildall.sh
A source/gperftools/gperftools-2.10-patches/0002-Use-size_t-for-thread-cache-sizes.patch
D source/gperftools/gperftools-2.15-patches/0001-Remove-1GB-thread-cache-limit.patch
A source/gperftools/gperftools-2.18.1-patches/0001-Remove-1GB-thread-cache-limit.patch
A source/gperftools/gperftools-2.18.1-patches/0002-Use-size_t-for-thread-cache-sizes.patch
5 files changed, 77 insertions(+), 13 deletions(-)

Approvals:
  Joe McDonnell: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I39d981b55b5bce9f30a4870b2d0b92fb568f9de4
Gerrit-Change-Number: 24497
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[native-toolchain-CR] IMPALA-15010: Patch gperftools to use size t for thread cache sizes

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24497 )

Change subject: IMPALA-15010: Patch gperftools to use size_t for thread cache sizes
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39d981b55b5bce9f30a4870b2d0b92fb568f9de4
Gerrit-Change-Number: 24497
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jul 2026 21:31:43 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-15010: Patch gperftools to use size t for thread cache sizes

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24497 )

Change subject: IMPALA-15010: Patch gperftools to use size_t for thread cache sizes
......................................................................


Patch Set 3: Code-Review+2

Rebased, carrying +2


-- 
To view, visit http://gerrit.cloudera.org:8080/24497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39d981b55b5bce9f30a4870b2d0b92fb568f9de4
Gerrit-Change-Number: 24497
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Aug 2026 16:46:37 +0000
Gerrit-HasComments: No