[GitHub] dlg99 commented on issue #1309: Refactored OrderedSafeExecutor and OrderedScheduler

[GitBox <gi...@apache.org>]

dlg99 commented on issue #1309: Refactored OrderedSafeExecutor and OrderedScheduler
URL: https://github.com/apache/bookkeeper/pull/1309#issuecomment-377992333
 
 
   @merlimat @jvrao "337.974 ± 325.934" is a smell. it's too much of a range.
   Results of "JDK-ThreadPool" and "OrderedExecutor" are close except OE's have wide range.
   It is either a problem with test or with the change itself. Change looks ok to me so let's assume the test is at fault.
   
   looking at microbenchmark, it always uses 1 threaded  executor and 16 threads that submit/wait for tasks. I think it hits bottleneck in that one thread's rather than in the queue passing tasks between threads. I'd create executor with 8 (half or producer's) threads an give it a shot. or run the test with 1/2/4/8/16 threads in executor, use num threads as another \@Param for the test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services