[jira] [Commented] (AVRO-4084) CommonsSchemasTests.cc does not compile on windows

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892711#comment-17892711 ] 

ASF subversion and git services commented on AVRO-4084:
-------------------------------------------------------

Commit ed85a819a286e155980b9a3c56cfc15f9e12f64b in avro's branch refs/heads/main from glywk
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=ed85a819a ]

[AVRO-4084][C++] Fix bad filesystem::path conversion type on windows (#3220)

Co-authored-by: blissful <de...@blissful.fr>

> CommonsSchemasTests.cc does not compile on windows
> --------------------------------------------------
>
>                 Key: AVRO-4084
>                 URL: https://issues.apache.org/jira/browse/AVRO-4084
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.12.0
>            Reporter: Guillaume Labourey
>            Assignee: Guillaume Labourey
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> {code:java}
> ***\lang\c++\test\CommonsSchemasTests.cc(44,55): Reason : cannot convert from 'const std::filesystem::path::value_type *' to 'const avro::DataFileReader<avro::GenericDatum> {code}
> On Windows, {{std::filesystem::path::value_type}} is based on {{wchar_t}} and not on {{{}char{}}}. ([std::filesystem::path|https://en.cppreference.com/w/cpp/filesystem/path]). That's why {{DataFileReader<>}} constructor is not compatible with the filesystem::path default string conversion operator.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)