You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by je...@apache.org on 2020/07/02 06:59:09 UTC

[incubator-nuttx-apps] branch master updated: example/helloxx: Remove EXAMPLES_HELLOXX_NOSTACKCONST

This is an automated email from the ASF dual-hosted git repository.

jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git


The following commit(s) were added to refs/heads/master by this push:
     new 4e10b69  example/helloxx: Remove EXAMPLES_HELLOXX_NOSTACKCONST
4e10b69 is described below

commit 4e10b692f8fbecfc3ef6393a7fb6bb515c277546
Author: Xiang Xiao <xi...@xiaomi.com>
AuthorDate: Thu Jul 2 12:12:09 2020 +0800

    example/helloxx: Remove EXAMPLES_HELLOXX_NOSTACKCONST
    
    since this config doesn't appear inside examples/helloxx/Kconfig anymore and
    there is any c++ compiler can't construct the stack object as far as I know
    
    Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
    Change-Id: I0297d192df3beaa78ae7ee75f24ae51476bb30a9
---
 examples/README.txt               | 2 --
 examples/helloxx/helloxx_main.cxx | 2 --
 2 files changed, 4 deletions(-)

diff --git a/examples/README.txt b/examples/README.txt
index de4c759..fa6ba3e 100644
--- a/examples/README.txt
+++ b/examples/README.txt
@@ -540,8 +540,6 @@ examples/helloxx
 
     CONFIG_NSH_BUILTIN_APPS -- Build the helloxx example as a
       "built-in"  that can be executed from the NSH command line.
-    CONFIG_EXAMPLES_HELLOXX_NOSTACKCONST - Set if the system does not
-      support construction of objects on the stack.
 
   Also needed:
 
diff --git a/examples/helloxx/helloxx_main.cxx b/examples/helloxx/helloxx_main.cxx
index 2edae81..1829383 100644
--- a/examples/helloxx/helloxx_main.cxx
+++ b/examples/helloxx/helloxx_main.cxx
@@ -128,12 +128,10 @@ extern "C"
 
     // Exercise an C++ object instantiated on the stack
 
-#ifndef CONFIG_EXAMPLES_HELLOXX_NOSTACKCONST
     CHelloWorld HelloWorld;
 
     printf("helloxx_main: Saying hello from the instance constructed on the stack\n");
     HelloWorld.HelloWorld();
-#endif
 
     // Exercise an statically constructed C++ object