You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "James Dyer (Created) (JIRA)" <ji...@apache.org> on 2012/03/20 17:07:39 UTC
[jira] [Created] (SOLR-3260) Improve exception handling / logging
for ScriptTranformer.init()
Improve exception handling / logging for ScriptTranformer.init()
----------------------------------------------------------------
Key: SOLR-3260
URL: https://issues.apache.org/jira/browse/SOLR-3260
Project: Solr
Issue Type: Bug
Components: contrib - DataImportHandler
Affects Versions: 3.5, 4.0
Reporter: James Dyer
Assignee: James Dyer
Priority: Trivial
Fix For: 3.6, 4.0
This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "James Dyer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233860#comment-13233860 ]
James Dyer commented on SOLR-3260:
----------------------------------
That is probably the right thing to do. If its using a JRE that supports the class "javax.script.ScriptEngineManager" but there are nop ScriptingEngines installed, you'll get the "Cannot load Script Engine..." message. I am a bit confused why it is giving the "eval failed..." message though.
Why don't you make the fix you've proposed and I'll look later to see if there is something less-blunt we can do. Sound ok?
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234449#comment-13234449 ]
Steven Rowe commented on SOLR-3260:
-----------------------------------
I see we got the same failures on the trunk Maven build today: https://builds.apache.org/job/Lucene-Solr-Maven-trunk/431/testReport/
I'll forward-port my test-skipping changes to trunk.
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234854#comment-13234854 ]
Steven Rowe commented on SOLR-3260:
-----------------------------------
{quote}
> > class "javax.servlet.FilterRegistration"'s signer information does not
> > match signer information of other classes in the same package
>
> I have seen this before when servlet-2.5 and servlet-api 3.0 are both in the classpath
Yeah, I'm testing a change to the solr-core POM that would make the servlet dependency use the "provided" scope, which would exclude it from the runtime classpath.
Seems to fix the trunk failures you're referring to in the DIH tests. Running all Solr tests locally now before I commit the change.
{quote}
See SOLR-3263
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "James Dyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer updated SOLR-3260:
-----------------------------
Summary: Improve exception handling / logging for ScriptTransformer.init() (was: Improve exception handling / logging for ScriptTranformer.init())
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233851#comment-13233851 ]
Steven Rowe commented on SOLR-3260:
-----------------------------------
Hi James,
The branch_3x Maven Jenkins job is now failing in {{TestScriptTransformer}} as a result of your commit from this issue, e.g. https://builds.apache.org/job/Lucene-Solr-Maven-3.x/432/testReport/.
I'd like to expand the set of exception message checked in the JUnit assumptions that allow tests to be skipped to include the two new messages your changes on this issue introduced:
Currently:
{noformat}
} catch (DataImportHandlerException e) {
assumeFalse("JRE does not contain a JavaScript engine (OpenJDK)", e.getMessage().startsWith("<script> can be used only in java 6 or above"));
throw e;
}
{noformat}
Expanded:
{noformat}
} catch (DataImportHandlerException e) {
assumeFalse("JRE does not contain a JavaScript engine (OpenJDK)",
e.getMessage().startsWith("<script> can be used only in java 6 or above")
|| e.getMessage().startsWith("Cannot load Script Engine for language:")
|| e.getMessage().startsWith("'eval' failed with language:"));
throw e;
}
{noformat}
What do you think?
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "James Dyer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234036#comment-13234036 ]
James Dyer commented on SOLR-3260:
----------------------------------
Thanks, Steven! I'll look a little bit more at this tomorrow. Sorry to break the build.
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233871#comment-13233871 ]
Steven Rowe commented on SOLR-3260:
-----------------------------------
bq. I am a bit confused why it is giving the "eval failed..." message though.
It's an NPE, but beyond that I'm not sure what's happening.
The branch_3x Maven job compiles under a 1.5 JDK, then runs tests via Maven's Surefire plugin under a 1.6 (OpenJDK) JVM.
These tests appear to pass on the Solr_3x job under the same 1.6 JVM, though, so there's something weird going on here. (The Solr_3x job runs under Ant, but I'm not sure why the Ant/Maven difference would be the cause of this.)
bq. Why don't you make the fix you've proposed and I'll look later to see if there is something less-blunt we can do. Sound ok?
Sure, I'll commit those changes now.
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234477#comment-13234477 ]
Steven Rowe commented on SOLR-3260:
-----------------------------------
{quote}
bq. class "javax.servlet.FilterRegistration"'s signer information does not match signer information of other classes in the same package
I have seen this before when servlet-2.5 and servlet-api 3.0 are both in the classpath
{quote}
Yeah, I'm testing a change to the solr-core POM that would make the servlet dependency use the "provided" scope, which would exclude it from the runtime classpath.
Seems to fix the trunk failures you're referring to in the DIH tests. Running all Solr tests locally now before I commit the change.
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234451#comment-13234451 ]
Steven Rowe commented on SOLR-3260:
-----------------------------------
bq. In light of the maven 3.x failure, I think I need to move some of the reflection calls from the 3nd try/catch to the 2nd. This means we can ignore 2 of the 3 exceptions instead of all 3.
+1
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "James Dyer (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer resolved SOLR-3260.
------------------------------
Resolution: Fixed
Trunk: r1303470 - Removed reflection as Trunk uses JRE 1.6+. Unit Test no longer ignores exceptions.
Branch_3x: r1303464 - moved things in try/catch blocks so as to be able to ignore 1 fewer exception (also better from a user's perspective)
Hopefully this is it!
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "Ryan McKinley (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234472#comment-13234472 ]
Ryan McKinley commented on SOLR-3260:
-------------------------------------
bq. class "javax.servlet.FilterRegistration"'s signer information does not match signer information of other classes in the same package
I have seen this before when servlet-2.5 and servlet-api 3.0 are both in the classpath
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235600#comment-13235600 ]
Steven Rowe commented on SOLR-3260:
-----------------------------------
James, the trunk Maven build is still unhappy:
{noformat}
Build: https://builds.apache.org/job/Lucene-Solr-Maven-trunk/433/
1 tests failed.
FAILED: org.apache.solr.handler.dataimport.TestScriptTransformer.testOneparam
Error Message:
Cannot load Script Engine for language: JavaScript
Stack Trace:
org.apache.solr.handler.dataimport.DataImportHandlerException: Cannot load Script Engine for language: JavaScript
at org.apache.solr.handler.dataimport.ScriptTransformer.initEngine(ScriptTransformer.java:76)
{noformat}
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233876#comment-13233876 ]
Steven Rowe commented on SOLR-3260:
-----------------------------------
I committed the test skipping changes to branch_3x. I haven't seen the same problem (yet) on trunk, so I'll hold off there.
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "James Dyer (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235609#comment-13235609 ]
James Dyer commented on SOLR-3260:
----------------------------------
I missed one. Sorry about that. Should be fixed now.
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Reopened] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "James Dyer (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer reopened SOLR-3260:
------------------------------
In light of the maven 3.x failure, I think I need to move some of the reflection calls from the 3nd try/catch to the 2nd. This means we can ignore 2 of the 3 exceptions instead of all 3.
For trunk, I can change this to not use reflection at all since we require a 1.6+ jvm. However, this can still fail if the scripting engines are not in the jvms so these checks need to stay in place.
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "Steven Rowe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235688#comment-13235688 ]
Steven Rowe commented on SOLR-3260:
-----------------------------------
bq. I missed one. Sorry about that. Should be fixed now.
Thanks James, I think it's fixed - just now in the console output from the Jenkins Maven trunk job (still running as I write this), I saw:
{noformat}
Running org.apache.solr.handler.dataimport.TestScriptTransformer
NOTE: Assume failed in 'testCheckScript(org.apache.solr.handler.dataimport.TestScriptTransformer)' (ignored): got: <org.apache.lucene.util.InternalAssumptionViolatedException: failed assumption: This JVM does not have Rhino installed. Test Skipped.>, expected: null
NOTE: Assume failed in 'testBasic(org.apache.solr.handler.dataimport.TestScriptTransformer)' (ignored): got: <org.apache.lucene.util.InternalAssumptionViolatedException: failed assumption: This JVM does not have Rhino installed. Test Skipped.>, expected: null
NOTE: Assume failed in 'testOneparam(org.apache.solr.handler.dataimport.TestScriptTransformer)' (ignored): got: <org.apache.lucene.util.InternalAssumptionViolatedException: failed assumption: This JVM does not have Rhino installed. Test Skipped.>, expected: null
Tests run: 4, Failures: 0, Errors: 0, Skipped: 3, Time elapsed: 0.023 sec
{noformat}
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3260) Improve exception handling / logging
for ScriptTransformer.init()
Posted by "James Dyer (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer resolved SOLR-3260.
------------------------------
Resolution: Fixed
committed.
Trunk: r1302972
Branch_3x: r1303042
> Improve exception handling / logging for ScriptTransformer.init()
> -----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3260) Improve exception handling / logging
for ScriptTranformer.init()
Posted by "James Dyer (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Dyer updated SOLR-3260:
-----------------------------
Attachment: SOLR-3260.patch
I will commit this shortly.
> Improve exception handling / logging for ScriptTranformer.init()
> ----------------------------------------------------------------
>
> Key: SOLR-3260
> URL: https://issues.apache.org/jira/browse/SOLR-3260
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.5, 4.0
> Reporter: James Dyer
> Assignee: James Dyer
> Priority: Trivial
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-3260.patch
>
>
> This came up on the user-list. ScriptTransformer logs the same "need a >=1.6 jre" message for several problems, making debugging difficult for users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org