You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "waynexia (via GitHub)" <gi...@apache.org> on 2023/08/31 03:39:40 UTC

[GitHub] [arrow-datafusion] waynexia opened a new pull request, #7455: minor: do not fail analyzer if subquery plan contains extension

waynexia opened a new pull request, #7455:
URL: https://github.com/apache/arrow-datafusion/pull/7455

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   ## Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   If some analyze rule inserts extension plan, the post-analyze check will fail.
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   It looks acceptable for an analyzer rule to do so and can simply "ignore" extension plan node, e.g., the outermost node can either be `[Projection, Filter, Window, Aggregate, Join]`, or an extension node
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   n/a
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   n/a
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb merged pull request #7455: minor: do not fail analyzer if subquery plan contains extension

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #7455:
URL: https://github.com/apache/arrow-datafusion/pull/7455


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #7455: minor: do not fail analyzer if subquery plan contains extension

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #7455:
URL: https://github.com/apache/arrow-datafusion/pull/7455#discussion_r1316221793


##########
datafusion/optimizer/src/analyzer/subquery.rs:
##########
@@ -338,3 +339,57 @@ fn check_mixed_out_refer_in_window(window: &Window) -> Result<()> {
         Ok(())
     }
 }
+
+#[cfg(test)]

Review Comment:
   I recommend putting this test somewhere in https://github.com/apache/arrow-datafusion/tree/main/datafusion/core/tests/user_defined (mostly so it is easier to find and to ensure everything is working as expected)
   
   I think you may be able to reuse the dummy user defined code there



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] waynexia commented on a diff in pull request #7455: minor: do not fail analyzer if subquery plan contains extension

Posted by "waynexia (via GitHub)" <gi...@apache.org>.
waynexia commented on code in PR #7455:
URL: https://github.com/apache/arrow-datafusion/pull/7455#discussion_r1316851165


##########
datafusion/optimizer/src/analyzer/subquery.rs:
##########
@@ -338,3 +339,57 @@ fn check_mixed_out_refer_in_window(window: &Window) -> Result<()> {
         Ok(())
     }
 }
+
+#[cfg(test)]

Review Comment:
   Great suggestion. I plan to cover this case in `datafusion/core/tests/user_defined/user_defined_plan.rs`. But since the previous TopK is based on optimizer, I may need to add another extension plan and an analyzer rule.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org