You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/12/29 16:33:38 UTC

Review Request 29458: Ambari overrides user/groups settings configured by cluster admins

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29458/
-----------------------------------------------------------

Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-8940
    https://issues.apache.org/jira/browse/AMBARI-8940


Repository: ambari


Description
-------

Seen at Altiscale who were trying to use YARN with docker on an Ambari
deployed cluster.

Docker requires users to be in the "docker" group to be able to launch docker
containers. As a result, the user "yarn", which Ambari creates and adds to the
"hadoop" group, was changed to belong to both the "docker" and "hadoop"
groups.

However, after making this change on all nodes, we noticed that the the yarn
user was being removed from the docker group.


Diffs
-----

  ambari-common/src/main/python/resource_management/core/providers/accounts.py c99b775 
  ambari-common/src/main/python/resource_management/core/providers/system.py 1c4313c 
  ambari-common/src/main/python/resource_management/core/resources/accounts.py b6200fa 

Diff: https://reviews.apache.org/r/29458/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 29458: Ambari overrides user/groups settings configured by cluster admins

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29458/#review66271
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Dec. 29, 2014, 4:08 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29458/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2014, 4:08 p.m.)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-8940
>     https://issues.apache.org/jira/browse/AMBARI-8940
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Seen at Altiscale who were trying to use YARN with docker on an Ambari
> deployed cluster.
> 
> Docker requires users to be in the "docker" group to be able to launch docker
> containers. As a result, the user "yarn", which Ambari creates and adds to the
> "hadoop" group, was changed to belong to both the "docker" and "hadoop"
> groups.
> 
> However, after making this change on all nodes, we noticed that the the yarn
> user was being removed from the docker group.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/providers/accounts.py c99b775 
>   ambari-common/src/main/python/resource_management/core/providers/system.py 1c4313c 
>   ambari-common/src/main/python/resource_management/core/resources/accounts.py b6200fa 
> 
> Diff: https://reviews.apache.org/r/29458/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 29458: Ambari overrides user/groups settings configured by cluster admins

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29458/#review66272
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On Дек. 29, 2014, 4:08 п.п., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29458/
> -----------------------------------------------------------
> 
> (Updated Дек. 29, 2014, 4:08 п.п.)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-8940
>     https://issues.apache.org/jira/browse/AMBARI-8940
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Seen at Altiscale who were trying to use YARN with docker on an Ambari
> deployed cluster.
> 
> Docker requires users to be in the "docker" group to be able to launch docker
> containers. As a result, the user "yarn", which Ambari creates and adds to the
> "hadoop" group, was changed to belong to both the "docker" and "hadoop"
> groups.
> 
> However, after making this change on all nodes, we noticed that the the yarn
> user was being removed from the docker group.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/providers/accounts.py c99b775 
>   ambari-common/src/main/python/resource_management/core/providers/system.py 1c4313c 
>   ambari-common/src/main/python/resource_management/core/resources/accounts.py b6200fa 
> 
> Diff: https://reviews.apache.org/r/29458/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 29458: Ambari overrides user/groups settings configured by cluster admins

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29458/#review66277
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Dec. 29, 2014, 4:22 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29458/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2014, 4:22 p.m.)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-8940
>     https://issues.apache.org/jira/browse/AMBARI-8940
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Seen at Altiscale who were trying to use YARN with docker on an Ambari
> deployed cluster.
> 
> Docker requires users to be in the "docker" group to be able to launch docker
> containers. As a result, the user "yarn", which Ambari creates and adds to the
> "hadoop" group, was changed to belong to both the "docker" and "hadoop"
> groups.
> 
> However, after making this change on all nodes, we noticed that the the yarn
> user was being removed from the docker group.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/providers/accounts.py c99b775 
>   ambari-common/src/main/python/resource_management/core/providers/system.py 1c4313c 
>   ambari-common/src/main/python/resource_management/core/resources/accounts.py b6200fa 
>   ambari-common/src/main/python/resource_management/libraries/functions/get_namenode_states.py f1dcaa2 
>   contrib/fast-hdfs-resource/dependency-reduced-pom.xml c252f2e 
> 
> Diff: https://reviews.apache.org/r/29458/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 29458: Ambari overrides user/groups settings configured by cluster admins

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29458/
-----------------------------------------------------------

(Updated Dec. 29, 2014, 4:22 p.m.)


Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-8940
    https://issues.apache.org/jira/browse/AMBARI-8940


Repository: ambari


Description
-------

Seen at Altiscale who were trying to use YARN with docker on an Ambari
deployed cluster.

Docker requires users to be in the "docker" group to be able to launch docker
containers. As a result, the user "yarn", which Ambari creates and adds to the
"hadoop" group, was changed to belong to both the "docker" and "hadoop"
groups.

However, after making this change on all nodes, we noticed that the the yarn
user was being removed from the docker group.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/core/providers/accounts.py c99b775 
  ambari-common/src/main/python/resource_management/core/providers/system.py 1c4313c 
  ambari-common/src/main/python/resource_management/core/resources/accounts.py b6200fa 
  ambari-common/src/main/python/resource_management/libraries/functions/get_namenode_states.py f1dcaa2 
  contrib/fast-hdfs-resource/dependency-reduced-pom.xml c252f2e 

Diff: https://reviews.apache.org/r/29458/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 29458: Ambari overrides user/groups settings configured by cluster admins

Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29458/#review66270
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Гру. 29, 2014, 6:08 після полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29458/
> -----------------------------------------------------------
> 
> (Updated Гру. 29, 2014, 6:08 після полудня)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-8940
>     https://issues.apache.org/jira/browse/AMBARI-8940
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Seen at Altiscale who were trying to use YARN with docker on an Ambari
> deployed cluster.
> 
> Docker requires users to be in the "docker" group to be able to launch docker
> containers. As a result, the user "yarn", which Ambari creates and adds to the
> "hadoop" group, was changed to belong to both the "docker" and "hadoop"
> groups.
> 
> However, after making this change on all nodes, we noticed that the the yarn
> user was being removed from the docker group.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/core/providers/accounts.py c99b775 
>   ambari-common/src/main/python/resource_management/core/providers/system.py 1c4313c 
>   ambari-common/src/main/python/resource_management/core/resources/accounts.py b6200fa 
> 
> Diff: https://reviews.apache.org/r/29458/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 29458: Ambari overrides user/groups settings configured by cluster admins

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29458/
-----------------------------------------------------------

(Updated Dec. 29, 2014, 4:08 p.m.)


Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-8940
    https://issues.apache.org/jira/browse/AMBARI-8940


Repository: ambari


Description
-------

Seen at Altiscale who were trying to use YARN with docker on an Ambari
deployed cluster.

Docker requires users to be in the "docker" group to be able to launch docker
containers. As a result, the user "yarn", which Ambari creates and adds to the
"hadoop" group, was changed to belong to both the "docker" and "hadoop"
groups.

However, after making this change on all nodes, we noticed that the the yarn
user was being removed from the docker group.


Diffs
-----

  ambari-common/src/main/python/resource_management/core/providers/accounts.py c99b775 
  ambari-common/src/main/python/resource_management/core/providers/system.py 1c4313c 
  ambari-common/src/main/python/resource_management/core/resources/accounts.py b6200fa 

Diff: https://reviews.apache.org/r/29458/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 29458: Ambari overrides user/groups settings configured by cluster admins

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29458/
-----------------------------------------------------------

(Updated Dec. 29, 2014, 3:58 p.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-8940
    https://issues.apache.org/jira/browse/AMBARI-8940


Repository: ambari


Description
-------

Seen at Altiscale who were trying to use YARN with docker on an Ambari
deployed cluster.

Docker requires users to be in the "docker" group to be able to launch docker
containers. As a result, the user "yarn", which Ambari creates and adds to the
"hadoop" group, was changed to belong to both the "docker" and "hadoop"
groups.

However, after making this change on all nodes, we noticed that the the yarn
user was being removed from the docker group.


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/core/providers/accounts.py c99b775 
  ambari-common/src/main/python/resource_management/core/providers/system.py 1c4313c 
  ambari-common/src/main/python/resource_management/core/resources/accounts.py b6200fa 

Diff: https://reviews.apache.org/r/29458/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 29458: Ambari overrides user/groups settings configured by cluster admins

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29458/
-----------------------------------------------------------

(Updated Dec. 29, 2014, 3:52 p.m.)


Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-8940
    https://issues.apache.org/jira/browse/AMBARI-8940


Repository: ambari


Description
-------

Seen at Altiscale who were trying to use YARN with docker on an Ambari
deployed cluster.

Docker requires users to be in the "docker" group to be able to launch docker
containers. As a result, the user "yarn", which Ambari creates and adds to the
"hadoop" group, was changed to belong to both the "docker" and "hadoop"
groups.

However, after making this change on all nodes, we noticed that the the yarn
user was being removed from the docker group.


Diffs (updated)
-----

  ambari-agent/src/test/python/resource_management/TestUserResource.py f66b738 
  ambari-common/src/main/python/resource_management/core/providers/accounts.py c99b775 
  ambari-common/src/main/python/resource_management/core/providers/system.py 1c4313c 
  ambari-common/src/main/python/resource_management/core/resources/accounts.py b6200fa 

Diff: https://reviews.apache.org/r/29458/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk