You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by "Kevin Wilfong (JIRA)" <ji...@apache.org> on 2013/02/01 07:31:14 UTC

[jira] [Commented] (HIVE-3970) Clean up/fix PartitionNameWhitelistPreEventListener

    [ https://issues.apache.org/jira/browse/HIVE-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13568521#comment-13568521 ] 

Kevin Wilfong commented on HIVE-3970:
-------------------------------------

https://reviews.facebook.net/D8337
                
> Clean up/fix PartitionNameWhitelistPreEventListener
> ---------------------------------------------------
>
>                 Key: HIVE-3970
>                 URL: https://issues.apache.org/jira/browse/HIVE-3970
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 0.11.0
>            Reporter: Kevin Wilfong
>            Assignee: Kevin Wilfong
>         Attachments: HIVE-3970.1.patch.txt
>
>
> There are a number of issues and things which can be cleaned up related to PartitionNameWhitelistPreEventListener.
> * It's an event listener, but it really doesn't need to be given that the regex whitelist is configurable, it could just be a utility method.
> * It's not run when a partition is renamed, so partitions with invalid characters can be created in this way.
> * There's no easy way to check if a partition contains invalid characters before creating it and seeing if it fails.
> Most importantly, when a dynamic partition contains an invalid character, the directory for this partition is created, and the data is moved into it, but the partition fails to be created leaving an orphan directory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira